Revert "Use constexpr initializers for AtomicHashArray Config"

Summary: D2284130 broke the HHVM clang build.

Reviewed By: @mxw

Differential Revision: D2303914

diff --git a/folly/AtomicHashArray.h b/folly/AtomicHashArray.h
index be78769563deac4c2dc130eeeed0da5265597399..7f12f862ca1af68e0fc5d5b0de24af5ad6e0886b 100644 (file)
--- a/folly/AtomicHashArray.h
+++ b/folly/AtomicHashArray.h
@@ -128,15 +128,9 @@ class AtomicHashArray : boost::noncopyable {
     int    entryCountThreadCacheSize;
     size_t capacity; // if positive, overrides maxLoadFactor
 
-  private:
-    static constexpr KeyT kEmptyKey = (KeyT)-1;
-    static constexpr KeyT kLockedKey = (KeyT)-2;
-    static constexpr KeyT kErasedKey = (KeyT)-3;
-
-  public:
-    constexpr Config() : emptyKey(kEmptyKey),
-                         lockedKey(kLockedKey),
-                         erasedKey(kErasedKey),
+    constexpr Config() : emptyKey((KeyT)-1),
+                         lockedKey((KeyT)-2),
+                         erasedKey((KeyT)-3),
                          maxLoadFactor(0.8),
                          growthFactor(-1),
                          entryCountThreadCacheSize(1000),

diff --git a/folly/AtomicLinkedList.h b/folly/AtomicLinkedList.h
index f24746a5d1f6f8e0f7c234f75f5dfd2d1a99853a..eca8de16d9b32450cdab81876ae1c3834c6c9efe 100644 (file)
--- a/folly/AtomicLinkedList.h
+++ b/folly/AtomicLinkedList.h
@@ -63,7 +63,7 @@ class AtomicLinkedList {
    * Note: list must be empty on destruction.
    */
   ~AtomicLinkedList() {
-    assert(empty());
+    assert(head_ == nullptr);
   }
 
   bool empty() const {