folly/gen/Parallel-inl.h: trivial -Wsign-compare fix
authorJim Meyering <meyering@fb.com>
Tue, 6 Jan 2015 20:48:38 +0000 (12:48 -0800)
committerViswanath Sivakumar <viswanath@fb.com>
Tue, 13 Jan 2015 19:01:04 +0000 (11:01 -0800)
Summary:
* folly/gen/Parallel-inl.h (folly): Use a for-loop index of type
size_t (not "int") to match type of upper bound.
Otherwise, gcc-4.9 fails with this:
folly/gen/Parallel-inl.h:242:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

Test Plan:
Run this and note there are fewer errors than before:
fbconfig --platform-all=gcc-4.9-glibc-2.20 -r folly && fbmake dbgo

Reviewed By: davejwatson@fb.com

Subscribers: folly-diffs@

FB internal diff: D1767160

Tasks: 5941250

Signature: t1:1767160:1420577886:6acfb7f6d50ed715dcf4058841aeabc39fa99cbc

folly/gen/Parallel-inl.h

index ab37f7d82c3c95400cf445e03f23582b4cb71c6b..666acb16d1e356c6a192ce177bb2af899cb6d931 100644 (file)
@@ -239,7 +239,7 @@ class Parallel : public Operator<Parallel<Ops>> {
             ops_(ops) {
         inQueue_.openProducer();
         outQueue_.openConsumer();
-        for (int t = 0; t < threads; ++t) {
+        for (size_t t = 0; t < threads; ++t) {
           inQueue_.openConsumer();
           outQueue_.openProducer();
           workers_.emplace_back([this] {