(folly osx) test for the zip, not the dir
authorHans Fugal <fugalh@fb.com>
Mon, 16 Mar 2015 18:02:03 +0000 (11:02 -0700)
committerAndre Azevedo <aap@fb.com>
Wed, 18 Mar 2015 03:18:46 +0000 (20:18 -0700)
Summary: Apparently `configure` creates this subdirectory and then the curl and unzip commands don't run, and then `make check` fails. Instead, do it if the zip file doesn't exist.

Test Plan:
git clone https://github.com/facebook/folly.git
cd folly/folly
/path/to/this/bootstrap-osx-homebrew.sh
make
make check

Reviewed By: andrei.alexandrescu@fb.com

Subscribers: exa, folly-diffs@, yfeldblum, davejwatson

FB internal diff: D1882472

Signature: t1:1882472:1425920470:bdab25967d3b8e52c690d5627168077c65829b92

folly/bootstrap-osx-homebrew.sh

index da1f73ed24be33542696bfa1a2cce41a809a41b1..9843c5e0a8e2812814119dbb1b17f9f2f26dd858 100755 (executable)
@@ -37,7 +37,7 @@ autoreconf -i
 ./configure CPPFLAGS=-I"$DOUBLE_CONVERSION_HOME/src" LDFLAGS=-L"$DOUBLE_CONVERSION_HOME"
 
 pushd test
-test -d gtest-1.7.0 || {
+test -e gtest-1.7.0.zip || {
     curl -O https://googletest.googlecode.com/files/gtest-1.7.0.zip
     unzip gtest-1.7.0.zip
 }