OSX compat fixes

Summary:
fix OSX compat issues

Github Author: Daniel Sloof <goapsychadelic@gmail.com>

Test Plan: - compiled

Reviewed By: pt@fb.com

FB internal diff: D877309

diff --git a/folly/Bits.h b/folly/Bits.h
index 0b45f84f36c066204ef41310c37de8c568a15a54..2b5225243ea74c2db0c54793879487a700ff7a52 100644 (file)
--- a/folly/Bits.h
+++ b/folly/Bits.h
@@ -57,10 +57,6 @@
 
 #include "folly/Portability.h"
 
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE 1
-#endif
-
 #ifndef __GNUC__
 #error GCC required
 #endif

diff --git a/folly/experimental/symbolizer/Dwarf.cpp b/folly/experimental/symbolizer/Dwarf.cpp
index fd78907c524d51a9fa959b5fb5cb926f6204cedd..7ad5af1df533beb57013ccd276700b6a45e4c667 100644 (file)
--- a/folly/experimental/symbolizer/Dwarf.cpp
+++ b/folly/experimental/symbolizer/Dwarf.cpp
@@ -639,7 +639,7 @@ bool Dwarf::LineNumberVM::nextDefineFile(folly::StringPiece& program,
     auto length = readULEB(program);
     // the opcode itself should be included in the length, so length >= 1
     enforce(length != 0, "invalid extended opcode length");
-    auto extendedOpcode = read<uint8_t>(program);
+    read<uint8_t>(program); // extended opcode
     --length;
 
     if (opcode == DW_LNE_define_file) {

diff --git a/folly/io/RecordIO.cpp b/folly/io/RecordIO.cpp
index 566ce36564d7f2f43d71d6b6207e81988526bc4b..a407505736b9b6a211e2afd3729661da28857cdb 100644 (file)
--- a/folly/io/RecordIO.cpp
+++ b/folly/io/RecordIO.cpp
@@ -201,7 +201,6 @@ RecordInfo findRecord(ByteRange searchRange,
   static const uint32_t magic = Header::kMagic;
   static const ByteRange magicRange(reinterpret_cast<const uint8_t*>(&magic),
                                     sizeof(magic));
-  static constexpr size_t headerTail = sizeof(Header) - sizeof(magic);
 
   DCHECK_GE(searchRange.begin(), wholeRange.begin());
   DCHECK_LE(searchRange.end(), wholeRange.end());