fix double comparison in histogram test
authorAdam Simpkins <simpkins@fb.com>
Wed, 5 Jul 2017 19:56:00 +0000 (12:56 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Wed, 5 Jul 2017 20:05:59 +0000 (13:05 -0700)
Summary:
The TestDoubleWidthTooBig test was performing an exact equality check on
two double values. This equality check fails when run on 32-bit
platforms.

Replace the EXPECT_EQ() check with EXPECT_NEAR(), and simply check that
the two values do not differ by more than 1e-14.

Reviewed By: Orvid

Differential Revision: D652767

fbshipit-source-id: 7bf7ed560a4180a2e2d07a6050d1df18e18d1eea

folly/stats/test/HistogramTest.cpp

index 122362122c75648e8675667c93d1c2fd5b8cb137..7f6b4f1f339b4b3f46913a1b52a8abd8e1ee61dc 100644 (file)
@@ -200,7 +200,7 @@ TEST(Histogram, TestDoubleWidthTooBig) {
   EXPECT_EQ(1, h.getBucketByIndex(0).count);
   h.addValue(7.5);
   EXPECT_EQ(1, h.getBucketByIndex(2).count);
-  EXPECT_EQ(3.0, h.getPercentileEstimate(0.5));
+  EXPECT_NEAR(3.0, h.getPercentileEstimate(0.5), 1e-14);
 }
 
 // Test that we get counts right