Fix zlib + lzma memory usage inefficiency

Summary:
Since IOBuf rounds to a good malloc size, zlib and lzma waste space.
For a 4 MiB `length`, about 1 MiB of the IOBuf is wasted.

Reviewed By: yfeldblum

Differential Revision: D4872830

fbshipit-source-id: 42fc83277b2dae22b75403e0e71c43e8f2b19f21

diff --git a/folly/io/Compression.cpp b/folly/io/Compression.cpp
index ae75b2a6a38a958c39ca4f6f32051eeeca21c6da..4a9deaaf554737c921562dfd687de6c81bc219c5 100644 (file)
--- a/folly/io/Compression.cpp
+++ b/folly/io/Compression.cpp
@@ -840,7 +840,7 @@ std::unique_ptr<IOBuf> ZlibCodec::addOutputBuffer(z_stream* stream,
   CHECK_EQ(stream->avail_out, 0);
 
   auto buf = IOBuf::create(length);
   CHECK_EQ(stream->avail_out, 0);
 
   auto buf = IOBuf::create(length);

-  buf->append(length);
+  buf->append(buf->capacity());

 
   stream->next_out = buf->writableData();
   stream->avail_out = buf->length();
 
   stream->next_out = buf->writableData();
   stream->avail_out = buf->length();


@@ -1147,7 +1147,7 @@ std::unique_ptr<IOBuf> LZMA2Codec::addOutputBuffer(
   CHECK_EQ(stream->avail_out, 0);
 
   auto buf = IOBuf::create(length);
   CHECK_EQ(stream->avail_out, 0);
 
   auto buf = IOBuf::create(length);

-  buf->append(length);
+  buf->append(buf->capacity());

 
   stream->next_out = buf->writableData();
   stream->avail_out = buf->length();
 
   stream->next_out = buf->writableData();
   stream->avail_out = buf->length();