Gate SysMembarrier to not FOLLY_MOBILE platforms

Summary: Gate `kIsLinux` to not include `FOLLY_MOBILE` because "mobile" linux does not really behave like real linux.

Differential Revision: D3697717

fbshipit-source-id: 1b0f4208d2f71c35399c30f20a71bfa4ba4724e8

diff --git a/folly/Portability.h b/folly/Portability.h
index 5776a0073bd2a0c3b7acc8c637d55264ada32032..56dc7c95c2a59c1994f2cde035518a1f512c8374 100644 (file)
--- a/folly/Portability.h
+++ b/folly/Portability.h
@@ -357,7 +357,7 @@ using namespace FOLLY_GFLAGS_NAMESPACE;
 
 namespace folly {
 
 
 namespace folly {
 

-#ifdef __linux__
+#if defined(__linux__) && !FOLLY_MOBILE

 constexpr auto kIsLinux = true;
 #else
 constexpr auto kIsLinux = false;
 constexpr auto kIsLinux = true;
 #else
 constexpr auto kIsLinux = false;

diff --git a/folly/portability/SysMembarrier.cpp b/folly/portability/SysMembarrier.cpp
index cc4b43ac827279dbf7f30a389c8f5c08b33ed5ff..9a3d307390a9445818b0ca991c468a6b9fc76c92 100644 (file)
--- a/folly/portability/SysMembarrier.cpp
+++ b/folly/portability/SysMembarrier.cpp
@@ -22,12 +22,14 @@
 #include <folly/portability/SysSyscall.h>
 #include <folly/portability/Unistd.h>
 
 #include <folly/portability/SysSyscall.h>
 #include <folly/portability/Unistd.h>
 

-#if !defined(__NR_membarrier) && FOLLY_X64 && !FOLLY_MOBILE && \
-    defined(__linux__)
+#if FOLLY_X64 && !FOLLY_MOBILE && defined(__linux__)
+#define FOLLY_USE_SYS_MEMBARRIER 1
+#if !defined(__NR_membarrier)

 #define __NR_membarrier 324
 #define MEMBARRIER_CMD_QUERY 0
 #define MEMBARRIER_CMD_SHARED 1
 #endif
 #define __NR_membarrier 324
 #define MEMBARRIER_CMD_QUERY 0
 #define MEMBARRIER_CMD_SHARED 1
 #endif

+#endif

 
 namespace folly {
 namespace detail {
 
 namespace folly {
 namespace detail {


@@ -37,7 +39,7 @@ bool sysMembarrierAvailable() {
     return false;
   }
 
     return false;
   }
 

-#ifdef __NR_membarrier
+#if FOLLY_USE_SYS_MEMBARRIER

   auto r = syscall(__NR_membarrier, MEMBARRIER_CMD_QUERY, /* flags = */ 0);
   if (r == -1) {
     return false;
   auto r = syscall(__NR_membarrier, MEMBARRIER_CMD_QUERY, /* flags = */ 0);
   if (r == -1) {
     return false;


@@ -50,7 +52,7 @@ bool sysMembarrierAvailable() {
 }
 
 int sysMembarrier() {
 }
 
 int sysMembarrier() {

-#ifdef __NR_membarrier
+#if FOLLY_USE_SYS_MEMBARRIER

   return syscall(__NR_membarrier, MEMBARRIER_CMD_SHARED, /* flags = */ 0);
 #else
   return -1;
   return syscall(__NR_membarrier, MEMBARRIER_CMD_SHARED, /* flags = */ 0);
 #else
   return -1;