Schedule destroyInstances in registrationComplete

Summary: This makes it more likely that SingletonVaultDestructor won't be created after atexit calls.

Test Plan: unit test

Reviewed By: chip@fb.com

Subscribers: hphp-diffs@, ps, njormrod, folly-diffs@

FB internal diff: D1629804

Tasks: 5353022

diff --git a/folly/experimental/Singleton.h b/folly/experimental/Singleton.h
index 1d6c9a78c83397bee0216bf61870986cbab2ea29..ff0ef56faa7a5bc643f677e964fdc493dca717dd 100644 (file)
--- a/folly/experimental/Singleton.h
+++ b/folly/experimental/Singleton.h
@@ -208,6 +208,8 @@ class SingletonVault {
   // Mark registration is complete; no more singletons can be
   // registered at this point.
   void registrationComplete() {
+    scheduleDestroyInstances();
+
     RWSpinLock::WriteHolder wh(&stateMutex_);
 
     stateCheck(SingletonVaultState::Running);