projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2218031) | patch
Make some AsyncTest methods virtual to allow mocking them using gtest/gmock
authorMaxim Georgiev <maxgeorg@fb.com>
Tue, 4 Apr 2017 19:16:07 +0000 (12:16 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Tue, 4 Apr 2017 19:21:02 +0000 (12:21 -0700)
commit96791c4516497b4ea2ad08af12e4267bd1c4e796
treed9cd85a3ad9764defc8ed73b9cb89d2c1014e55btree | snapshot
parent221803182695d393d2a076c3833900c240499310commit | diff
Make some AsyncTest methods virtual to allow mocking them using gtest/gmock

Summary: GMock can't mock class methods that are not virtual. This way classes relying on the non-virtual methods of AsyncSocket can't be efficiently tested using gtest/gmock.

Reviewed By: yfeldblum

Differential Revision: D4806838

fbshipit-source-id: fde852b75f7ac1d468c177e317c516cb0dc333b5
folly/io/async/AsyncSocket.h diff | blob | history
folly/io/async/test/MockAsyncSocket.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.