regulator: rockchip: lp8752: fix up the compile warning
authorElaine Zhang <zhangqing@rock-chips.com>
Mon, 9 May 2016 09:46:14 +0000 (17:46 +0800)
committerGerrit Code Review <gerrit@rock-chips.com>
Tue, 10 May 2016 01:20:40 +0000 (09:20 +0800)
fix up the warning:
drivers/regulator/lp8752.c: In function 'lp8752_buck_set_mode':
drivers/regulator/lp8752.c:93:2: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Change-Id: Iee9f69791bbcea2e6b3a16713b76e93cfc0a2b67
Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
drivers/regulator/lp8752.c

index 6222f72b6cf29d7e3bfdbf8aef4de9c102ffd32b..0062dee31a59b09f5120745a724005046768a23f 100644 (file)
@@ -81,12 +81,16 @@ static int lp8752_buck_set_mode(struct regulator_dev *rdev, unsigned int mode)
                ret = regmap_update_bits(pchip->regmap,
                                         rdev->desc->enable_reg,
                                         msk, 0x1);
+               break;
        case REGULATOR_MODE_NORMAL:
                /* automatic pwm/pfm mode */
                ret = regmap_update_bits(pchip->regmap,
                                         rdev->desc->enable_reg,
                                         msk, 0x0);
+               break;
        default:
+               dev_err(pchip->dev, "error:lp8752 only support auto and pwm mode\n");
+               ret = -EINVAL;
                break;
        }