ALSA: firewire-tascam: Fix to handle error from initialization of stream data
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 3 Jan 2017 02:58:33 +0000 (11:58 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 15 Jan 2017 12:41:36 +0000 (13:41 +0100)
commit 6a2a2f45560a9cb7bc49820883b042e44f83726c upstream.

This module has a bug not to return error code in a case that data
structure for transmitted packets fails to be initialized.

This commit fixes the bug.

Fixes: 35efa5c489de ("ALSA: firewire-tascam: add streaming functionality")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/firewire/tascam/tascam-stream.c

index 0e6dd5c61f5388afc39cdaca33bff884ec5ad748..e4c306398b35c84e65ab6429271f5f9c2460c2f6 100644 (file)
@@ -343,7 +343,7 @@ int snd_tscm_stream_init_duplex(struct snd_tscm *tscm)
        if (err < 0)
                amdtp_stream_destroy(&tscm->rx_stream);
 
-       return 0;
+       return err;
 }
 
 /* At bus reset, streaming is stopped and some registers are clear. */