qed: Fix setting/clearing bit in completion bitmap
authorManish Chopra <manish.chopra@qlogic.com>
Mon, 25 Jul 2016 16:07:46 +0000 (19:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Aug 2016 07:30:48 +0000 (09:30 +0200)
[ Upstream commit 59d3f1ceb69b54569685d0c34dff16a1e0816b19 ]

Slowpath completion handling is incorrectly changing
SPQ_RING_SIZE bits instead of a single one.

Fixes: 76a9a3642a0b ("qed: fix handling of concurrent ramrods")
Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/qlogic/qed/qed_spq.c

index 3dd548ab8df14aabf9fa6a551cf54aa97f704d12..40365cb1abe6c33f7d90661c639333d24b569c27 100644 (file)
@@ -794,13 +794,12 @@ int qed_spq_completion(struct qed_hwfn *p_hwfn,
                         * in a bitmap and increasing the chain consumer only
                         * for the first successive completed entries.
                         */
-                       bitmap_set(p_spq->p_comp_bitmap, pos, SPQ_RING_SIZE);
+                       __set_bit(pos, p_spq->p_comp_bitmap);
 
                        while (test_bit(p_spq->comp_bitmap_idx,
                                        p_spq->p_comp_bitmap)) {
-                               bitmap_clear(p_spq->p_comp_bitmap,
-                                            p_spq->comp_bitmap_idx,
-                                            SPQ_RING_SIZE);
+                               __clear_bit(p_spq->comp_bitmap_idx,
+                                           p_spq->p_comp_bitmap);
                                p_spq->comp_bitmap_idx++;
                                qed_chain_return_produced(&p_spq->chain);
                        }