netrom: fix invalid use of sizeof in nr_recvmsg()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 9 Apr 2013 02:07:19 +0000 (10:07 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Apr 2013 02:49:23 +0000 (22:49 -0400)
sizeof() when applied to a pointer typed expression gives the size of the
pointer, not that of the pointed data.
Introduced by commit 3ce5ef(netrom: fix info leak via msg_name in nr_recvmsg)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netrom/af_netrom.c

index 7fcb307dea47516502e74b28c83df403ef5a54e6..103bd704b5fc39e24d07714dd6831ca2d3bf036a 100644 (file)
@@ -1173,7 +1173,7 @@ static int nr_recvmsg(struct kiocb *iocb, struct socket *sock,
        }
 
        if (sax != NULL) {
-               memset(sax, 0, sizeof(sax));
+               memset(sax, 0, sizeof(*sax));
                sax->sax25_family = AF_NETROM;
                skb_copy_from_linear_data_offset(skb, 7, sax->sax25_call.ax25_call,
                              AX25_ADDR_LEN);