Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux...
authorJames Morris <james.l.morris@oracle.com>
Thu, 18 Jun 2015 13:28:40 +0000 (23:28 +1000)
committerJames Morris <james.l.morris@oracle.com>
Thu, 18 Jun 2015 13:28:40 +0000 (23:28 +1000)
drivers/char/tpm/tpm_crb.c
drivers/char/tpm/tpm_ibmvtpm.c
drivers/char/tpm/tpm_of.c

index b26ceee3585e1fbd91bff48cc6f75984a739f488..44f9d20c19ac6e7724b66fae3329ae7111c8e61e 100644 (file)
@@ -267,7 +267,7 @@ static int crb_acpi_add(struct acpi_device *device)
 
        memcpy_fromio(&pa, &priv->cca->cmd_pa, 8);
        pa = le64_to_cpu(pa);
-       priv->cmd = devm_ioremap_nocache(dev, le64_to_cpu(pa),
+       priv->cmd = devm_ioremap_nocache(dev, pa,
                                         ioread32(&priv->cca->cmd_size));
        if (!priv->cmd) {
                dev_err(dev, "ioremap of the command buffer failed\n");
@@ -276,7 +276,7 @@ static int crb_acpi_add(struct acpi_device *device)
 
        memcpy_fromio(&pa, &priv->cca->rsp_pa, 8);
        pa = le64_to_cpu(pa);
-       priv->rsp = devm_ioremap_nocache(dev, le64_to_cpu(pa),
+       priv->rsp = devm_ioremap_nocache(dev, pa,
                                         ioread32(&priv->cca->rsp_size));
        if (!priv->rsp) {
                dev_err(dev, "ioremap of the response buffer failed\n");
index 42ffa5e7a1e0f6c912a0e214e67a3a99d1511a08..27ebf9511cb41cdf5e26fc1f82a65ecab9a60d33 100644 (file)
@@ -578,6 +578,9 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
                goto cleanup;
        }
 
+       ibmvtpm->dev = dev;
+       ibmvtpm->vdev = vio_dev;
+
        crq_q = &ibmvtpm->crq_queue;
        crq_q->crq_addr = (struct ibmvtpm_crq *)get_zeroed_page(GFP_KERNEL);
        if (!crq_q->crq_addr) {
@@ -622,8 +625,6 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 
        crq_q->index = 0;
 
-       ibmvtpm->dev = dev;
-       ibmvtpm->vdev = vio_dev;
        TPM_VPRIV(chip) = (void *)ibmvtpm;
 
        spin_lock_init(&ibmvtpm->rtce_lock);
index c002d1bd9cafe316668a6f3ab7864fe25e35db12..eebe6256918f31f07e999f3ecf8e3a9fc0caa648 100644 (file)
@@ -49,7 +49,7 @@ int read_log(struct tpm_bios_log *log)
 
        basep = of_get_property(np, "linux,sml-base", NULL);
        if (basep == NULL) {
-               pr_err(KERN_ERR "%s: ERROR - SML not found\n", __func__);
+               pr_err("%s: ERROR - SML not found\n", __func__);
                goto cleanup_eio;
        }