phy: rockchip-emmc: enable internal pull-down for strobe line
authorShawn Lin <shawn.lin@rock-chips.com>
Tue, 19 Jul 2016 02:16:26 +0000 (10:16 +0800)
committerShawn Lin <shawn.lin@rock-chips.com>
Tue, 19 Jul 2016 02:16:26 +0000 (10:16 +0800)
We enable it by default as we could see the usage of PCB layout
will not stuff this registor. For currently boards which soldered
it already, there should be no harmful.

Change-Id: Idc05c244dbaeebb1028e4828aa7a7d655899beb8
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
drivers/phy/phy-rockchip-emmc.c

index 2853e0e..a184a0f 100644 (file)
@@ -79,6 +79,9 @@
 #define PHYCTRL_OTAPDLYENA_SHIFT       11
 #define PHYCTRL_OTAPDLYSEL_MASK                0xf
 #define PHYCTRL_OTAPDLYSEL_SHIFT       7
+#define PHYCTRL_REN_STRB_ENABLE                0x1
+#define PHYCTRL_REN_STRB_MASK          0x1
+#define PHYCTRL_REN_STRB_SHIFT         9
 
 struct rockchip_emmc_phy {
        unsigned int    reg_offset;
@@ -203,6 +206,12 @@ static int rockchip_emmc_phy_init(struct phy *phy)
                                   PHYCTRL_OTAPDLYENA_MASK,
                                   PHYCTRL_OTAPDLYENA_SHIFT));
 
+       regmap_write(rk_phy->reg_base,
+                    rk_phy->reg_offset + GRF_EMMCPHY_CON2,
+                    HIWORD_UPDATE(PHYCTRL_REN_STRB_ENABLE,
+                                  PHYCTRL_REN_STRB_MASK,
+                                  PHYCTRL_REN_STRB_SHIFT));
+
        regmap_write(rk_phy->reg_base,
                     rk_phy->reg_offset + GRF_EMMCPHY_CON0,
                     HIWORD_UPDATE(rk_phy->opdelay,