rtc: HYM8563: don't call rtc_year_days
authorHuang, Tao <huangtao@rock-chips.com>
Thu, 12 Mar 2015 07:48:12 +0000 (15:48 +0800)
committerHuang, Tao <huangtao@rock-chips.com>
Thu, 12 Mar 2015 07:48:12 +0000 (15:48 +0800)
If i2c error, the driver may call rtc_year_days with month -1, which will
cause crash. Fix this by never call rtc_year_days at all.

Signed-off-by: Huang, Tao <huangtao@rock-chips.com>
drivers/rtc/rtc-HYM8563.c

index c20f4b867bfe6ea9fd21a023ad0bcb302408106a..056bd3e050d549aaf0482e66ae8f1e1d96716f8b 100755 (executable)
@@ -227,7 +227,6 @@ static int hym8563_read_datetime(struct i2c_client *client, struct rtc_time *tm)
        else
                tm->tm_year += 2000;
                
-       tm->tm_yday = rtc_year_days(tm->tm_mday, tm->tm_mon, tm->tm_year);      
        tm->tm_year -= 1900;                    //inorder to cooperate the systerm time 
        if(tm->tm_year < 0)
                tm->tm_year = 0;