UPSTREAM: f2fs: avoid hungtask problem caused by losing wake_up
authorYunlei He <heyunlei@huawei.com>
Tue, 23 Feb 2016 04:07:56 +0000 (12:07 +0800)
committerHuang, Tao <huangtao@rock-chips.com>
Tue, 8 Nov 2016 02:13:01 +0000 (10:13 +0800)
The D state of wait_on_all_pages_writeback should be waken by
function f2fs_write_end_io when all writeback pages have been
succesfully written to device. It's possible that wake_up comes
between get_pages and io_schedule. Maybe in this case it will
lost wake_up and still in D state even if all pages have been
write back to device, and finally, the whole system will be into
the hungtask state.

                if (!get_pages(sbi, F2FS_WRITEBACK))
                         break;
<---------  wake_up
                io_schedule();

Change-Id: I8a60393c91343d75b7d48df2ca19d1735d69cc51
Signed-off-by: Yunlei He <heyunlei@huawei.com>
Signed-off-by: Biao He <hebiao6@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
(cherry picked from commit 0ff21646f2a5c6ff77acc51eb3df4235af39be46)
Signed-off-by: Cliff Chen <cliff.chen@rock-chips.com>
fs/f2fs/checkpoint.c

index f661d80474be7ab8f91de74525fa65198cfa68f9..341fb0e6784c86e933148932825ec38c04a8dbb8 100644 (file)
@@ -914,7 +914,7 @@ static void wait_on_all_pages_writeback(struct f2fs_sb_info *sbi)
                if (!get_pages(sbi, F2FS_WRITEBACK))
                        break;
 
                if (!get_pages(sbi, F2FS_WRITEBACK))
                        break;
 
-               io_schedule();
+               io_schedule_timeout(5*HZ);
        }
        finish_wait(&sbi->cp_wait, &wait);
 }
        }
        finish_wait(&sbi->cp_wait, &wait);
 }