ARM: shmobile: apmu: correct type of CPU id
authorAndrzej Hajda <a.hajda@samsung.com>
Mon, 21 Sep 2015 13:33:45 +0000 (15:33 +0200)
committerSimon Horman <horms+renesas@verge.net.au>
Fri, 2 Oct 2015 01:56:05 +0000 (10:56 +0900)
CPU id can be negative, so it cannot be assigned to unsigned variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
arch/arm/mach-shmobile/platsmp-apmu.c

index bcf4cc51b926c4796e19dffb73229ef5b8c3b7ac..911884f7e28b174c271c6724c863520afe859868 100644 (file)
@@ -88,7 +88,7 @@ static void apmu_init_cpu(struct resource *res, int cpu, int bit)
 static void apmu_parse_cfg(void (*fn)(struct resource *res, int cpu, int bit),
                           struct rcar_apmu_config *apmu_config, int num)
 {
-       u32 id;
+       int id;
        int k;
        int bit, index;
        bool is_allowed;