ALSA: firewire-tascam: fix an LED bug

We recently tried to add some new code to support turning the LED on and
off but the code in snd_tscm_transaction_reregister() is unreachable.

Fixes: e65e2cb99e44 ('ALSA: firewire-tascam: Turn on/off FireWire LED')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/firewire/tascam/tascam-transaction.c b/sound/firewire/tascam/tascam-transaction.c
index 1c9a88be55c83b2bdab066717092ba339083248d..45c3ce3d6020c985c89cf94c995d736a2aff8375 100644 (file)
--- a/sound/firewire/tascam/tascam-transaction.c
+++ b/sound/firewire/tascam/tascam-transaction.c
@@ -249,7 +249,7 @@ int snd_tscm_transaction_reregister(struct snd_tscm *tscm)
 
        /* Turn on messaging. */
        reg = cpu_to_be32(0x00000001);
-       return snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
+       err = snd_fw_transaction(tscm->unit, TCODE_WRITE_QUADLET_REQUEST,
                                  TSCM_ADDR_BASE + TSCM_OFFSET_MIDI_TX_ON,
                                  &reg, sizeof(reg), 0);
        if (err < 0)