UPSTREAM: mac80211: fix "warning: ‘target_metric’ may be used uninitialized"
authorJeff Mahoney <jeffm@suse.com>
Mon, 4 Apr 2016 18:15:23 +0000 (14:15 -0400)
committerAmit Pundir <amit.pundir@linaro.org>
Thu, 19 May 2016 07:05:53 +0000 (12:35 +0530)
(This cherry-picks b4201cc4fc6e1c57d6d306b1f787865043d60129 upstream)

This fixes:

net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be used uninitialized in this function

target_metric is only consumed when reply = true so no bug exists here,
but not all versions of gcc realize it.  Initialize to 0 to remove the
warning.

Change-Id: I13923fda9d314f48196c29e4354133dfe01f5abd
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
[jstultz: Cherry-picked to android-4.4]
Signed-off-by: John Stultz <john.stultz@linaro.org>
net/mac80211/mesh_hwmp.c

index c6be0b4f405888489b21cee009b267d95f626c34..b6dc2d7cd6501ac01a04a17e47584ae0dc36ae80 100644 (file)
@@ -530,7 +530,7 @@ static void hwmp_preq_frame_process(struct ieee80211_sub_if_data *sdata,
        const u8 *target_addr, *orig_addr;
        const u8 *da;
        u8 target_flags, ttl, flags;
-       u32 orig_sn, target_sn, lifetime, target_metric;
+       u32 orig_sn, target_sn, lifetime, target_metric = 0;
        bool reply = false;
        bool forward = true;
        bool root_is_gate;