mmc: dw_mmc: NULL dereference in error message
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 22 Oct 2015 19:53:46 +0000 (22:53 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 29 Oct 2015 10:00:03 +0000 (11:00 +0100)
The "host->dms->ch" pointer is NULL here so we can't use it to print the
error message.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/dw_mmc.c

index 63eefea9645e37247e0f9d7f71a938e9d249ed20..57a9577bc35c2ba8e030e7251139ac324d7efaef 100644 (file)
@@ -752,9 +752,7 @@ static int dw_mci_edmac_init(struct dw_mci *host)
 
        host->dms->ch = dma_request_slave_channel(host->dev, "rx-tx");
        if (!host->dms->ch) {
-               dev_err(host->dev,
-                       "Failed to get external DMA channel %d\n",
-                       host->dms->ch->chan_id);
+               dev_err(host->dev, "Failed to get external DMA channel.\n");
                kfree(host->dms);
                host->dms = NULL;
                return -ENXIO;