power: Avoids bogus error messages for the suspend aborts.
authorRuchi Kandoi <kandoiruchi@google.com>
Wed, 15 Oct 2014 00:43:21 +0000 (17:43 -0700)
committerJohn Stultz <john.stultz@linaro.org>
Tue, 16 Feb 2016 21:53:38 +0000 (13:53 -0800)
Avoids printing bogus error message "tasks refusing to freeze", in cases
where pending wakeup source caused the suspend abort.

Signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
Change-Id: I913ad290f501b31cd536d039834c8d24c6f16928

kernel/power/process.c

index 564f786df4701a82a8de89821304cfb0f0b7a337..fa50018418dcd243093d335e90bec770e96bbc21 100644 (file)
@@ -83,15 +83,17 @@ static int try_to_freeze_tasks(bool user_only)
        do_div(elapsed_msecs64, NSEC_PER_MSEC);
        elapsed_msecs = elapsed_msecs64;
 
-       if (todo) {
+       if (wakeup) {
                pr_cont("\n");
-               pr_err("Freezing of tasks %s after %d.%03d seconds "
-                      "(%d tasks refusing to freeze, wq_busy=%d):\n",
-                      wakeup ? "aborted" : "failed",
+               pr_err("Freezing of tasks aborted after %d.%03d seconds",
+                      elapsed_msecs / 1000, elapsed_msecs % 1000);
+       } else if (todo) {
+               pr_cont("\n");
+               pr_err("Freezing of tasks failed after %d.%03d seconds"
+                      " (%d tasks refusing to freeze, wq_busy=%d):\n",
                       elapsed_msecs / 1000, elapsed_msecs % 1000,
                       todo - wq_busy, wq_busy);
 
-               if (!wakeup) {
                        read_lock(&tasklist_lock);
                        for_each_process_thread(g, p) {
                                if (p != current && !freezer_should_skip(p)
@@ -99,7 +101,6 @@ static int try_to_freeze_tasks(bool user_only)
                                        sched_show_task(p);
                        }
                        read_unlock(&tasklist_lock);
-               }
        } else {
                pr_cont("(elapsed %d.%03d seconds) ", elapsed_msecs / 1000,
                        elapsed_msecs % 1000);