arm64: perf: fix group validation when using enable_on_exec
authorWill Deacon <will.deacon@arm.com>
Tue, 20 Aug 2013 10:47:41 +0000 (11:47 +0100)
committerMark Brown <broonie@linaro.org>
Wed, 14 May 2014 11:15:48 +0000 (12:15 +0100)
commit 8455e6ec70f33b0e8c3ffd47067e00481f09f454 upstream.

This is a port of cb2d8b342aa0 ("ARM: 7698/1: perf: fix group validation
when using enable_on_exec") to arm64, which fixes the event validation
checking so that events in the OFF state are still considered when
enable_on_exec is true.

Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 1f96d83b38937294584ede9473c2b2961528f287)
Signed-off-by: Mark Brown <broonie@linaro.org>
arch/arm64/kernel/perf_event.c

index 12e6ccb88691c65e6a20d761275babb1af369182..2a1e9163d67a7061e8a63362e9eb6174e35eca26 100644 (file)
@@ -325,7 +325,10 @@ validate_event(struct pmu_hw_events *hw_events,
        if (is_software_event(event))
                return 1;
 
-       if (event->pmu != leader_pmu || event->state <= PERF_EVENT_STATE_OFF)
+       if (event->pmu != leader_pmu || event->state < PERF_EVENT_STATE_OFF)
+               return 1;
+
+       if (event->state == PERF_EVENT_STATE_OFF && !event->attr.enable_on_exec)
                return 1;
 
        return armpmu->get_event_idx(hw_events, &fake_event) >= 0;