Merge git://git.infradead.org/users/eparis/audit
authorLinus Torvalds <torvalds@linux-foundation.org>
Sat, 12 Apr 2014 19:38:53 +0000 (12:38 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 12 Apr 2014 19:38:53 +0000 (12:38 -0700)
Pull audit updates from Eric Paris.

* git://git.infradead.org/users/eparis/audit: (28 commits)
  AUDIT: make audit_is_compat depend on CONFIG_AUDIT_COMPAT_GENERIC
  audit: renumber AUDIT_FEATURE_CHANGE into the 1300 range
  audit: do not cast audit_rule_data pointers pointlesly
  AUDIT: Allow login in non-init namespaces
  audit: define audit_is_compat in kernel internal header
  kernel: Use RCU_INIT_POINTER(x, NULL) in audit.c
  sched: declare pid_alive as inline
  audit: use uapi/linux/audit.h for AUDIT_ARCH declarations
  syscall_get_arch: remove useless function arguments
  audit: remove stray newline from audit_log_execve_info() audit_panic() call
  audit: remove stray newlines from audit_log_lost messages
  audit: include subject in login records
  audit: remove superfluous new- prefix in AUDIT_LOGIN messages
  audit: allow user processes to log from another PID namespace
  audit: anchor all pid references in the initial pid namespace
  audit: convert PPIDs to the inital PID namespace.
  pid: get pid_t ppid of task in init_pid_ns
  audit: rename the misleading audit_get_context() to audit_take_context()
  audit: Add generic compat syscall support
  audit: Add CONFIG_HAVE_ARCH_AUDITSYSCALL
  ...

23 files changed:
1  2 
arch/alpha/Kconfig
arch/arm/Kconfig
arch/ia64/Kconfig
arch/mips/include/asm/syscall.h
arch/mips/kernel/ptrace.c
arch/parisc/Kconfig
arch/powerpc/Kconfig
arch/s390/Kconfig
arch/sh/Kconfig
arch/sparc/Kconfig
arch/x86/Kconfig
fs/proc/base.c
include/linux/mm.h
include/linux/sched.h
init/Kconfig
kernel/audit.c
kernel/auditfilter.c
kernel/auditsc.c
kernel/seccomp.c
lib/Kconfig
lib/Makefile
mm/util.c
security/integrity/integrity_audit.c

Simple merge
Simple merge
Simple merge
index 6c488c85d79141b385d1d6c0c394aa4400518fbf,fc556d8052c9759d63e60aa85e8c7b0bd7187ee4..c6e9cd2bca8dbf7de5512c9be8de0f2b92db7bd4
@@@ -13,8 -13,7 +13,8 @@@
  #ifndef __ASM_MIPS_SYSCALL_H
  #define __ASM_MIPS_SYSCALL_H
  
- #include <linux/audit.h>
 +#include <linux/compiler.h>
+ #include <uapi/linux/audit.h>
  #include <linux/elf-em.h>
  #include <linux/kernel.h>
  #include <linux/sched.h>
@@@ -132,8 -105,7 +131,8 @@@ static inline int syscall_get_arch(void
  {
        int arch = EM_MIPS;
  #ifdef CONFIG_64BIT
-       if (!test_tsk_thread_flag(task, TIF_32BIT_REGS))
 -      arch |=  __AUDIT_ARCH_64BIT;
++      if (!test_thread_flag(TIF_32BIT_REGS))
 +              arch |= __AUDIT_ARCH_64BIT;
  #endif
  #if defined(__LITTLE_ENDIAN)
        arch |=  __AUDIT_ARCH_LE;
index 7271e5a8308165c901a5c4e248f3b7c02225239f,65ba622baf3eae2519a7ef4f3e6c6d74575fca9a..71f85f4270341252d046db277aecfd5d3d0ae13d
@@@ -649,11 -671,10 +649,11 @@@ asmlinkage long syscall_trace_enter(str
        if (unlikely(test_thread_flag(TIF_SYSCALL_TRACEPOINT)))
                trace_sys_enter(regs, regs->regs[2]);
  
-       audit_syscall_entry(syscall_get_arch(current, regs),
+       audit_syscall_entry(syscall_get_arch(),
 -                          regs->regs[2],
 +                          syscall,
                            regs->regs[4], regs->regs[5],
                            regs->regs[6], regs->regs[7]);
 +      return syscall;
  }
  
  /*
Simple merge
index 6c03a94991ad970a754713c1ecfc638661f04dc7,96627d67bd67ff02d316392a6cca39ffa48b32e3..e0998997943bf789cddb11967781b595850574bc
@@@ -143,7 -139,7 +143,8 @@@ config PP
        select OLD_SIGACTION if PPC32
        select HAVE_DEBUG_STACKOVERFLOW
        select HAVE_IRQ_EXIT_ON_IRQ_STACK
 +      select ARCH_USE_CMPXCHG_LOCKREF if PPC64
+       select HAVE_ARCH_AUDITSYSCALL
  
  config GENERIC_CSUM
        def_bool CPU_LITTLE_ENDIAN
Simple merge
diff --cc arch/sh/Kconfig
Simple merge
Simple merge
index 5b8ec0f53b57ec77848100a42a1e0c2838c940a5,56f47caf6fa085bf8f06723c127b1f4614a0f6d2..25d2c6f7325e8d64133100d651661af713f6563a
@@@ -127,8 -125,7 +127,9 @@@ config X8
        select RTC_LIB
        select HAVE_DEBUG_STACKOVERFLOW
        select HAVE_IRQ_EXIT_ON_IRQ_STACK if X86_64
 +      select HAVE_CC_STACKPROTECTOR
 +      select GENERIC_CPU_AUTOPROBE
+       select HAVE_ARCH_AUDITSYSCALL
  
  config INSTRUCTION_DECODER
        def_bool y
diff --cc fs/proc/base.c
Simple merge
Simple merge
Simple merge
diff --cc init/Kconfig
Simple merge
diff --cc kernel/audit.c
index 95a20f3f52f1c9f35b7d6aa2cb0a8b7c05fdbc69,873b965fdc58e82e52f93522b4525183c84e9365..7c2893602d0651f767e1a177dbfd6214e66e8d9c
@@@ -618,8 -618,7 +618,7 @@@ static int audit_netlink_ok(struct sk_b
         * userspace will reject all logins.  This should be removed when we
         * support non init namespaces!!
         */
-       if ((current_user_ns() != &init_user_ns) ||
-           (task_active_pid_ns(current) != &init_pid_ns))
 -      if ((current_user_ns() != &init_user_ns))
++      if (current_user_ns() != &init_user_ns)
                return -ECONNREFUSED;
  
        switch (msg_type) {
Simple merge
index 7aef2f4b6c644963fb33c320c212eb856df8c69a,254ce2063d1d547189ed3c1796ad1a0c809a8729..f251a5e8d17ad2285569466e442ae461fe17948e
@@@ -1719,9 -1789,9 +1789,9 @@@ void audit_putname(struct filename *nam
        struct audit_context *context = current->audit_context;
  
        BUG_ON(!context);
 -      if (!context->in_syscall) {
 +      if (!name->aname || !context->in_syscall) {
  #if AUDIT_DEBUG == 2
-               printk(KERN_ERR "%s:%d(:%d): final_putname(%p)\n",
+               pr_err("%s:%d(:%d): final_putname(%p)\n",
                       __FILE__, __LINE__, context->serial, name);
                if (context->name_count) {
                        struct audit_names *n;
index fd609bd9d6dd7b5c40ec637aa288ae55f88d4505,eda2da3df8223b0ba3aa981453908be505fe1825..d8d046c0726a4fede10cdca96910fd5125f5d52e
@@@ -65,23 -74,41 +65,23 @@@ struct seccomp_filter 
   * Endianness is explicitly ignored and left for BPF program authors to manage
   * as per the specific architecture.
   */
 -static inline u32 get_u32(u64 data, int index)
 +static void populate_seccomp_data(struct seccomp_data *sd)
  {
 -      return ((u32 *)&data)[index];
 -}
 +      struct task_struct *task = current;
 +      struct pt_regs *regs = task_pt_regs(task);
  
 -/* Helper for bpf_load below. */
 -#define BPF_DATA(_name) offsetof(struct seccomp_data, _name)
 -/**
 - * bpf_load: checks and returns a pointer to the requested offset
 - * @off: offset into struct seccomp_data to load from
 - *
 - * Returns the requested 32-bits of data.
 - * seccomp_check_filter() should assure that @off is 32-bit aligned
 - * and not out of bounds.  Failure to do so is a BUG.
 - */
 -u32 seccomp_bpf_load(int off)
 -{
 -      struct pt_regs *regs = task_pt_regs(current);
 -      if (off == BPF_DATA(nr))
 -              return syscall_get_nr(current, regs);
 -      if (off == BPF_DATA(arch))
 -              return syscall_get_arch();
 -      if (off >= BPF_DATA(args[0]) && off < BPF_DATA(args[6])) {
 -              unsigned long value;
 -              int arg = (off - BPF_DATA(args[0])) / sizeof(u64);
 -              int index = !!(off % sizeof(u64));
 -              syscall_get_arguments(current, regs, arg, 1, &value);
 -              return get_u32(value, index);
 -      }
 -      if (off == BPF_DATA(instruction_pointer))
 -              return get_u32(KSTK_EIP(current), 0);
 -      if (off == BPF_DATA(instruction_pointer) + sizeof(u32))
 -              return get_u32(KSTK_EIP(current), 1);
 -      /* seccomp_check_filter should make this impossible. */
 -      BUG();
 +      sd->nr = syscall_get_nr(task, regs);
-       sd->arch = syscall_get_arch(task, regs);
++      sd->arch = syscall_get_arch();
 +
 +      /* Unroll syscall_get_args to help gcc on arm. */
 +      syscall_get_arguments(task, regs, 0, 1, (unsigned long *) &sd->args[0]);
 +      syscall_get_arguments(task, regs, 1, 1, (unsigned long *) &sd->args[1]);
 +      syscall_get_arguments(task, regs, 2, 1, (unsigned long *) &sd->args[2]);
 +      syscall_get_arguments(task, regs, 3, 1, (unsigned long *) &sd->args[3]);
 +      syscall_get_arguments(task, regs, 4, 1, (unsigned long *) &sd->args[4]);
 +      syscall_get_arguments(task, regs, 5, 1, (unsigned long *) &sd->args[5]);
 +
 +      sd->instruction_pointer = KSTK_EIP(task);
  }
  
  /**
diff --cc lib/Kconfig
Simple merge
diff --cc lib/Makefile
Simple merge
diff --cc mm/util.c
index d7813e6d4cc7c042c44a01692f0993a2b6bad04a,43b44199c5e32a6d079f9ae523fade8666d37ab9..f380af7ea7797e287b222cd57b665fad02b6132e
+++ b/mm/util.c
@@@ -434,18 -409,58 +434,66 @@@ int overcommit_kbytes_handler(struct ct
   */
  unsigned long vm_commit_limit(void)
  {
 -      return ((totalram_pages - hugetlb_total_pages())
 -              * sysctl_overcommit_ratio / 100) + total_swap_pages;
 +      unsigned long allowed;
 +
 +      if (sysctl_overcommit_kbytes)
 +              allowed = sysctl_overcommit_kbytes >> (PAGE_SHIFT - 10);
 +      else
 +              allowed = ((totalram_pages - hugetlb_total_pages())
 +                         * sysctl_overcommit_ratio / 100);
 +      allowed += total_swap_pages;
 +
 +      return allowed;
  }
  
+ /**
+  * get_cmdline() - copy the cmdline value to a buffer.
+  * @task:     the task whose cmdline value to copy.
+  * @buffer:   the buffer to copy to.
+  * @buflen:   the length of the buffer. Larger cmdline values are truncated
+  *            to this length.
+  * Returns the size of the cmdline field copied. Note that the copy does
+  * not guarantee an ending NULL byte.
+  */
+ int get_cmdline(struct task_struct *task, char *buffer, int buflen)
+ {
+       int res = 0;
+       unsigned int len;
+       struct mm_struct *mm = get_task_mm(task);
+       if (!mm)
+               goto out;
+       if (!mm->arg_end)
+               goto out_mm;    /* Shh! No looking before we're done */
+       len = mm->arg_end - mm->arg_start;
+       if (len > buflen)
+               len = buflen;
+       res = access_process_vm(task, mm->arg_start, buffer, len, 0);
+       /*
+        * If the nul at the end of args has been overwritten, then
+        * assume application is using setproctitle(3).
+        */
+       if (res > 0 && buffer[res-1] != '\0' && len < buflen) {
+               len = strnlen(buffer, res);
+               if (len < res) {
+                       res = len;
+               } else {
+                       len = mm->env_end - mm->env_start;
+                       if (len > buflen - res)
+                               len = buflen - res;
+                       res += access_process_vm(task, mm->env_start,
+                                                buffer+res, len, 0);
+                       res = strnlen(buffer, res);
+               }
+       }
+ out_mm:
+       mmput(mm);
+ out:
+       return res;
+ }
  
  /* Tracepoints definitions. */
  EXPORT_TRACEPOINT_SYMBOL(kmalloc);
Simple merge