metag: avoid unnecessary builtin dtb rebuilds
authorJames Hogan <james.hogan@imgtec.com>
Wed, 17 Apr 2013 09:59:22 +0000 (10:59 +0100)
committerJames Hogan <james.hogan@imgtec.com>
Mon, 22 Apr 2013 10:23:20 +0000 (11:23 +0100)
The builtin .dtb.S intermediate file needs to be marked with .SECONDARY
so that it isn't automatically deleted (which causes it to be
regenerated on every build). Also add *.dtb.S to clean-files so it gets
cleaned up by make clean.

Similarly, if the specified builtin dtb isn't already in dtb-y (e.g.
imported into the tree and specified in CONFIG_METAG_BUILTIN_DTB_NAME)
it too will be treated as an intermediate and deleted automatically
(again causing it to be regenerated on every build), so add it to dtb-y
so it gets added to targets and the dtbs target.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
arch/metag/boot/dts/Makefile

index e0b5afd8bde843bf2a67cbb1327bab467913723a..dbd95217733abaef14feac1cca54c3af3cf5969a 100644 (file)
@@ -4,13 +4,17 @@ dtb-y += skeleton.dtb
 builtindtb-y                           := skeleton
 
 ifneq ($(CONFIG_METAG_BUILTIN_DTB_NAME),"")
-       builtindtb-y                    := $(CONFIG_METAG_BUILTIN_DTB_NAME)
+       builtindtb-y                    := $(patsubst "%",%,$(CONFIG_METAG_BUILTIN_DTB_NAME))
 endif
-obj-$(CONFIG_METAG_BUILTIN_DTB)        += $(patsubst "%",%,$(builtindtb-y)).dtb.o
+
+dtb-$(CONFIG_METAG_BUILTIN_DTB)        += $(builtindtb-y).dtb
+obj-$(CONFIG_METAG_BUILTIN_DTB)        += $(builtindtb-y).dtb.o
 
 targets        += dtbs
 targets        += $(dtb-y)
 
+.SECONDARY: $(obj)/$(builtindtb-y).dtb.S
+
 dtbs: $(addprefix $(obj)/, $(dtb-y))
 
-clean-files += *.dtb
+clean-files += *.dtb *.dtb.S