oota-llvm.git
10 years agoRemove PBQP-cost dimension sanity assertion in PBQP::Graph::addConstructedEdge.
Lang Hames [Wed, 26 Mar 2014 19:22:51 +0000 (19:22 +0000)]
Remove PBQP-cost dimension sanity assertion in PBQP::Graph::addConstructedEdge.
We're already effectively checking sanity for that in PBQP::Graph::addEdge.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204844 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Use v2f64 <-> v2i64 VSX conversion instructions
Hal Finkel [Wed, 26 Mar 2014 19:13:54 +0000 (19:13 +0000)]
[PowerPC] Use v2f64 <-> v2i64 VSX conversion instructions

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204843 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoChange the PBQP graph adjacency list structure from std::set to std::vector.
Lang Hames [Wed, 26 Mar 2014 18:58:00 +0000 (18:58 +0000)]
Change the PBQP graph adjacency list structure from std::set to std::vector.

The edge data structure (EdgeEntry) now holds the indices of its entries in the
adjacency lists of the nodes it connects. This trades a little ugliness for
faster insertion/removal, which is now O(1) with a cheap constant factor. All
of this is implementation detail within the PBQP graph, the external API remains
unchanged.

Individual register allocations are likely to change, since the adjacency lists
will now be ordered differently (or rather, will now be unordered). This
shouldn't affect the average quality of allocations however.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204841 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Add a testcase for sext_in_reg I missed.
Matt Arsenault [Wed, 26 Mar 2014 18:31:06 +0000 (18:31 +0000)]
R600: Add a testcase for sext_in_reg I missed.

This sext_inreg i32 in i64 case was already handled, but not enabled.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204840 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Remove some dead VSX v4f32 store patterns
Hal Finkel [Wed, 26 Mar 2014 18:26:36 +0000 (18:26 +0000)]
[PowerPC] Remove some dead VSX v4f32 store patterns

These patterns are dead (because v4f32 stores are currently promoted to v4i32
and stored using Altivec instructions), and also are likely not correct
(because they'd store the vector elements in the opposite order from that
assumed by the rest of the Altivec code).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204839 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Use VSX vector load/stores for v2[fi]64
Hal Finkel [Wed, 26 Mar 2014 18:26:30 +0000 (18:26 +0000)]
[PowerPC] Use VSX vector load/stores for v2[fi]64

These instructions have access to the complete VSX register file. In addition,
they "swap" the order of the elements so that element 0 (the scalar part) comes
first in memory and element 1 follows at a higher address.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204838 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[MCJIT] Check if there have been errors during RuntimeDyld execution.
Juergen Ributzka [Wed, 26 Mar 2014 18:19:27 +0000 (18:19 +0000)]
[MCJIT] Check if there have been errors during RuntimeDyld execution.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204837 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoEnable range-for iteration over call/invoke arguments.
Eli Bendersky [Wed, 26 Mar 2014 18:18:02 +0000 (18:18 +0000)]
Enable range-for iteration over call/invoke arguments.

Similar to r204835

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204836 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd args() iteartor adapter to Function, for range-for loops.
Eli Bendersky [Wed, 26 Mar 2014 18:04:27 +0000 (18:04 +0000)]
Add args() iteartor adapter to Function, for range-for loops.

This patch is in similar vein to what done earlier to Module::globals/aliases
etc. It allows to iterate over function arguments like this:

  for (Argument Arg : F.args()) {
    ...
  }

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204835 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix for incorrect address sinking in the presence of potential overflows.
Jim Grosbach [Wed, 26 Mar 2014 17:27:01 +0000 (17:27 +0000)]
Fix for incorrect address sinking in the presence of potential overflows.

In some cases it is possible for CGP to attempt to reuse a base address from
another basic block. In those cases we have to be sure that all the address
math was either done at the same bit width, or that none of it overflowed
before it was extended.

Patch by Louis Gerbarg <lgg@apple.com>

rdar://16307442

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204833 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRevert "X86 memcpy lowering: use "rep movs" even when esi is used as base pointer...
Hans Wennborg [Wed, 26 Mar 2014 16:30:54 +0000 (16:30 +0000)]
Revert "X86 memcpy lowering: use "rep movs" even when esi is used as base pointer" (r204174)

>  For functions where esi is used as base pointer, we would previously fall ba
>  from lowering memcpy with "rep movs" because that clobbers esi.
>
>  With this patch, we just store esi in another physical register, and restore
>  it afterwards. This adds a little bit of register preassure, but the more
>  efficient memcpy should be worth it.
>
>  Differential Revision: http://llvm-reviews.chandlerc.com/D2968

This didn't work. I was ending up with code like this:

  lea     edi,[esi+38h]
  mov     ecx,0Fh
  mov     edx,esi
  mov     esi,ebx
  rep movs dword ptr es:[edi],dword ptr [esi]
  lea     ecx,[esi+74h] <-- Ooops, we're now using esi before restoring it from edx.
  add     ebx,3Ch
  mov     esi,edx

I guess if we want to do this we need stronger glue or something, or doing the expansion
much later.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204829 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Add v2i64 as a legal VSX type
Hal Finkel [Wed, 26 Mar 2014 16:12:58 +0000 (16:12 +0000)]
[PowerPC] Add v2i64 as a legal VSX type

v2i64 needs to be a legal VSX type because it is the SetCC result type from
v2f64 comparisons. We need to expand all non-arithmetic v2i64 operations.

This fixes the lowering for v2f64 VSELECT.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204828 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Use TwoOperandAliasConstraint for ArithLogicR instructions.
Matheus Almeida [Wed, 26 Mar 2014 16:09:43 +0000 (16:09 +0000)]
[mips] Use TwoOperandAliasConstraint for ArithLogicR instructions.

This enables TableGen to generate an additional two operand matcher
for our ArithLogicR class of instructions (constituted by 3 register operands).
E.g.: and $1, $2 <=> and $1, $1, $2

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204826 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Add support to the '.dword' directive.
Matheus Almeida [Wed, 26 Mar 2014 15:44:18 +0000 (15:44 +0000)]
[mips] Add support to the '.dword' directive.

The '.dword' directive accepts a list of expressions and emits
them in 8-byte chunks in successive locations.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204822 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoClarify that select is only non-branching on the IR-level, it often ends
Joerg Sonnenberger [Wed, 26 Mar 2014 15:30:21 +0000 (15:30 +0000)]
Clarify that select is only non-branching on the IR-level, it often ends
up as jump table or other forms of branches on the machine level.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204819 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Rename function in MipsAsmParser.
Matheus Almeida [Wed, 26 Mar 2014 15:24:36 +0000 (15:24 +0000)]
[mips] Rename function in MipsAsmParser.

parseDirectiveWord is a generic function that parses an expression which
means there's no need for it to have such an specific name. Renaming it to
parseDataDirective so that it can also be used to handle .dword directives[1].

[1]To be added in a follow up commit.

No functional changes.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204818 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Add support to '.set mips64'.
Matheus Almeida [Wed, 26 Mar 2014 15:14:32 +0000 (15:14 +0000)]
[mips] Add support to '.set mips64'.

The '.set mips64' directive enables the feature Mips:FeatureMips64
from assembly. Note that it doesn't modify the ELF header as opposed
to the use of -mips64 from the command-line. The reason for this
is that we want to be as compatible as possible with existing assemblers
like GAS.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204817 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64_BE Elf support for MC-JIT runtime dynamic linker
Christian Pirker [Wed, 26 Mar 2014 14:57:32 +0000 (14:57 +0000)]
AArch64_BE Elf support for MC-JIT runtime dynamic linker

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204816 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Add support to '.set mips64r2'.
Matheus Almeida [Wed, 26 Mar 2014 14:52:22 +0000 (14:52 +0000)]
[mips] Add support to '.set mips64r2'.

The '.set mips64r2' directive enables the feature Mips:FeatureMips64r2
from assembly. Note that it doesn't modify the ELF header as opposed
to the use of -mips64r2 from the command-line. The reason for this
is that we want to be as compatible as possible with existing assemblers
like GAS.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204815 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64_BE function argument passing for ARM ABI
Christian Pirker [Wed, 26 Mar 2014 14:51:22 +0000 (14:51 +0000)]
AArch64_BE function argument passing for ARM ABI

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204814 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoARM: add intrinsics for the v8 ldaex/stlex
Tim Northover [Wed, 26 Mar 2014 14:39:31 +0000 (14:39 +0000)]
ARM: add intrinsics for the v8 ldaex/stlex

We've already got versions without the barriers, so this just adds IR-level
support for generating the new v8 ones.

rdar://problem/16227836

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204813 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoClarify llvm.clear_cache description.
Joerg Sonnenberger [Wed, 26 Mar 2014 14:35:21 +0000 (14:35 +0000)]
Clarify llvm.clear_cache description.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204812 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Hoist common functionality into a new function.
Matheus Almeida [Wed, 26 Mar 2014 14:26:27 +0000 (14:26 +0000)]
[mips] Hoist common functionality into a new function.

Given that we support multiple directives that enable a particular feature
(e.g. '.set mips16'), it's best to hoist that code into a new function
so that we don't repeat the same pattern w.r.t parsing and handling error cases.

No functional changes.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204811 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoChange @llvm.clear_cache default to call rt-lib
Renato Golin [Wed, 26 Mar 2014 14:01:32 +0000 (14:01 +0000)]
Change @llvm.clear_cache default to call rt-lib

After some discussion on IRC, emitting a call to the library function seems
like a better default, since it will move from a compiler internal error to
a linker error, that the user can work around until LLVM is fixed.

I'm also adding a note on the responsibility of the user to confirm that
the cache was cleared on platforms where nothing is done.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204806 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] The decision to use MO_GOT_PAGE and MO_GOT_OFST depends on the ABI being N32...
Daniel Sanders [Wed, 26 Mar 2014 13:59:42 +0000 (13:59 +0000)]
[mips] The decision to use MO_GOT_PAGE and MO_GOT_OFST depends on the ABI being N32 or N64 not the arch being MIPS64

Summary: No functional change (in supported use cases)

Reviewers: matheusalmeida

Reviewed By: matheusalmeida

Differential Revision: http://llvm-reviews.chandlerc.com/D3177

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204805 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix AVX512 Gather and Scatter execution domains.
Cameron McInally [Wed, 26 Mar 2014 13:50:50 +0000 (13:50 +0000)]
Fix AVX512 Gather and Scatter execution domains.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204804 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Add support for '.option pic2'.
Matheus Almeida [Wed, 26 Mar 2014 13:40:29 +0000 (13:40 +0000)]
[mips] Add support for '.option pic2'.

The directive '.option pic2' enables PIC from assembly source.
At the moment none of the macros/directives check the PIC bit
but that's going to be fixed relatively soon. For example, the
expansion of macros like 'la' depend on the relocation model.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204803 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd @llvm.clear_cache builtin
Renato Golin [Wed, 26 Mar 2014 12:52:28 +0000 (12:52 +0000)]
Add @llvm.clear_cache builtin

Implementing the LLVM part of the call to __builtin___clear_cache
which translates into an intrinsic @llvm.clear_cache and is lowered
by each target, either to a call to __clear_cache or nothing at all
incase the caches are unified.

Updating LangRef and adding some tests for the implemented architectures.
Other archs will have to implement the method in case this builtin
has to be compiled for it, since the default behaviour is to bail
unimplemented.

A Clang patch is required for the builtin to be lowered into the
llvm intrinsic. This will be done next.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204802 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Lower VSELECT using xxsel when VSX is available
Hal Finkel [Wed, 26 Mar 2014 12:49:28 +0000 (12:49 +0000)]
[PowerPC] Lower VSELECT using xxsel when VSX is available

With VSX there is a real vector select instruction, and so we should use it.
Note that VSELECT will still scalarize for v2f64 because the corresponding
SetCC result type (v2i64) is not currently a legal type.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204801 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Add tests for t0-t3 for N32/N64
Daniel Sanders [Wed, 26 Mar 2014 11:46:34 +0000 (11:46 +0000)]
[mips] Add tests for t0-t3 for N32/N64

These are aliases of t4-t7 and are provided for compatibility with both the
original ABI documentation (using t4-t7) and GNU As (using t0-t3)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204797 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] The register names depend on the ABI being N32/N64 rather than the arch being...
Daniel Sanders [Wed, 26 Mar 2014 11:39:07 +0000 (11:39 +0000)]
[mips] The register names depend on the ABI being N32/N64 rather than the arch being mips64

Summary: Added test cases for O32 and N32 on MIPS64.

Reviewers: matheusalmeida

Reviewed By: matheusalmeida

Differential Revision: http://llvm-reviews.chandlerc.com/D3175

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204796 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFollow-up to r204790: don't try to emit line tables if there are no functions with...
Timur Iskhodzhanov [Wed, 26 Mar 2014 11:24:36 +0000 (11:24 +0000)]
Follow-up to r204790: don't try to emit line tables if there are no functions with DI in the TU

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204795 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] $s8 is an alias for $fp in all ABI's, not just N32/N64.
Daniel Sanders [Wed, 26 Mar 2014 11:05:24 +0000 (11:05 +0000)]
[mips] $s8 is an alias for $fp in all ABI's, not just N32/N64.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204793 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Move the CHECK lines in mips*-register-names.s to make it more obvious which...
Daniel Sanders [Wed, 26 Mar 2014 10:54:30 +0000 (10:54 +0000)]
[mips] Move the CHECK lines in mips*-register-names.s to make it more obvious which CHECK matches with which insn

This reveals a small mistake in mips-register-names.s ($sp is tested twice and
$s8 is not tested) which will be fixed in a follow-up commit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204792 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd tests for r204790
Timur Iskhodzhanov [Wed, 26 Mar 2014 09:51:45 +0000 (09:51 +0000)]
Add tests for r204790

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204791 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix PR19239 - Add support for generating debug info for functions without lexical...
Timur Iskhodzhanov [Wed, 26 Mar 2014 09:50:36 +0000 (09:50 +0000)]
Fix PR19239 - Add support for generating debug info for functions without lexical scopes and/or debug info at all

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204790 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse -LABEL checks in the COFF debug info tests
Timur Iskhodzhanov [Wed, 26 Mar 2014 08:45:02 +0000 (08:45 +0000)]
Use -LABEL checks in the COFF debug info tests

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204788 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRevert "Prevent alias from pointing to weak aliases."
Rafael Espindola [Wed, 26 Mar 2014 06:14:40 +0000 (06:14 +0000)]
Revert "Prevent alias from pointing to weak aliases."

This reverts commit r204781.

I will follow up to with msan folks to see what is what they
were trying to do with aliases to weak aliases.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204784 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Generate logical vector VSX instructions
Hal Finkel [Wed, 26 Mar 2014 04:55:40 +0000 (04:55 +0000)]
[PowerPC] Generate logical vector VSX instructions

These instructions are essentially the same as their Altivec counterparts, but
have access to the larger VSX register file.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204782 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoPrevent alias from pointing to weak aliases.
Rafael Espindola [Wed, 26 Mar 2014 04:48:47 +0000 (04:48 +0000)]
Prevent alias from pointing to weak aliases.

Aliases are just another name for a position in a file. As such, the
regular symbol resolutions are not applied. For example, given

define void @my_func() {
  ret void
}
@my_alias = alias weak void ()* @my_func
@my_alias2 = alias void ()* @my_alias

We produce without this patch:

        .weak   my_alias
my_alias = my_func
        .globl  my_alias2
my_alias2 = my_alias

That is, in the resulting ELF file my_alias, my_func and my_alias are
just 3 names pointing to offset 0 of .text. That is *not* the
semantics of IR linking. For example, linking in a

@my_alias = alias void ()* @other_func

would require the strong my_alias to override the weak one and
my_alias2 would end up pointing to other_func.

There is no way to represent that with aliases being just another
name, so the best solution seems to be to just disallow it, converting
a miscompile into an error.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204781 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Add fission-related sections to COFF
David Blaikie [Wed, 26 Mar 2014 03:05:10 +0000 (03:05 +0000)]
DebugInfo: Add fission-related sections to COFF

Allows this test to pass on COFF platforms so we don't need to restrict
this test to a single target anymore.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204780 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoCorrectly detect if a symbol uses a reserved section index or not.
Rafael Espindola [Wed, 26 Mar 2014 00:16:43 +0000 (00:16 +0000)]
Correctly detect if a symbol uses a reserved section index or not.

The logic was incorrect for variables, causing them to end up in the wrong
section if the section had an index >= 0xff00.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204771 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[X86] Add broadcast instructions to the table used by ExeDepsFix pass.
Quentin Colombet [Wed, 26 Mar 2014 00:10:22 +0000 (00:10 +0000)]
[X86] Add broadcast instructions to the table used by ExeDepsFix pass.

Adds the different broadcast instructions to the ReplaceableInstrsAVX2 table.
That way the ExeDepsFix pass can take better decisions when AVX2 broadcasts are
across domain (int <-> float).

In particular, prior to this patch we were generating:
  vpbroadcastd  LCPI1_0(%rip), %ymm2
  vpand %ymm2, %ymm0, %ymm0
  vmaxps  %ymm1, %ymm0, %ymm0 ## <- domain change penalty

Now, we generate the following nice sequence where everything is in the float
domain:
  vbroadcastss  LCPI1_0(%rip), %ymm2
  vandps  %ymm2, %ymm0, %ymm0
  vmaxps  %ymm1, %ymm0, %ymm0

<rdar://problem/16354675>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204770 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoCreate .symtab_shndxr only when needed.
Rafael Espindola [Tue, 25 Mar 2014 23:44:25 +0000 (23:44 +0000)]
Create .symtab_shndxr only when needed.

We need .symtab_shndxr if and only if a symbol references a section with an
index >= 0xff00.

The old code was trying to figure out if the section was needed ahead of time,
making it a fairly dependent on the code actually writing the table. It was
also somewhat conservative and would create the section in cases where it was
not needed.

If I remember correctly, the old structure was there so that the sections were
created in the same order gas creates them. That was valuable when MC's support
for ELF was new and we tested with elf-dump.py.

This patch refactors the symbol table creation to another class and makes it
obvious that .symtab_shndxr is really only created when we are about to output
a reference to a section index >= 0xff00.

While here, also improve the tests to use macros. One file is one section
short of needing .symtab_shndxr, the second one has just the right number.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204769 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Select between VSX A-type and M-type FMA instructions just before RA
Hal Finkel [Tue, 25 Mar 2014 23:29:21 +0000 (23:29 +0000)]
[PowerPC] Select between VSX A-type and M-type FMA instructions just before RA

The VSX instruction set has two types of FMA instructions: A-type (where the
addend is taken from the output register) and M-type (where one of the product
operands is taken from the output register). This adds a small pass that runs
just after MI scheduling (and, thus, just before register allocation) that
mutates A-type instructions (that are created during isel) into M-type
instructions when:

 1. This will eliminate an otherwise-necessary copy of the addend

 2. One of the product operands is killed by the instruction

The "right" moment to make this decision is in between scheduling and register
allocation, because only there do we know whether or not one of the product
operands is killed by any particular instruction. Unfortunately, this also
makes the implementation somewhat complicated, because the MIs are not in SSA
form and we need to preserve the LiveIntervals analysis.

As a simple example, if we have:

%vreg5<def> = COPY %vreg9; VSLRC:%vreg5,%vreg9
%vreg5<def,tied1> = XSMADDADP %vreg5<tied0>, %vreg17, %vreg16,
                        %RM<imp-use>; VSLRC:%vreg5,%vreg17,%vreg16
  ...
  %vreg9<def,tied1> = XSMADDADP %vreg9<tied0>, %vreg17, %vreg19,
                        %RM<imp-use>; VSLRC:%vreg9,%vreg17,%vreg19
  ...

We can eliminate the copy by changing from the A-type to the
M-type instruction. This means:

  %vreg5<def,tied1> = XSMADDADP %vreg5<tied0>, %vreg17, %vreg16,
                        %RM<imp-use>; VSLRC:%vreg5,%vreg17,%vreg16

is replaced by:

  %vreg16<def,tied1> = XSMADDMDP %vreg16<tied0>, %vreg18, %vreg9,
                        %RM<imp-use>; VSLRC:%vreg16,%vreg18,%vreg9

and we remove: %vreg5<def> = COPY %vreg9; VSLRC:%vreg5,%vreg9

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204768 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agollvm/test/DebugInfo/empty.ll: Suppress crash for targeting pecoff while investigating.
NAKAMURA Takumi [Tue, 25 Mar 2014 23:16:44 +0000 (23:16 +0000)]
llvm/test/DebugInfo/empty.ll: Suppress crash for targeting pecoff while investigating.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204766 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUse Endian.h to simplify this code a bit.
Rafael Espindola [Tue, 25 Mar 2014 22:43:53 +0000 (22:43 +0000)]
Use Endian.h to simplify this code a bit.

While at it, factor some logic into FragmentWriter. This will allow more code
to be factored out of the fairly large ELFObjectWriter.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204765 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[configure/make] Propagate names of build host tools when making BuildTools
Meador Inge [Tue, 25 Mar 2014 21:45:41 +0000 (21:45 +0000)]
[configure/make] Propagate names of build host tools when making BuildTools

When cross-compiling LLVM itself the configure/make scripts get confused when
creating the needed build host tools.  For example, building and configuring
like:

  CC_FOR_BUILD='i686-pc-linux-gnu-gcc' CXX_FOR_BUILD='i686-pc-linux-gnu-g++'
  CXX='i686-mingw32-g++' CC='i686-mingw32-gcc' LD='i686-mingw32-ld' /scratch
  /meadori/llvm-trunk/src/trunk/configure --host=i686-mingw32

  CC_FOR_BUILD='i686-pc-linux-gnu-gcc' CXX_FOR_BUILD='i686-pc-linux-gnu-g++'
  CXX='i686-mingw32-g++' CC='i686-mingw32-gcc' LD='i686-mingw32-ld' make

causes the following build break:

  checking whether the C compiler works... configure: error: cannot run C
  compiled programs.
  If you meant to cross compile, use `--host'.
  See `config.log' for more details.

The 'config.log' shows that i686-mingw32-gcc is being used to create
executables for the build host.

This patch fixes the problem by propogating the names of the build host
tools via BUILD_* when configuring/making BuildTools.

Original patch by Ekaterina Sanina.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204760 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Constant Hoisting] Make the constant candidate map local to the collectConstantCandi...
Juergen Ributzka [Tue, 25 Mar 2014 21:21:10 +0000 (21:21 +0000)]
[Constant Hoisting] Make the constant candidate map local to the collectConstantCandidates method.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204758 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Correct commutable indices for VSX FMA instructions
Hal Finkel [Tue, 25 Mar 2014 19:26:43 +0000 (19:26 +0000)]
[PowerPC] Correct commutable indices for VSX FMA instructions

Although the first two operands are the ones that can be swapped, the tied
input operand is listed before them, so we need to adjust for that.

I have a test case for this, but it goes along with an upcoming commit (so it
will come soon).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204748 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PowerPC] Add a TableGen relation for A-type and M-type VSX FMA instructions
Hal Finkel [Tue, 25 Mar 2014 18:55:11 +0000 (18:55 +0000)]
[PowerPC] Add a TableGen relation for A-type and M-type VSX FMA instructions

TableGen will create a lookup table for the A-type FMA instructions providing
their corresponding M-form opcodes. This will be used by upcoming commits.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204746 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Move computeMaskedBitsForTargetNode out of AMDILISelLowering.cpp
Matt Arsenault [Tue, 25 Mar 2014 18:18:27 +0000 (18:18 +0000)]
R600: Move computeMaskedBitsForTargetNode out of AMDILISelLowering.cpp

Remove handling of select_cc, since it makes no sense to be there. This
now does nothing, but I'll be adding some handling of other target nodes
soon.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204743 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Implement Pass::releaseMemory()
Duncan P. N. Exon Smith [Tue, 25 Mar 2014 18:01:38 +0000 (18:01 +0000)]
blockfreq: Implement Pass::releaseMemory()

Implement Pass::releaseMemory() in BlockFrequencyInfo and
MachineBlockFrequencyInfo.  Just delete the private implementation when
not in use.  Switch to a std::unique_ptr to make the logic more clear.

<rdar://problem/14292693>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204741 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoblockfreq: Use const in MachineBlockFrequencyInfo
Duncan P. N. Exon Smith [Tue, 25 Mar 2014 18:01:32 +0000 (18:01 +0000)]
blockfreq: Use const in MachineBlockFrequencyInfo

<rdar://problem/14292693>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204740 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[X86TTI] Make constant base pointers for getElementPtr opaque.
Juergen Ributzka [Tue, 25 Mar 2014 18:01:25 +0000 (18:01 +0000)]
[X86TTI] Make constant base pointers for getElementPtr opaque.

If getElementPtr uses a constant as base pointer, then make the constant opaque.
This prevents constant folding it with the offset. The offset can usually be
encoded in the load/store instruction itself and the base address doesn't have
to be rematerialized several times.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204739 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Stackmaps][X86TTI] Fix think-o in getIntImmCost calculation.
Juergen Ributzka [Tue, 25 Mar 2014 18:01:23 +0000 (18:01 +0000)]
[Stackmaps][X86TTI] Fix think-o in getIntImmCost calculation.

The cost for the first four stackmap operands was always TCC_Free.
This is only true for the first two operands. All other operands
are TCC_Free if they are within 64bit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204738 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[DAG] Keep the opaque constant flag when performing unary constant folding operations.
Juergen Ributzka [Tue, 25 Mar 2014 18:01:20 +0000 (18:01 +0000)]
[DAG] Keep the opaque constant flag when performing unary constant folding operations.

Usually opaque constants shouldn't be folded, unless they are simple unary
operations that don't create new constants. Although this shouldn't drop the
opaque constant flag. This commit fixes this.

Related to <rdar://problem/14774662>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204737 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[X86] Generate VPSHUFB for in-place v16i16 shuffles
Adam Nemet [Tue, 25 Mar 2014 17:47:06 +0000 (17:47 +0000)]
[X86] Generate VPSHUFB for in-place v16i16 shuffles

This used to resort to splitting the 256-bit operation into two 128-bit
shuffles and then recombining the results.

Fixes <rdar://problem/16167303>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204735 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[X86] Factor out new helper getPSHUFB
Adam Nemet [Tue, 25 Mar 2014 17:47:03 +0000 (17:47 +0000)]
[X86] Factor out new helper getPSHUFB

I found three implementations of this.  This splits it out into a new function
and uses it from the three places.

My plan is to add a fourth use when lowering a vector_shuffle:v16i16.

Compared the assembly output of test/CodeGen/X86 before and after.

The only change is due to how the first PSHUFB was generated in
LowerVECTOR_SHUFFLEv8i16.  If the shuffle mask specified undef (i.e. -1), the
old implementation would write -1 * 2 and -1 * 2 + 1 (254 and 255) in the
control mask.  Now we write 0x80.  These are of course interchangeable since
bit 7 decides if a constant zero is written in the result byte.  The other
instances of this code use 0x80 consistently.

Related to <rdar://problem/16167303>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204734 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[InstCombine] Don't fold bitcast into store if it would need addrspacecast
Richard Osborne [Tue, 25 Mar 2014 17:21:41 +0000 (17:21 +0000)]
[InstCombine] Don't fold bitcast into store if it would need addrspacecast

Summary:
Previously the code didn't check if the before and after types for the
store were pointers to different address spaces. This resulted in
instcombine using a bitcast to convert between pointers to different
address spaces, causing an assertion due to the invalid cast.

It is not be appropriate to use addrspacecast this case because it is
not guaranteed to be a no-op cast. Instead bail out and do not do the
transformation.

CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3117

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204733 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoReuse earlier variables to make it clear the types involved in the cast.
Richard Osborne [Tue, 25 Mar 2014 17:21:35 +0000 (17:21 +0000)]
Reuse earlier variables to make it clear the types involved in the cast.

No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204732 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd missing slash to make the doxygen output less confusing.
Benjamin Kramer [Tue, 25 Mar 2014 17:20:28 +0000 (17:20 +0000)]
Add missing slash to make the doxygen output less confusing.

PR19187.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204731 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Add failing testcase for <3 x i32> stores.
Matt Arsenault [Tue, 25 Mar 2014 16:50:55 +0000 (16:50 +0000)]
R600: Add failing testcase for <3 x i32> stores.

This is supposed to have the same store size and alignment as <4 x i32>,
but currently is split into a 64-bit and 32-bit store.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204729 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoScalarEvolution: Compute exit counts for loops with a power-of-2 step.
Benjamin Kramer [Tue, 25 Mar 2014 16:25:12 +0000 (16:25 +0000)]
ScalarEvolution: Compute exit counts for loops with a power-of-2 step.

If we have a loop of the form
for (unsigned n = 0; n != (k & -32); n += 32) {}
then we know that n is always divisible by 32 and the loop must
terminate. Even if we have a condition where the loop counter will
overflow it'll always hold this invariant.

PR19183. Our loop vectorizer creates this pattern and it's also
occasionally formed by loop counters derived from pointers.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204728 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix creating illegal setcc cond codes.
Matt Arsenault [Tue, 25 Mar 2014 16:09:21 +0000 (16:09 +0000)]
Fix creating illegal setcc cond codes.

If GT/UGT or LT/ULT were set to expand, a comparison
with a constant would replace it with the illegal
cond code.

There are several more places later in this function that
will have the same basic problem.

Theoretically R600 should hit this problem for a test,
but for some reason it doesn't.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204727 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[msan] Relax the test some more.
Evgeniy Stepanov [Tue, 25 Mar 2014 14:32:05 +0000 (14:32 +0000)]
[msan] Relax the test some more.

This may or may not fix the bots. R204720 did not.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204721 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[msan] Make some tests less strict.
Evgeniy Stepanov [Tue, 25 Mar 2014 14:15:14 +0000 (14:15 +0000)]
[msan] Make some tests less strict.

This may or may not fix the bots.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204720 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix these tests on windows.
Rafael Espindola [Tue, 25 Mar 2014 13:19:03 +0000 (13:19 +0000)]
Fix these tests on windows.

It is impossible to create a hard link to a non existing file, so create a
dummy file, create the link an delete the dummy file.

On windows one cannot remove the current directory, so chdir first.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204719 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[msan] More precise instrumentation of select IR.
Evgeniy Stepanov [Tue, 25 Mar 2014 13:08:34 +0000 (13:08 +0000)]
[msan] More precise instrumentation of select IR.

Some bits of select result may be initialized even if select condition
is not.

https://code.google.com/p/memory-sanitizer/issues/detail?id=50

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204716 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] '.set at=$0' should be equivalent to '.set noat'
Daniel Sanders [Tue, 25 Mar 2014 13:01:06 +0000 (13:01 +0000)]
[mips] '.set at=$0' should be equivalent to '.set noat'

Differential Revision: http://llvm-reviews.chandlerc.com/D3171

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204714 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix AVX2 Gather execution domains.
Cameron McInally [Tue, 25 Mar 2014 12:36:38 +0000 (12:36 +0000)]
Fix AVX2 Gather execution domains.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204713 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Correct testcase for .set at=$reg and emit the new warnings for numeric regist...
Daniel Sanders [Tue, 25 Mar 2014 11:16:03 +0000 (11:16 +0000)]
[mips] Correct testcase for .set at=$reg and emit the new warnings for numeric registers too.

Summary:
Remove the XFAIL added in my previous commit and correct the test such that
it correctly tests the expansion of the assembler temporary.

Also added a test to check that $at is always $1 when written by the
user.

Corrected the new assembler temporary warnings so that they are emitted for
numeric registers too.

Differential Revision: http://llvm-reviews.chandlerc.com/D3169

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204711 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Fix assembler temporary expansion and add associated warnings about the use...
Daniel Sanders [Tue, 25 Mar 2014 10:57:07 +0000 (10:57 +0000)]
[mips] Fix assembler temporary expansion and add associated warnings about the use of $at.

Summary:
The assembler temporary is normally $at ($1) but can be reassigned using
'.set at=$reg'. Regardless of which register is nominated as the assembler
temporary, $at remains $1 when written by the user.

Adds warnings under the following conditions:
* The register nominated as the assembler temporary is used by the user.
* '.set noat' is in effect and $at is used by the user.
Both of these only work for named registers. I have a follow up commit that makes it work for numeric registers as well.

XFAIL set-at-directive.s since it incorrectly tests that $at is redefined by
'.set at=$reg'. Testcases will follow in a separate commit.

Patch by David Chisnall
His work was sponsored by: DARPA, AFRL

Differential Revision: http://llvm-reviews.chandlerc.com/D3167

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204710 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRemove cmake module support for Visual C++ 2010 (MSVC10)
Yaron Keren [Tue, 25 Mar 2014 09:34:20 +0000 (09:34 +0000)]
Remove cmake module support for Visual C++ 2010 (MSVC10)
but keep the MSVC11 (Visual C++ 2012) support.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204706 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplify loop that worked around bugs in old GCC/Xcode.
Erik Verbruggen [Tue, 25 Mar 2014 09:06:18 +0000 (09:06 +0000)]
Simplify loop that worked around bugs in old GCC/Xcode.

GCC 4.0.1 and Xcode 2 are no longer supported for building llvm/clang.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204705 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDisable Visual C++ warning 4722 about aborting a destructor,
Yaron Keren [Tue, 25 Mar 2014 08:42:49 +0000 (08:42 +0000)]
Disable Visual C++ warning 4722 about aborting a destructor,
it has no value for us.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204704 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoWinCOFF: Add support for -fdata-sections
David Majnemer [Tue, 25 Mar 2014 06:14:26 +0000 (06:14 +0000)]
WinCOFF: Add support for -fdata-sections

This is a pretty straight forward translation for COFF, we just need to
stick the data in a COMDAT section marked as
IMAGE_COMDAT_SELECT_NODUPLICATES.

N.B. We must be careful to avoid sticking entities with private linkage
in COMDAT groups.  COFF is pretty hostile to the renaming of entities so
we must be careful to disallow GlobalVariables with unstable names.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204703 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Add GNU_addr_base and GNU_ranges_base only when there are addresses or...
David Blaikie [Tue, 25 Mar 2014 05:34:24 +0000 (05:34 +0000)]
DebugInfo: Add GNU_addr_base and GNU_ranges_base only when there are addresses or ranges

Based on code review feedback from Eric in r204672.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204702 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agotest: fix CHECK lines
Saleem Abdulrasool [Tue, 25 Mar 2014 03:39:39 +0000 (03:39 +0000)]
test: fix CHECK lines

Thanks to gix for pointing out that the CHECK-LABEL lines were incorrect!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204700 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSLP vectorizer: Don't hoist vector extracts of phis.
Andrew Trick [Tue, 25 Mar 2014 02:18:47 +0000 (02:18 +0000)]
SLP vectorizer: Don't hoist vector extracts of phis.

Extracts coming from phis were being hoisted, while all others were
sunk to their uses. This was inconsistent and didn't seem to serve a
purpose. Changing all extracts to be sunk to uses is a prerequisite
for adding block frequency to the SLP vectorizer's cost model.

I benchmarked the change in isolation (without block frequency). I
only saw noise on x86 and some potentially significant improvements on
ARM. No major regressions is good enough for me.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204699 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Support debug_loc under fission
David Blaikie [Tue, 25 Mar 2014 01:44:02 +0000 (01:44 +0000)]
DebugInfo: Support debug_loc under fission

Implement debug_loc.dwo, as well as llvm-dwarfdump support for dumping
this section.

Outlined in the DWARF5 spec and http://gcc.gnu.org/wiki/DebugFission the
debug_loc.dwo section has more variation than the standard debug_loc,
allowing 3 different forms of entry (plus the end of list entry). GCC
seems to, and Clang certainly, only use one form, so I've just
implemented dumping support for that for now.

It wasn't immediately obvious that there was a good refactoring to share
the implementation of dumping support between debug_loc and
debug_loc.dwo, so they're separate for now - ideas welcome or I may come
back to it at some point.

As per a comment in the code, we could choose different forms that may
reduce the number of debug_addr entries we emit, but that will require
further study.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204697 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Remove unnecessary zero-size check
David Blaikie [Tue, 25 Mar 2014 01:43:56 +0000 (01:43 +0000)]
DebugInfo: Remove unnecessary zero-size check

This seems excessive - switching section isn't expensive (or if it is
we're already being wasteful, since we emitted the debug_loc section
symbol earlier anyway) and otherwise there's no work that happens in
this function when the list is empty.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204696 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSupport: Functions for consuming endian specific data from a buffer.
Justin Bogner [Tue, 25 Mar 2014 01:04:44 +0000 (01:04 +0000)]
Support: Functions for consuming endian specific data from a buffer.

This adds a function to Endian.h that reads from and updates a pointer
into a buffer with endian specific data. This is more convenient for
stream-like reading of data than endian::read.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204693 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRegister Allocator: check other options before using a CSR for the first time.
Manman Ren [Tue, 25 Mar 2014 00:16:25 +0000 (00:16 +0000)]
Register Allocator: check other options before using a CSR for the first time.

When register allocator's stage is RS_Spill, we choose spill over using the CSR
for the first time, if the spill cost is lower than CSRCost.
When register allocator's stage is < RS_Split, we choose pre-splitting over
using the CSR for the first time, if the cost of splitting is lower than
CSRCost.

CSRCost is set with command-line option "regalloc-csr-first-time-cost". The
default value is 0 to generate the same codes as before this commit.

With a value of 15 (1 << 14 is the entry frequency), I measured performance
gain of 3% on 253.perlbmk and 1.7% on 197.parser, with instrumented PGO,
on an arm device.

rdar://16162005

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204690 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix crashes when assembler directives are used that are not
Kevin Enderby [Tue, 25 Mar 2014 00:05:50 +0000 (00:05 +0000)]
Fix crashes when assembler directives are used that are not
for Mach-O object files by generating an error instead.

rdar://16335232

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204687 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRegister Allocator: refactoring (no functionality change).
Manman Ren [Mon, 24 Mar 2014 23:23:42 +0000 (23:23 +0000)]
Register Allocator: refactoring (no functionality change).

Factor out two functions calculateRegionSplitCost and doRegionSplit
from tryRegionSplit. These two functions will be used in coming patches.

rdar://16162005

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204684 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Simplify debug loc list handling by keeping separate lists
David Blaikie [Mon, 24 Mar 2014 22:38:38 +0000 (22:38 +0000)]
DebugInfo: Simplify debug loc list handling by keeping separate lists

Rather than using a flat list with "empty" entries (ala the actual
on-disk format), keep separate lists for each variable.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204680 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDwarfDebug: Simplify debug_loc merging
David Blaikie [Mon, 24 Mar 2014 22:27:06 +0000 (22:27 +0000)]
DwarfDebug: Simplify debug_loc merging

No functional change intended.

Merging up-front rather than delaying this task until later. This just
seems simpler and more efficient (avoiding growing the debug loc list
only to have to skip over those post-merged entries, etc).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204679 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoGet rid of an unnecessary use of the * and & operators.
Adrian Prantl [Mon, 24 Mar 2014 21:33:01 +0000 (21:33 +0000)]
Get rid of an unnecessary use of the * and & operators.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204673 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Add DW_AT_GNU_ranges_base to skeleton CUs
David Blaikie [Mon, 24 Mar 2014 21:31:35 +0000 (21:31 +0000)]
DebugInfo: Add DW_AT_GNU_ranges_base to skeleton CUs

This is used to avoid relocations in the dwo file by allowing
DW_AT_ranges specified in debug_info.dwo to be relative to this base
address. (r204667 implements the base-relative DW_AT_ranges side of
this)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204672 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSupport: Document Endian.h functions
Justin Bogner [Mon, 24 Mar 2014 21:30:55 +0000 (21:30 +0000)]
Support: Document Endian.h functions

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204671 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Implement relative addressing for DW_AT_ranges under fission
David Blaikie [Mon, 24 Mar 2014 21:07:27 +0000 (21:07 +0000)]
DebugInfo: Implement relative addressing for DW_AT_ranges under fission

This removes the debug_ranges relocations from debug_info.dwo (but
doesn't implement the DW_AT_GNU_ranges_base which is also necessary for
correct functioning)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204668 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Don't emit relocations to abbreviations in debug_info.dwo
David Blaikie [Mon, 24 Mar 2014 20:53:02 +0000 (20:53 +0000)]
DebugInfo: Don't emit relocations to abbreviations in debug_info.dwo

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204667 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDwarfDebug: Remove an unused parameter
David Blaikie [Mon, 24 Mar 2014 20:31:01 +0000 (20:31 +0000)]
DwarfDebug: Remove an unused parameter

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204665 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600: Don't viewCFG() under DEBUG() except on failure.
Matt Arsenault [Mon, 24 Mar 2014 20:29:02 +0000 (20:29 +0000)]
R600: Don't viewCFG() under DEBUG() except on failure.

Having these popping up every time you use -debug is really
irritating.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204664 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRemove unused parameter
David Blaikie [Mon, 24 Mar 2014 20:28:10 +0000 (20:28 +0000)]
Remove unused parameter

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204663 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600/SI: Fix extra mov from legalizing 64-bit SALU ops.
Matt Arsenault [Mon, 24 Mar 2014 20:08:13 +0000 (20:08 +0000)]
R600/SI: Fix extra mov from legalizing 64-bit SALU ops.

Check the register class of each operand individually
to avoid an extra copy to a vgpr.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204662 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600/SI: Sub-optimial fix for 64-bit immediates with SALU ops.
Matt Arsenault [Mon, 24 Mar 2014 20:08:09 +0000 (20:08 +0000)]
R600/SI: Sub-optimial fix for 64-bit immediates with SALU ops.

No longer asserts, but now you get moves loading legal immediates
into the split 32-bit operations.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204661 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600/SI: Fix 64-bit bit ops that require the VALU.
Matt Arsenault [Mon, 24 Mar 2014 20:08:05 +0000 (20:08 +0000)]
R600/SI: Fix 64-bit bit ops that require the VALU.

Try to match scalar and first like the other instructions.
Expand 64-bit ands to a pair of 32-bit ands since that is not
available on the VALU.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204660 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoIn Release modes, Visual Studio complains that the Operator destructor in User.cpp
Yaron Keren [Mon, 24 Mar 2014 19:48:13 +0000 (19:48 +0000)]
In Release modes, Visual Studio complains that the Operator destructor in User.cpp
never returns, which is true by design.

Initially assumed that the reason is llvm_unreachable being dependent on NDEBUG.

However, even if llvm_unreachable is replaced by __assume(false), VC still warns in
Release modes but not in Debug modes...

The real reason turned out to be optimization flags.
With /Od in Debug modes the warning is not issued whereas with /O1 it is.

I could not find any documentation to this effect, but it is reproducable:

Try compiling http://msdn.microsoft.com/en-us/library/khwfyc5d(v=vs.90).aspx
with /O1 and then with /Od.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204659 91177308-0d34-0410-b5e6-96231b3b80d8