[MCJIT] Improve the "stub not found" diagnostic in RuntimeDyldChecker.
authorLang Hames <lhames@gmail.com>
Thu, 11 Sep 2014 23:09:22 +0000 (23:09 +0000)
committerLang Hames <lhames@gmail.com>
Thu, 11 Sep 2014 23:09:22 +0000 (23:09 +0000)
commit264a325a90f7b397b8c9ff954080ffc73c9e2483
tree5be6f441276b74b44eacfc009003908c071e0f14
parentd76b9eff066e44f200832ab20cfb702339966280
[MCJIT] Improve the "stub not found" diagnostic in RuntimeDyldChecker.

A "stub found found" diagnostic is emitted when RuntimeDyldChecker's stub lookup
logic fails to find the requested stub. The obvious reason for the failure is
that no such stub has been created, but it can also fail for internal symbols if
the symbol offset is not computed correctly (E.g. due to a mangled relocation
addend). This patch adds a comment about the latter case so that it's not
overlooked.

Inspired by confusion experienced during test case construction for r217635.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217643 91177308-0d34-0410-b5e6-96231b3b80d8
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp