#include "llvm/Module.h"
#include "llvm/ModuleProvider.h"
#include "llvm/DerivedTypes.h"
+#include "llvm/InlineAsm.h"
#include "llvm/Instructions.h"
#include "llvm/Intrinsics.h"
#include "llvm/PassManager.h"
#include "llvm/Analysis/Dominators.h"
#include "llvm/Support/CFG.h"
#include "llvm/Support/InstVisitor.h"
+#include "llvm/ADT/StringExtras.h"
#include "llvm/ADT/STLExtras.h"
+#include "llvm/Support/Compiler.h"
#include <algorithm>
#include <iostream>
#include <sstream>
+#include <cstdarg>
using namespace llvm;
namespace { // Anonymous namespace for class
- struct Verifier : public FunctionPass, InstVisitor<Verifier> {
+ struct VISIBILITY_HIDDEN
+ Verifier : public FunctionPass, InstVisitor<Verifier> {
bool Broken; // Is this module found to be broken?
bool RealPass; // Are we not being run by a PassManager?
VerifierFailureAction action;
// returning back to the pass manager, or else the pass manager may try to
// run other passes on the broken module.
if (RealPass)
- abortIfBroken();
+ return abortIfBroken();
return false;
}
// returning back to the pass manager, or else the pass manager may try to
// run other passes on the broken module.
if (RealPass)
- abortIfBroken();
+ return abortIfBroken();
return false;
}
if (I->isExternal()) visitFunction(*I);
}
- for (Module::global_iterator I = M.global_begin(), E = M.global_end(); I != E; ++I)
+ for (Module::global_iterator I = M.global_begin(), E = M.global_end();
+ I != E; ++I)
visitGlobalVariable(*I);
// If the module is broken, abort at this time.
- abortIfBroken();
- return false;
+ return abortIfBroken();
}
virtual void getAnalysisUsage(AnalysisUsage &AU) const {
AU.setPreservesAll();
if (RealPass)
- AU.addRequired<ETForest>();
+ AU.addRequired<ETForest>();
}
/// abortIfBroken - If the module is broken and we are supposed to abort on
/// this condition, do so.
///
- void abortIfBroken() {
- if (Broken)
- {
+ bool abortIfBroken() {
+ if (Broken) {
msgs << "Broken module found, ";
- switch (action)
- {
+ switch (action) {
case AbortProcessAction:
msgs << "compilation aborted!\n";
std::cerr << msgs.str();
abort();
- case ThrowExceptionAction:
- msgs << "verification terminated.\n";
- throw msgs.str();
case PrintMessageAction:
msgs << "verification continues.\n";
std::cerr << msgs.str();
- break;
+ return false;
case ReturnStatusAction:
- break;
+ msgs << "compilation terminated.\n";
+ return Broken;
}
}
+ return false;
}
void visitBinaryOperator(BinaryOperator &B);
void visitShiftInst(ShiftInst &SI);
void visitExtractElementInst(ExtractElementInst &EI);
+ void visitInsertElementInst(InsertElementInst &EI);
+ void visitShuffleVectorInst(ShuffleVectorInst &EI);
void visitVAArgInst(VAArgInst &VAA) { visitInstruction(VAA); }
void visitCallInst(CallInst &CI);
void visitGetElementPtrInst(GetElementPtrInst &GEP);
void visitUserOp2(Instruction &I) { visitUserOp1(I); }
void visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI);
+ void VerifyIntrinsicPrototype(Function *F, ...);
void WriteValue(const Value *V) {
if (!V) return;
}
};
- RegisterOpt<Verifier> X("verify", "Module Verifier");
+ RegisterPass<Verifier> X("verify", "Module Verifier");
} // End anonymous namespace
void Verifier::visitGlobalValue(GlobalValue &GV) {
- Assert1(!GV.isExternal() || GV.hasExternalLinkage(),
- "Global is external, but doesn't have external linkage!", &GV);
+ Assert1(!GV.isExternal() ||
+ GV.hasExternalLinkage() ||
+ GV.hasDLLImportLinkage() ||
+ GV.hasExternalWeakLinkage(),
+ "Global is external, but doesn't have external or dllimport or weak linkage!",
+ &GV);
+
+ Assert1(!GV.hasDLLImportLinkage() || GV.isExternal(),
+ "Global is marked as dllimport, but not external", &GV);
+
Assert1(!GV.hasAppendingLinkage() || isa<GlobalVariable>(GV),
"Only global variables can have appending linkage!", &GV);
// visitFunction - Verify that a function is ok.
//
void Verifier::visitFunction(Function &F) {
- Assert1(!F.isVarArg() || F.getCallingConv() == CallingConv::C,
- "Varargs functions must have C calling conventions!", &F);
-
// Check function arguments.
const FunctionType *FT = F.getFunctionType();
unsigned NumArgs = F.getArgumentList().size();
F.getReturnType() == Type::VoidTy,
"Functions cannot return aggregate values!", &F);
+ // Check that this function meets the restrictions on this calling convention.
+ switch (F.getCallingConv()) {
+ default:
+ break;
+ case CallingConv::C:
+ break;
+ case CallingConv::CSRet:
+ Assert1(FT->getReturnType() == Type::VoidTy &&
+ FT->getNumParams() > 0 && isa<PointerType>(FT->getParamType(0)),
+ "Invalid struct-return function!", &F);
+ break;
+ case CallingConv::Fast:
+ case CallingConv::Cold:
+ Assert1(!F.isVarArg(),
+ "Varargs functions must have C calling conventions!", &F);
+ break;
+ }
+
// Check that the argument values match the function type for this function...
unsigned i = 0;
for (Function::arg_iterator I = F.arg_begin(), E = F.arg_end(); I != E; ++I, ++i) {
/// a pass, if any exist, it's an error.
///
void Verifier::visitUserOp1(Instruction &I) {
- Assert1(0, "User-defined operators should not live outside of a pass!",
- &I);
+ Assert1(0, "User-defined operators should not live outside of a pass!", &I);
}
/// visitPHINode - Ensure that a PHI node is well formed.
}
void Verifier::visitExtractElementInst(ExtractElementInst &EI) {
- Assert1(isa<PackedType>(EI.getOperand(0)->getType()),
- "First operand to extractelement must be packed type!", &EI);
- Assert1(EI.getOperand(1)->getType() == Type::UIntTy,
- "Second operand to extractelement must be uint type!", &EI);
- Assert1(EI.getType() ==
- cast<PackedType>(EI.getOperand(0)->getType())->getElementType(),
- "Extractelement return type must be same as "
- "first operand element type!", &EI);
+ Assert1(ExtractElementInst::isValidOperands(EI.getOperand(0),
+ EI.getOperand(1)),
+ "Invalid extractelement operands!", &EI);
visitInstruction(EI);
}
+void Verifier::visitInsertElementInst(InsertElementInst &IE) {
+ Assert1(InsertElementInst::isValidOperands(IE.getOperand(0),
+ IE.getOperand(1),
+ IE.getOperand(2)),
+ "Invalid insertelement operands!", &IE);
+ visitInstruction(IE);
+}
+
+void Verifier::visitShuffleVectorInst(ShuffleVectorInst &SV) {
+ Assert1(ShuffleVectorInst::isValidOperands(SV.getOperand(0), SV.getOperand(1),
+ SV.getOperand(2)),
+ "Invalid shufflevector operands!", &SV);
+ Assert1(SV.getType() == SV.getOperand(0)->getType(),
+ "Result of shufflevector must match first operand type!", &SV);
+
+ // Check to see if Mask is valid.
+ if (const ConstantPacked *MV = dyn_cast<ConstantPacked>(SV.getOperand(2))) {
+ for (unsigned i = 0, e = MV->getNumOperands(); i != e; ++i) {
+ Assert1(isa<ConstantUInt>(MV->getOperand(i)) ||
+ isa<UndefValue>(MV->getOperand(i)),
+ "Invalid shufflevector shuffle mask!", &SV);
+ }
+ } else {
+ Assert1(isa<UndefValue>(SV.getOperand(2)) ||
+ isa<ConstantAggregateZero>(SV.getOperand(2)),
+ "Invalid shufflevector shuffle mask!", &SV);
+ }
+
+ visitInstruction(SV);
+}
+
void Verifier::visitGetElementPtrInst(GetElementPtrInst &GEP) {
const Type *ElTy =
GetElementPtrInst::getIndexedType(GEP.getOperand(0)->getType(),
}
for (unsigned i = 0, e = I.getNumOperands(); i != e; ++i) {
- // Check to make sure that the "address of" an intrinsic function is never
- // taken.
Assert1(I.getOperand(i) != 0, "Instruction has null operand!", &I);
+
+ // Check to make sure that only first-class-values are operands to
+ // instructions.
+ Assert1(I.getOperand(i)->getType()->isFirstClassType(),
+ "Instruction operands must be first-class values!", &I);
+
if (Function *F = dyn_cast<Function>(I.getOperand(i))) {
+ // Check to make sure that the "address of" an intrinsic function is never
+ // taken.
Assert1(!F->isIntrinsic() || (i == 0 && isa<CallInst>(I)),
"Cannot take the address of an intrinsic!", &I);
} else if (BasicBlock *OpBB = dyn_cast<BasicBlock>(I.getOperand(i))) {
!EF->dominates(&BB->getParent()->getEntryBlock(), PredBB),
"Instruction does not dominate all uses!", Op, &I);
}
+ } else if (isa<InlineAsm>(I.getOperand(i))) {
+ Assert1(i == 0 && isa<CallInst>(I),
+ "Cannot take the address of an inline asm!", &I);
}
}
InstsInThisBlock.insert(&I);
///
void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) {
Function *IF = CI.getCalledFunction();
- const FunctionType *FT = IF->getFunctionType();
Assert1(IF->isExternal(), "Intrinsic functions should never be defined!", IF);
- unsigned NumArgs = 0;
-
- // FIXME: this should check the return type of each intrinsic as well, also
- // arguments!
- switch (ID) {
- case Intrinsic::vastart:
- Assert1(CI.getParent()->getParent()->getFunctionType()->isVarArg(),
- "llvm.va_start intrinsic may only occur in function with variable"
- " args!", &CI);
- NumArgs = 1;
- break;
- case Intrinsic::vaend: NumArgs = 1; break;
- case Intrinsic::vacopy: NumArgs = 2; break;
-
- case Intrinsic::returnaddress:
- case Intrinsic::frameaddress:
- Assert1(isa<PointerType>(FT->getReturnType()),
- "llvm.(frame|return)address must return pointers", IF);
- Assert1(FT->getNumParams() == 1 && isa<ConstantInt>(CI.getOperand(1)),
- "llvm.(frame|return)address require a single constant integer argument",
- &CI);
- NumArgs = 1;
- break;
-
- // Verify that read and write port have integral parameters of the correct
- // signed-ness.
- case Intrinsic::writeport:
- Assert1(FT->getNumParams() == 2,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getParamType(0)->isIntegral(),
- "First argument not unsigned int!", IF);
- Assert1(FT->getParamType(1)->isUnsigned(),
- "First argument not unsigned int!", IF);
- NumArgs = 2;
- break;
-
- case Intrinsic::writeio:
- Assert1(FT->getNumParams() == 2,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getParamType(0)->isFirstClassType(),
- "First argument not a first class type!", IF);
- Assert1(isa<PointerType>(FT->getParamType(1)),
- "Second argument not a pointer!", IF);
- NumArgs = 2;
- break;
-
- case Intrinsic::readport:
- Assert1(FT->getNumParams() == 1,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getReturnType()->isFirstClassType(),
- "Return type is not a first class type!", IF);
- Assert1(FT->getParamType(0)->isUnsigned(),
- "First argument not unsigned int!", IF);
- NumArgs = 1;
- break;
-
- case Intrinsic::readio: {
- const PointerType *ParamType = dyn_cast<PointerType>(FT->getParamType(0));
- const Type *ReturnType = FT->getReturnType();
-
- Assert1(FT->getNumParams() == 1,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(ParamType, "First argument not a pointer!", IF);
- Assert1(ParamType->getElementType() == ReturnType,
- "Pointer type doesn't match return type!", IF);
- NumArgs = 1;
- break;
- }
-
- case Intrinsic::isunordered:
- Assert1(FT->getNumParams() == 2,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getReturnType() == Type::BoolTy,
- "Return type is not bool!", IF);
- Assert1(FT->getParamType(0) == FT->getParamType(1),
- "Arguments must be of the same type!", IF);
- Assert1(FT->getParamType(0)->isFloatingPoint(),
- "Argument is not a floating point type!", IF);
- NumArgs = 2;
- break;
+
+#define GET_INTRINSIC_VERIFIER
+#include "llvm/Intrinsics.gen"
+#undef GET_INTRINSIC_VERIFIER
+}
- case Intrinsic::readcyclecounter:
- Assert1(FT->getNumParams() == 0,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getReturnType() == Type::ULongTy,
- "Return type is not ulong!", IF);
- NumArgs = 0;
- break;
+/// VerifyIntrinsicPrototype - TableGen emits calls to this function into
+/// Intrinsics.gen. This implements a little state machine that verifies the
+/// prototype of intrinsics.
+void Verifier::VerifyIntrinsicPrototype(Function *F, ...) {
+ va_list VA;
+ va_start(VA, F);
+
+ const FunctionType *FTy = F->getFunctionType();
+
+ // Note that "arg#0" is the return type.
+ for (unsigned ArgNo = 0; 1; ++ArgNo) {
+ int TypeID = va_arg(VA, int);
+
+ if (TypeID == -1) {
+ if (ArgNo != FTy->getNumParams()+1)
+ CheckFailed("Intrinsic prototype has too many arguments!", F);
+ break;
+ }
- case Intrinsic::bswap_i16:
- Assert1(FT->getNumParams() == 1,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getReturnType() == FT->getParamType(0),
- "Return type does not match source type", IF);
- Assert1(FT->getReturnType() == Type::UShortTy,
- "Return type is not ushort!", IF);
- NumArgs = 1;
- break;
-
- case Intrinsic::bswap_i32:
- Assert1(FT->getNumParams() == 1,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getReturnType() == FT->getParamType(0),
- "Return type does not match source type", IF);
- Assert1(FT->getReturnType() == Type::UIntTy,
- "Return type is not uint!", IF);
- NumArgs = 1;
- break;
-
- case Intrinsic::bswap_i64:
- Assert1(FT->getNumParams() == 1,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getReturnType() == FT->getParamType(0),
- "Return type does not match source type", IF);
- Assert1(FT->getReturnType() == Type::ULongTy,
- "Return type is not ulong!", IF);
- NumArgs = 1;
- break;
+ if (ArgNo == FTy->getNumParams()+1) {
+ CheckFailed("Intrinsic prototype has too few arguments!", F);
+ break;
+ }
- case Intrinsic::ctpop:
- case Intrinsic::ctlz:
- case Intrinsic::cttz:
- Assert1(FT->getNumParams() == 1,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getReturnType() == FT->getParamType(0),
- "Return type does not match source type", IF);
- Assert1(FT->getParamType(0)->isIntegral(),
- "Argument must be of an int type!", IF);
- NumArgs = 1;
- break;
-
- case Intrinsic::sqrt:
- Assert1(FT->getNumParams() == 1,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(FT->getParamType(0)->isFloatingPoint(),
- "Argument is not a floating point type!", IF);
- Assert1(FT->getReturnType() == FT->getParamType(0),
- "Return type is not the same as argument type!", IF);
- NumArgs = 1;
- break;
+ const Type *Ty;
+ if (ArgNo == 0)
+ Ty = FTy->getReturnType();
+ else
+ Ty = FTy->getParamType(ArgNo-1);
+
+ if (Ty->getTypeID() != TypeID) {
+ if (ArgNo == 0)
+ CheckFailed("Intrinsic prototype has incorrect result type!", F);
+ else
+ CheckFailed("Intrinsic parameter #" + utostr(ArgNo-1) + " is wrong!",F);
+ break;
+ }
- case Intrinsic::setjmp: NumArgs = 1; break;
- case Intrinsic::longjmp: NumArgs = 2; break;
- case Intrinsic::sigsetjmp: NumArgs = 2; break;
- case Intrinsic::siglongjmp: NumArgs = 2; break;
-
- case Intrinsic::gcroot:
- Assert1(FT->getNumParams() == 2,
- "Illegal # arguments for intrinsic function!", IF);
- Assert1(isa<Constant>(CI.getOperand(2)),
- "Second argument to llvm.gcroot must be a constant!", &CI);
- NumArgs = 2;
- break;
- case Intrinsic::gcread: NumArgs = 2; break;
- case Intrinsic::gcwrite: NumArgs = 3; break;
-
- case Intrinsic::dbg_stoppoint: NumArgs = 4; break;
- case Intrinsic::dbg_region_start:NumArgs = 1; break;
- case Intrinsic::dbg_region_end: NumArgs = 1; break;
- case Intrinsic::dbg_func_start: NumArgs = 1; break;
- case Intrinsic::dbg_declare: NumArgs = 1; break;
-
- case Intrinsic::memcpy: NumArgs = 4; break;
- case Intrinsic::memmove: NumArgs = 4; break;
- case Intrinsic::memset: NumArgs = 4; break;
-
- case Intrinsic::stacksave:
- NumArgs = 0;
- Assert1(CI.getType() == PointerType::get(Type::SByteTy),
- "llvm.stacksave must return an sbyte*", &CI);
- break;
- case Intrinsic::stackrestore:
- NumArgs = 1;
- Assert1(CI.getOperand(1)->getType() == PointerType::get(Type::SByteTy),
- "llvm.stackrestore must take an sbyte*", &CI);
- Assert1(CI.getType() == Type::VoidTy,
- "llvm.stackrestore return void", &CI);
- break;
- case Intrinsic::prefetch: NumArgs = 3; break;
- case Intrinsic::pcmarker:
- NumArgs = 1;
- Assert1(isa<Constant>(CI.getOperand(1)),
- "First argument to llvm.pcmarker must be a constant!", &CI);
- break;
+ // If this is a packed argument, verify the number and type of elements.
+ if (TypeID == Type::PackedTyID) {
+ const PackedType *PTy = cast<PackedType>(Ty);
+ if (va_arg(VA, int) != PTy->getElementType()->getTypeID()) {
+ CheckFailed("Intrinsic prototype has incorrect vector element type!",F);
+ break;
+ }
- case Intrinsic::not_intrinsic:
- assert(0 && "Invalid intrinsic!"); NumArgs = 0; break;
+ if ((unsigned)va_arg(VA, int) != PTy->getNumElements()) {
+ CheckFailed("Intrinsic prototype has incorrect number of "
+ "vector elements!",F);
+ break;
+ }
+ }
}
- Assert1(FT->getNumParams() == NumArgs || (FT->getNumParams() < NumArgs &&
- FT->isVarArg()),
- "Illegal # arguments for intrinsic function!", IF);
+ va_end(VA);
}
/// verifyModule - Check a module for errors, printing messages on stderr.
/// Return true if the module is corrupt.
///
-bool llvm::verifyModule(const Module &M, VerifierFailureAction action) {
+bool llvm::verifyModule(const Module &M, VerifierFailureAction action,
+ std::string *ErrorInfo) {
PassManager PM;
Verifier *V = new Verifier(action);
PM.add(V);
PM.run((Module&)M);
+
+ if (ErrorInfo && V->Broken)
+ *ErrorInfo = V->msgs.str();
return V->Broken;
}
projects / oota-llvm.git / blobdiff