//
// The LLVM Compiler Infrastructure
//
-// This file was developed by the Owen Anderson and is distributed under
-// the University of Illinois Open Source License. See LICENSE.TXT for details.
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
//
#include "llvm/ADT/DepthFirstIterator.h"
#include "llvm/ADT/PostOrderIterator.h"
#include "llvm/ADT/SmallPtrSet.h"
+#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/Statistic.h"
+#include "llvm/Transforms/Utils/UnifyFunctionExitNodes.h"
#include "llvm/Support/CFG.h"
#include "llvm/Support/Compiler.h"
#include "llvm/Support/Debug.h"
#include <algorithm>
#include <deque>
#include <map>
-#include <vector>
-#include <set>
using namespace llvm;
//===----------------------------------------------------------------------===//
// ValueTable Class
//===----------------------------------------------------------------------===//
+namespace {
+
/// This class holds the mapping between values and value numbers. It is used
/// as an efficient mechanism to determine the expression-wise equivalence of
/// two values.
-namespace {
- class VISIBILITY_HIDDEN ValueTable {
- public:
- struct Expression {
- enum ExpressionOpcode { ADD, SUB, MUL, UDIV, SDIV, FDIV, UREM, SREM,
- FREM, SHL, LSHR, ASHR, AND, OR, XOR, ICMPEQ,
- ICMPNE, ICMPUGT, ICMPUGE, ICMPULT, ICMPULE,
- ICMPSGT, ICMPSGE, ICMPSLT, ICMPSLE, FCMPOEQ,
- FCMPOGT, FCMPOGE, FCMPOLT, FCMPOLE, FCMPONE,
- FCMPORD, FCMPUNO, FCMPUEQ, FCMPUGT, FCMPUGE,
- FCMPULT, FCMPULE, FCMPUNE, EXTRACT, INSERT,
- SHUFFLE, SELECT, TRUNC, ZEXT, SEXT, FPTOUI,
- FPTOSI, UITOFP, SITOFP, FPTRUNC, FPEXT,
- PTRTOINT, INTTOPTR, BITCAST, GEP};
-
- ExpressionOpcode opcode;
- const Type* type;
- uint32_t firstVN;
- uint32_t secondVN;
- uint32_t thirdVN;
- std::vector<uint32_t> varargs;
+struct Expression {
+ enum ExpressionOpcode { ADD, SUB, MUL, UDIV, SDIV, FDIV, UREM, SREM,
+ FREM, SHL, LSHR, ASHR, AND, OR, XOR, ICMPEQ,
+ ICMPNE, ICMPUGT, ICMPUGE, ICMPULT, ICMPULE,
+ ICMPSGT, ICMPSGE, ICMPSLT, ICMPSLE, FCMPOEQ,
+ FCMPOGT, FCMPOGE, FCMPOLT, FCMPOLE, FCMPONE,
+ FCMPORD, FCMPUNO, FCMPUEQ, FCMPUGT, FCMPUGE,
+ FCMPULT, FCMPULE, FCMPUNE, EXTRACT, INSERT,
+ SHUFFLE, SELECT, TRUNC, ZEXT, SEXT, FPTOUI,
+ FPTOSI, UITOFP, SITOFP, FPTRUNC, FPEXT,
+ PTRTOINT, INTTOPTR, BITCAST, GEP, EMPTY,
+ TOMBSTONE };
+
+ ExpressionOpcode opcode;
+ const Type* type;
+ uint32_t firstVN;
+ uint32_t secondVN;
+ uint32_t thirdVN;
+ SmallVector<uint32_t, 4> varargs;
+
+ Expression() { }
+ explicit Expression(ExpressionOpcode o) : opcode(o) { }
+
+ bool operator==(const Expression &other) const {
+ if (opcode != other.opcode)
+ return false;
+ else if (opcode == EMPTY || opcode == TOMBSTONE)
+ return true;
+ else if (type != other.type)
+ return false;
+ else if (firstVN != other.firstVN)
+ return false;
+ else if (secondVN != other.secondVN)
+ return false;
+ else if (thirdVN != other.thirdVN)
+ return false;
+ else {
+ if (varargs.size() != other.varargs.size())
+ return false;
- bool operator< (const Expression& other) const {
- if (opcode < other.opcode)
- return true;
- else if (opcode > other.opcode)
- return false;
- else if (type < other.type)
- return true;
- else if (type > other.type)
- return false;
- else if (firstVN < other.firstVN)
- return true;
- else if (firstVN > other.firstVN)
- return false;
- else if (secondVN < other.secondVN)
- return true;
- else if (secondVN > other.secondVN)
- return false;
- else if (thirdVN < other.thirdVN)
- return true;
- else if (thirdVN > other.thirdVN)
- return false;
- else {
- if (varargs.size() < other.varargs.size())
- return true;
- else if (varargs.size() > other.varargs.size())
- return false;
-
- for (size_t i = 0; i < varargs.size(); ++i)
- if (varargs[i] < other.varargs[i])
- return true;
- else if (varargs[i] > other.varargs[i])
- return false;
-
- return false;
- }
- }
- };
+ for (size_t i = 0; i < varargs.size(); ++i)
+ if (varargs[i] != other.varargs[i])
+ return false;
+
+ return true;
+ }
+ }
+
+ bool operator!=(const Expression &other) const {
+ if (opcode != other.opcode)
+ return true;
+ else if (opcode == EMPTY || opcode == TOMBSTONE)
+ return false;
+ else if (type != other.type)
+ return true;
+ else if (firstVN != other.firstVN)
+ return true;
+ else if (secondVN != other.secondVN)
+ return true;
+ else if (thirdVN != other.thirdVN)
+ return true;
+ else {
+ if (varargs.size() != other.varargs.size())
+ return true;
+
+ for (size_t i = 0; i < varargs.size(); ++i)
+ if (varargs[i] != other.varargs[i])
+ return true;
+ return false;
+ }
+ }
+};
+
+}
+
+namespace {
+ class VISIBILITY_HIDDEN ValueTable {
private:
DenseMap<Value*, uint32_t> valueNumbering;
- std::map<Expression, uint32_t> expressionNumbering;
+ DenseMap<Expression, uint32_t> expressionNumbering;
uint32_t nextValueNumber;
};
}
+namespace llvm {
+template <> struct DenseMapInfo<Expression> {
+ static inline Expression getEmptyKey() {
+ return Expression(Expression::EMPTY);
+ }
+
+ static inline Expression getTombstoneKey() {
+ return Expression(Expression::TOMBSTONE);
+ }
+
+ static unsigned getHashValue(const Expression e) {
+ unsigned hash = e.opcode;
+
+ hash = e.firstVN + hash * 37;
+ hash = e.secondVN + hash * 37;
+ hash = e.thirdVN + hash * 37;
+
+ hash = ((unsigned)((uintptr_t)e.type >> 4) ^
+ (unsigned)((uintptr_t)e.type >> 9)) +
+ hash * 37;
+
+ for (SmallVector<uint32_t, 4>::const_iterator I = e.varargs.begin(),
+ E = e.varargs.end(); I != E; ++I)
+ hash = *I + hash * 37;
+
+ return hash;
+ }
+ static bool isEqual(const Expression &LHS, const Expression &RHS) {
+ return LHS == RHS;
+ }
+ static bool isPod() { return true; }
+};
+}
+
//===----------------------------------------------------------------------===//
// ValueTable Internal Functions
//===----------------------------------------------------------------------===//
-ValueTable::Expression::ExpressionOpcode
+Expression::ExpressionOpcode
ValueTable::getOpcode(BinaryOperator* BO) {
switch(BO->getOpcode()) {
case Instruction::Add:
}
}
-ValueTable::Expression::ExpressionOpcode ValueTable::getOpcode(CmpInst* C) {
+Expression::ExpressionOpcode ValueTable::getOpcode(CmpInst* C) {
if (C->getOpcode() == Instruction::ICmp) {
switch (C->getPredicate()) {
case ICmpInst::ICMP_EQ:
}
}
-ValueTable::Expression::ExpressionOpcode
+Expression::ExpressionOpcode
ValueTable::getOpcode(CastInst* C) {
switch(C->getOpcode()) {
case Instruction::Trunc:
}
}
-ValueTable::Expression ValueTable::create_expression(BinaryOperator* BO) {
+Expression ValueTable::create_expression(BinaryOperator* BO) {
Expression e;
e.firstVN = lookup_or_add(BO->getOperand(0));
return e;
}
-ValueTable::Expression ValueTable::create_expression(CmpInst* C) {
+Expression ValueTable::create_expression(CmpInst* C) {
Expression e;
e.firstVN = lookup_or_add(C->getOperand(0));
return e;
}
-ValueTable::Expression ValueTable::create_expression(CastInst* C) {
+Expression ValueTable::create_expression(CastInst* C) {
Expression e;
e.firstVN = lookup_or_add(C->getOperand(0));
return e;
}
-ValueTable::Expression ValueTable::create_expression(ShuffleVectorInst* S) {
+Expression ValueTable::create_expression(ShuffleVectorInst* S) {
Expression e;
e.firstVN = lookup_or_add(S->getOperand(0));
return e;
}
-ValueTable::Expression ValueTable::create_expression(ExtractElementInst* E) {
+Expression ValueTable::create_expression(ExtractElementInst* E) {
Expression e;
e.firstVN = lookup_or_add(E->getOperand(0));
return e;
}
-ValueTable::Expression ValueTable::create_expression(InsertElementInst* I) {
+Expression ValueTable::create_expression(InsertElementInst* I) {
Expression e;
e.firstVN = lookup_or_add(I->getOperand(0));
return e;
}
-ValueTable::Expression ValueTable::create_expression(SelectInst* I) {
+Expression ValueTable::create_expression(SelectInst* I) {
Expression e;
e.firstVN = lookup_or_add(I->getCondition());
return e;
}
-ValueTable::Expression ValueTable::create_expression(GetElementPtrInst* G) {
+Expression ValueTable::create_expression(GetElementPtrInst* G) {
Expression e;
e.firstVN = lookup_or_add(G->getPointerOperand());
e.secondVN = 0;
e.thirdVN = 0;
e.type = G->getType();
- e.opcode = Expression::SELECT;
+ e.opcode = Expression::GEP;
for (GetElementPtrInst::op_iterator I = G->idx_begin(), E = G->idx_end();
I != E; ++I)
if (BinaryOperator* BO = dyn_cast<BinaryOperator>(V)) {
Expression e = create_expression(BO);
- std::map<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
+ DenseMap<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
if (EI != expressionNumbering.end()) {
valueNumbering.insert(std::make_pair(V, EI->second));
return EI->second;
} else if (CmpInst* C = dyn_cast<CmpInst>(V)) {
Expression e = create_expression(C);
- std::map<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
+ DenseMap<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
if (EI != expressionNumbering.end()) {
valueNumbering.insert(std::make_pair(V, EI->second));
return EI->second;
} else if (ShuffleVectorInst* U = dyn_cast<ShuffleVectorInst>(V)) {
Expression e = create_expression(U);
- std::map<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
+ DenseMap<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
if (EI != expressionNumbering.end()) {
valueNumbering.insert(std::make_pair(V, EI->second));
return EI->second;
} else if (ExtractElementInst* U = dyn_cast<ExtractElementInst>(V)) {
Expression e = create_expression(U);
- std::map<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
+ DenseMap<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
if (EI != expressionNumbering.end()) {
valueNumbering.insert(std::make_pair(V, EI->second));
return EI->second;
} else if (InsertElementInst* U = dyn_cast<InsertElementInst>(V)) {
Expression e = create_expression(U);
- std::map<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
+ DenseMap<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
if (EI != expressionNumbering.end()) {
valueNumbering.insert(std::make_pair(V, EI->second));
return EI->second;
} else if (SelectInst* U = dyn_cast<SelectInst>(V)) {
Expression e = create_expression(U);
- std::map<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
+ DenseMap<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
if (EI != expressionNumbering.end()) {
valueNumbering.insert(std::make_pair(V, EI->second));
return EI->second;
} else if (CastInst* U = dyn_cast<CastInst>(V)) {
Expression e = create_expression(U);
- std::map<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
+ DenseMap<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
if (EI != expressionNumbering.end()) {
valueNumbering.insert(std::make_pair(V, EI->second));
return EI->second;
} else if (GetElementPtrInst* U = dyn_cast<GetElementPtrInst>(V)) {
Expression e = create_expression(U);
- std::map<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
+ DenseMap<Expression, uint32_t>::iterator EI = expressionNumbering.find(e);
if (EI != expressionNumbering.end()) {
valueNumbering.insert(std::make_pair(V, EI->second));
return EI->second;
return nextValueNumber;
}
+namespace {
+
+//===----------------------------------------------------------------------===//
+// ValueNumberedSet Class
+//===----------------------------------------------------------------------===//
+
+class ValueNumberedSet {
+ private:
+ SmallPtrSet<Value*, 8> contents;
+ BitVector numbers;
+ public:
+ ValueNumberedSet() { numbers.resize(1); }
+ ValueNumberedSet(const ValueNumberedSet& other) {
+ numbers = other.numbers;
+ contents = other.contents;
+ }
+
+ typedef SmallPtrSet<Value*, 8>::iterator iterator;
+
+ iterator begin() { return contents.begin(); }
+ iterator end() { return contents.end(); }
+
+ bool insert(Value* v) { return contents.insert(v); }
+ void insert(iterator I, iterator E) { contents.insert(I, E); }
+ void erase(Value* v) { contents.erase(v); }
+ unsigned count(Value* v) { return contents.count(v); }
+ size_t size() { return contents.size(); }
+
+ void set(unsigned i) {
+ if (i >= numbers.size())
+ numbers.resize(i+1);
+
+ numbers.set(i);
+ }
+
+ void operator=(const ValueNumberedSet& other) {
+ contents = other.contents;
+ numbers = other.numbers;
+ }
+
+ void reset(unsigned i) {
+ if (i < numbers.size())
+ numbers.reset(i);
+ }
+
+ bool test(unsigned i) {
+ if (i >= numbers.size())
+ return false;
+
+ return numbers.test(i);
+ }
+
+ void clear() {
+ contents.clear();
+ numbers.clear();
+ }
+};
+
+}
+
//===----------------------------------------------------------------------===//
// GVNPRE Pass
//===----------------------------------------------------------------------===//
private:
ValueTable VN;
- std::vector<Instruction*> createdExpressions;
+ SmallVector<Instruction*, 8> createdExpressions;
- std::map<BasicBlock*, SmallPtrSet<Value*, 16> > availableOut;
- std::map<BasicBlock*, SmallPtrSet<Value*, 16> > anticipatedIn;
+ DenseMap<BasicBlock*, ValueNumberedSet> availableOut;
+ DenseMap<BasicBlock*, ValueNumberedSet> anticipatedIn;
+ DenseMap<BasicBlock*, ValueNumberedSet> generatedPhis;
// This transformation requires dominator postdominator info
virtual void getAnalysisUsage(AnalysisUsage &AU) const {
AU.setPreservesCFG();
+ AU.addRequiredID(BreakCriticalEdgesID);
+ AU.addRequired<UnifyFunctionExitNodes>();
AU.addRequired<DominatorTree>();
}
// Helper fuctions
// FIXME: eliminate or document these better
- void dump(const SmallPtrSet<Value*, 16>& s) const;
- void clean(SmallPtrSet<Value*, 16>& set, BitVector& presentInSet);
- Value* find_leader(SmallPtrSet<Value*, 16>& vals,
- uint32_t v);
- Value* phi_translate(Value* V, BasicBlock* pred, BasicBlock* succ);
- void phi_translate_set(SmallPtrSet<Value*, 16>& anticIn, BasicBlock* pred,
- BasicBlock* succ, SmallPtrSet<Value*, 16>& out);
-
- void topo_sort(SmallPtrSet<Value*, 16>& set,
- std::vector<Value*>& vec);
-
- void cleanup();
- bool elimination();
-
- void val_insert(SmallPtrSet<Value*, 16>& s, Value* v);
- void val_replace(SmallPtrSet<Value*, 16>& s, Value* v);
- bool dependsOnInvoke(Value* V);
+ void dump(ValueNumberedSet& s) const ;
+ void clean(ValueNumberedSet& set) ;
+ Value* find_leader(ValueNumberedSet& vals, uint32_t v) ;
+ Value* phi_translate(Value* V, BasicBlock* pred, BasicBlock* succ) ;
+ void phi_translate_set(ValueNumberedSet& anticIn, BasicBlock* pred,
+ BasicBlock* succ, ValueNumberedSet& out) ;
+
+ void topo_sort(ValueNumberedSet& set,
+ SmallVector<Value*, 8>& vec) ;
+
+ void cleanup() ;
+ bool elimination() ;
+
+ void val_insert(ValueNumberedSet& s, Value* v) ;
+ void val_replace(ValueNumberedSet& s, Value* v) ;
+ bool dependsOnInvoke(Value* V) ;
void buildsets_availout(BasicBlock::iterator I,
- SmallPtrSet<Value*, 16>& currAvail,
- SmallPtrSet<PHINode*, 16>& currPhis,
- SmallPtrSet<Value*, 16>& currExps,
- SmallPtrSet<Value*, 16>& currTemps,
- BitVector& availNumbers,
- BitVector& expNumbers);
+ ValueNumberedSet& currAvail,
+ ValueNumberedSet& currPhis,
+ ValueNumberedSet& currExps,
+ SmallPtrSet<Value*, 16>& currTemps);
bool buildsets_anticout(BasicBlock* BB,
- SmallPtrSet<Value*, 16>& anticOut,
- std::set<BasicBlock*>& visited);
+ ValueNumberedSet& anticOut,
+ SmallPtrSet<BasicBlock*, 8>& visited);
unsigned buildsets_anticin(BasicBlock* BB,
- SmallPtrSet<Value*, 16>& anticOut,
- SmallPtrSet<Value*, 16>& currExps,
+ ValueNumberedSet& anticOut,
+ ValueNumberedSet& currExps,
SmallPtrSet<Value*, 16>& currTemps,
- std::set<BasicBlock*>& visited);
- void buildsets(Function& F);
+ SmallPtrSet<BasicBlock*, 8>& visited);
+ void buildsets(Function& F) ;
void insertion_pre(Value* e, BasicBlock* BB,
- std::map<BasicBlock*, Value*>& avail,
- SmallPtrSet<Value*, 16>& new_set);
- unsigned insertion_mergepoint(std::vector<Value*>& workList,
+ DenseMap<BasicBlock*, Value*>& avail,
+ std::map<BasicBlock*,ValueNumberedSet>& new_set);
+ unsigned insertion_mergepoint(SmallVector<Value*, 8>& workList,
df_iterator<DomTreeNode*>& D,
- SmallPtrSet<Value*, 16>& new_set);
- bool insertion(Function& F);
+ std::map<BasicBlock*, ValueNumberedSet>& new_set);
+ bool insertion(Function& F) ;
};
// createGVNPREPass - The public interface to this file...
FunctionPass *llvm::createGVNPREPass() { return new GVNPRE(); }
-RegisterPass<GVNPRE> X("gvnpre",
- "Global Value Numbering/Partial Redundancy Elimination");
+static RegisterPass<GVNPRE> X("gvnpre",
+ "Global Value Numbering/Partial Redundancy Elimination");
STATISTIC(NumInsertedVals, "Number of values inserted");
/// find_leader - Given a set and a value number, return the first
/// element of the set with that value number, or 0 if no such element
/// is present
-Value* GVNPRE::find_leader(SmallPtrSet<Value*, 16>& vals, uint32_t v) {
- for (SmallPtrSet<Value*, 16>::iterator I = vals.begin(), E = vals.end();
+Value* GVNPRE::find_leader(ValueNumberedSet& vals, uint32_t v) {
+ if (!vals.test(v))
+ return 0;
+
+ for (ValueNumberedSet::iterator I = vals.begin(), E = vals.end();
I != E; ++I)
if (v == VN.lookup(*I))
return *I;
+ assert(0 && "No leader found, but present bit is set?");
return 0;
}
/// val_insert - Insert a value into a set only if there is not a value
/// with the same value number already in the set
-void GVNPRE::val_insert(SmallPtrSet<Value*, 16>& s, Value* v) {
+void GVNPRE::val_insert(ValueNumberedSet& s, Value* v) {
uint32_t num = VN.lookup(v);
- Value* leader = find_leader(s, num);
- if (leader == 0)
+ if (!s.test(num))
s.insert(v);
}
/// val_replace - Insert a value into a set, replacing any values already in
/// the set that have the same value number
-void GVNPRE::val_replace(SmallPtrSet<Value*, 16>& s, Value* v) {
+void GVNPRE::val_replace(ValueNumberedSet& s, Value* v) {
+ if (s.count(v)) return;
+
uint32_t num = VN.lookup(v);
Value* leader = find_leader(s, num);
- while (leader != 0) {
+ if (leader != 0)
s.erase(leader);
- leader = find_leader(s, num);
- }
s.insert(v);
+ s.set(num);
}
/// phi_translate - Given a value, its parent block, and a predecessor of its
newVal = new ShuffleVectorInst(newOp1, newOp2, newOp3,
S->getName()+".expr");
else if (InsertElementInst* I = dyn_cast<InsertElementInst>(U))
- newVal = new InsertElementInst(newOp1, newOp2, newOp3,
- I->getName()+".expr");
+ newVal = InsertElementInst::Create(newOp1, newOp2, newOp3,
+ I->getName()+".expr");
else if (SelectInst* I = dyn_cast<SelectInst>(U))
- newVal = new SelectInst(newOp1, newOp2, newOp3, I->getName()+".expr");
+ newVal = SelectInst::Create(newOp1, newOp2, newOp3, I->getName()+".expr");
uint32_t v = VN.lookup_or_add(newVal);
return 0;
bool changed_idx = false;
- std::vector<Value*> newIdx;
+ SmallVector<Value*, 4> newIdx;
for (GetElementPtrInst::op_iterator I = U->idx_begin(), E = U->idx_end();
I != E; ++I)
if (isa<Instruction>(*I)) {
}
if (newOp1 != U->getPointerOperand() || changed_idx) {
- Instruction* newVal = new GetElementPtrInst(U->getPointerOperand(),
- &newIdx[0], newIdx.size(),
- U->getName()+".expr");
+ Instruction* newVal =
+ GetElementPtrInst::Create(newOp1,
+ newIdx.begin(), newIdx.end(),
+ U->getName()+".expr");
uint32_t v = VN.lookup_or_add(newVal);
}
/// phi_translate_set - Perform phi translation on every element of a set
-void GVNPRE::phi_translate_set(SmallPtrSet<Value*, 16>& anticIn,
+void GVNPRE::phi_translate_set(ValueNumberedSet& anticIn,
BasicBlock* pred, BasicBlock* succ,
- SmallPtrSet<Value*, 16>& out) {
- for (SmallPtrSet<Value*, 16>::iterator I = anticIn.begin(),
+ ValueNumberedSet& out) {
+ for (ValueNumberedSet::iterator I = anticIn.begin(),
E = anticIn.end(); I != E; ++I) {
Value* V = phi_translate(*I, pred, succ);
- if (V != 0)
+ if (V != 0 && !out.test(VN.lookup_or_add(V))) {
out.insert(V);
+ out.set(VN.lookup(V));
+ }
}
}
/// clean - Remove all non-opaque values from the set whose operands are not
/// themselves in the set, as well as all values that depend on invokes (see
/// above)
-void GVNPRE::clean(SmallPtrSet<Value*, 16>& set, BitVector& presentInSet) {
- std::vector<Value*> worklist;
+void GVNPRE::clean(ValueNumberedSet& set) {
+ SmallVector<Value*, 8> worklist;
worklist.reserve(set.size());
topo_sort(set, worklist);
// Handle unary ops
if (CastInst* U = dyn_cast<CastInst>(v)) {
bool lhsValid = !isa<Instruction>(U->getOperand(0));
- lhsValid |= presentInSet.test(VN.lookup(U->getOperand(0)));
+ lhsValid |= set.test(VN.lookup(U->getOperand(0)));
if (lhsValid)
lhsValid = !dependsOnInvoke(U->getOperand(0));
if (!lhsValid) {
set.erase(U);
- presentInSet.flip(VN.lookup(U));
+ set.reset(VN.lookup(U));
}
// Handle binary ops
User* U = cast<User>(v);
bool lhsValid = !isa<Instruction>(U->getOperand(0));
- lhsValid |= presentInSet.test(VN.lookup(U->getOperand(0)));
+ lhsValid |= set.test(VN.lookup(U->getOperand(0)));
if (lhsValid)
lhsValid = !dependsOnInvoke(U->getOperand(0));
bool rhsValid = !isa<Instruction>(U->getOperand(1));
- rhsValid |= presentInSet.test(VN.lookup(U->getOperand(1)));
+ rhsValid |= set.test(VN.lookup(U->getOperand(1)));
if (rhsValid)
rhsValid = !dependsOnInvoke(U->getOperand(1));
if (!lhsValid || !rhsValid) {
set.erase(U);
- presentInSet.flip(VN.lookup(U));
+ set.reset(VN.lookup(U));
}
// Handle ternary ops
User* U = cast<User>(v);
bool lhsValid = !isa<Instruction>(U->getOperand(0));
- lhsValid |= presentInSet.test(VN.lookup(U->getOperand(0)));
+ lhsValid |= set.test(VN.lookup(U->getOperand(0)));
if (lhsValid)
lhsValid = !dependsOnInvoke(U->getOperand(0));
bool rhsValid = !isa<Instruction>(U->getOperand(1));
- rhsValid |= presentInSet.test(VN.lookup(U->getOperand(1)));
+ rhsValid |= set.test(VN.lookup(U->getOperand(1)));
if (rhsValid)
rhsValid = !dependsOnInvoke(U->getOperand(1));
bool thirdValid = !isa<Instruction>(U->getOperand(2));
- thirdValid |= presentInSet.test(VN.lookup(U->getOperand(2)));
+ thirdValid |= set.test(VN.lookup(U->getOperand(2)));
if (thirdValid)
thirdValid = !dependsOnInvoke(U->getOperand(2));
if (!lhsValid || !rhsValid || !thirdValid) {
set.erase(U);
- presentInSet.flip(VN.lookup(U));
+ set.reset(VN.lookup(U));
}
// Handle varargs ops
} else if (GetElementPtrInst* U = dyn_cast<GetElementPtrInst>(v)) {
bool ptrValid = !isa<Instruction>(U->getPointerOperand());
- ptrValid |= presentInSet.test(VN.lookup(U->getPointerOperand()));
+ ptrValid |= set.test(VN.lookup(U->getPointerOperand()));
if (ptrValid)
ptrValid = !dependsOnInvoke(U->getPointerOperand());
for (GetElementPtrInst::op_iterator I = U->idx_begin(), E = U->idx_end();
I != E; ++I)
if (varValid) {
- varValid &= !isa<Instruction>(*I) || presentInSet.test(VN.lookup(*I));
+ varValid &= !isa<Instruction>(*I) || set.test(VN.lookup(*I));
varValid &= !dependsOnInvoke(*I);
}
if (!ptrValid || !varValid) {
set.erase(U);
- presentInSet.flip(VN.lookup(U));
+ set.reset(VN.lookup(U));
}
}
}
/// topo_sort - Given a set of values, sort them by topological
/// order into the provided vector.
-void GVNPRE::topo_sort(SmallPtrSet<Value*, 16>& set, std::vector<Value*>& vec) {
+void GVNPRE::topo_sort(ValueNumberedSet& set, SmallVector<Value*, 8>& vec) {
SmallPtrSet<Value*, 16> visited;
- std::vector<Value*> stack;
- for (SmallPtrSet<Value*, 16>::iterator I = set.begin(), E = set.end();
+ SmallVector<Value*, 8> stack;
+ for (ValueNumberedSet::iterator I = set.begin(), E = set.end();
I != E; ++I) {
if (visited.count(*I) == 0)
stack.push_back(*I);
stack.push_back(r);
else if (m != 0 && isa<Instruction>(m) &&
visited.count(m) == 0)
- stack.push_back(r);
+ stack.push_back(m);
else {
vec.push_back(e);
visited.insert(e);
}
/// dump - Dump a set of values to standard error
-void GVNPRE::dump(const SmallPtrSet<Value*, 16>& s) const {
+void GVNPRE::dump(ValueNumberedSet& s) const {
DOUT << "{ ";
- for (SmallPtrSet<Value*, 16>::iterator I = s.begin(), E = s.end();
+ for (ValueNumberedSet::iterator I = s.begin(), E = s.end();
I != E; ++I) {
DOUT << "" << VN.lookup(*I) << ": ";
DEBUG((*I)->dump());
/// elimination by walking the dominator tree and removing any instruction that
/// is dominated by another instruction with the same value number.
bool GVNPRE::elimination() {
- DOUT << "\n\nPhase 3: Elimination\n\n";
-
bool changed_function = false;
- std::vector<std::pair<Instruction*, Value*> > replace;
- std::vector<Instruction*> erase;
+ SmallVector<std::pair<Instruction*, Value*>, 8> replace;
+ SmallVector<Instruction*, 8> erase;
DominatorTree& DT = getAnalysis<DominatorTree>();
E = df_end(DT.getRootNode()); DI != E; ++DI) {
BasicBlock* BB = DI->getBlock();
- //DOUT << "Block: " << BB->getName() << "\n";
- //dump(availableOut[BB]);
- //DOUT << "\n\n";
-
for (BasicBlock::iterator BI = BB->begin(), BE = BB->end();
BI != BE; ++BI) {
isa<ShuffleVectorInst>(BI) || isa<InsertElementInst>(BI) ||
isa<ExtractElementInst>(BI) || isa<SelectInst>(BI) ||
isa<CastInst>(BI) || isa<GetElementPtrInst>(BI)) {
- Value *leader = find_leader(availableOut[BB], VN.lookup(BI));
-
- if (leader != 0)
+
+ if (availableOut[BB].test(VN.lookup(BI)) &&
+ !availableOut[BB].count(BI)) {
+ Value *leader = find_leader(availableOut[BB], VN.lookup(BI));
if (Instruction* Instr = dyn_cast<Instruction>(leader))
if (Instr->getParent() != 0 && Instr != BI) {
replace.push_back(std::make_pair(BI, leader));
erase.push_back(BI);
++NumEliminated;
}
+ }
}
}
}
changed_function = true;
}
- for (std::vector<Instruction*>::iterator I = erase.begin(), E = erase.end();
- I != E; ++I)
+ for (SmallVector<Instruction*, 8>::iterator I = erase.begin(),
+ E = erase.end(); I != E; ++I)
(*I)->eraseFromParent();
return changed_function;
/// buildsets_availout - When calculating availability, handle an instruction
/// by inserting it into the appropriate sets
void GVNPRE::buildsets_availout(BasicBlock::iterator I,
- SmallPtrSet<Value*, 16>& currAvail,
- SmallPtrSet<PHINode*, 16>& currPhis,
- SmallPtrSet<Value*, 16>& currExps,
- SmallPtrSet<Value*, 16>& currTemps,
- BitVector& availNumbers,
- BitVector& expNumbers) {
+ ValueNumberedSet& currAvail,
+ ValueNumberedSet& currPhis,
+ ValueNumberedSet& currExps,
+ SmallPtrSet<Value*, 16>& currTemps) {
// Handle PHI nodes
if (PHINode* p = dyn_cast<PHINode>(I)) {
- VN.lookup_or_add(p);
- expNumbers.resize(VN.size());
- availNumbers.resize(VN.size());
+ unsigned num = VN.lookup_or_add(p);
currPhis.insert(p);
+ currPhis.set(num);
// Handle unary ops
} else if (CastInst* U = dyn_cast<CastInst>(I)) {
Value* leftValue = U->getOperand(0);
unsigned num = VN.lookup_or_add(U);
- expNumbers.resize(VN.size());
- availNumbers.resize(VN.size());
if (isa<Instruction>(leftValue))
- if (!expNumbers.test(VN.lookup(leftValue))) {
+ if (!currExps.test(VN.lookup(leftValue))) {
currExps.insert(leftValue);
- expNumbers.set(VN.lookup(leftValue));
+ currExps.set(VN.lookup(leftValue));
}
- if (!expNumbers.test(VN.lookup(U))) {
+ if (!currExps.test(num)) {
currExps.insert(U);
- expNumbers.set(num);
+ currExps.set(num);
}
// Handle binary ops
Value* rightValue = U->getOperand(1);
unsigned num = VN.lookup_or_add(U);
- expNumbers.resize(VN.size());
- availNumbers.resize(VN.size());
if (isa<Instruction>(leftValue))
- if (!expNumbers.test(VN.lookup(leftValue))) {
+ if (!currExps.test(VN.lookup(leftValue))) {
currExps.insert(leftValue);
- expNumbers.set(VN.lookup(leftValue));
+ currExps.set(VN.lookup(leftValue));
}
if (isa<Instruction>(rightValue))
- if (!expNumbers.test(VN.lookup(rightValue))) {
+ if (!currExps.test(VN.lookup(rightValue))) {
currExps.insert(rightValue);
- expNumbers.set(VN.lookup(rightValue));
+ currExps.set(VN.lookup(rightValue));
}
- if (!expNumbers.test(VN.lookup(U))) {
+ if (!currExps.test(num)) {
currExps.insert(U);
- expNumbers.set(num);
+ currExps.set(num);
}
// Handle ternary ops
VN.lookup_or_add(U);
unsigned num = VN.lookup_or_add(U);
- expNumbers.resize(VN.size());
- availNumbers.resize(VN.size());
if (isa<Instruction>(leftValue))
- if (!expNumbers.test(VN.lookup(leftValue))) {
+ if (!currExps.test(VN.lookup(leftValue))) {
currExps.insert(leftValue);
- expNumbers.set(VN.lookup(leftValue));
+ currExps.set(VN.lookup(leftValue));
}
if (isa<Instruction>(rightValue))
- if (!expNumbers.test(VN.lookup(rightValue))) {
+ if (!currExps.test(VN.lookup(rightValue))) {
currExps.insert(rightValue);
- expNumbers.set(VN.lookup(rightValue));
+ currExps.set(VN.lookup(rightValue));
}
if (isa<Instruction>(thirdValue))
- if (!expNumbers.test(VN.lookup(thirdValue))) {
+ if (!currExps.test(VN.lookup(thirdValue))) {
currExps.insert(thirdValue);
- expNumbers.set(VN.lookup(thirdValue));
+ currExps.set(VN.lookup(thirdValue));
}
- if (!expNumbers.test(VN.lookup(U))) {
+ if (!currExps.test(num)) {
currExps.insert(U);
- expNumbers.set(num);
+ currExps.set(num);
}
// Handle vararg ops
VN.lookup_or_add(U);
unsigned num = VN.lookup_or_add(U);
- expNumbers.resize(VN.size());
- availNumbers.resize(VN.size());
if (isa<Instruction>(ptrValue))
- if (!expNumbers.test(VN.lookup(ptrValue))) {
+ if (!currExps.test(VN.lookup(ptrValue))) {
currExps.insert(ptrValue);
- expNumbers.set(VN.lookup(ptrValue));
+ currExps.set(VN.lookup(ptrValue));
}
for (GetElementPtrInst::op_iterator OI = U->idx_begin(), OE = U->idx_end();
OI != OE; ++OI)
- if (isa<Instruction>(*OI) && !expNumbers.test(VN.lookup(*OI))) {
+ if (isa<Instruction>(*OI) && !currExps.test(VN.lookup(*OI))) {
currExps.insert(*OI);
- expNumbers.set(VN.lookup(*OI));
+ currExps.set(VN.lookup(*OI));
}
- if (!expNumbers.test(VN.lookup(U))) {
+ if (!currExps.test(VN.lookup(U))) {
currExps.insert(U);
- expNumbers.set(num);
+ currExps.set(num);
}
// Handle opaque ops
} else if (!I->isTerminator()){
VN.lookup_or_add(I);
- expNumbers.resize(VN.size());
- availNumbers.resize(VN.size());
currTemps.insert(I);
}
if (!I->isTerminator())
- if (!availNumbers.test(VN.lookup(I))) {
+ if (!currAvail.test(VN.lookup(I))) {
currAvail.insert(I);
- availNumbers.set(VN.lookup(I));
+ currAvail.set(VN.lookup(I));
}
}
/// buildsets_anticout - When walking the postdom tree, calculate the ANTIC_OUT
/// set as a function of the ANTIC_IN set of the block's predecessors
bool GVNPRE::buildsets_anticout(BasicBlock* BB,
- SmallPtrSet<Value*, 16>& anticOut,
- std::set<BasicBlock*>& visited) {
+ ValueNumberedSet& anticOut,
+ SmallPtrSet<BasicBlock*, 8>& visited) {
if (BB->getTerminator()->getNumSuccessors() == 1) {
if (BB->getTerminator()->getSuccessor(0) != BB &&
visited.count(BB->getTerminator()->getSuccessor(0)) == 0) {
- DOUT << "DEFER: " << BB->getName() << "\n";
return true;
}
else {
}
} else if (BB->getTerminator()->getNumSuccessors() > 1) {
BasicBlock* first = BB->getTerminator()->getSuccessor(0);
- anticOut.insert(anticipatedIn[first].begin(), anticipatedIn[first].end());
+ for (ValueNumberedSet::iterator I = anticipatedIn[first].begin(),
+ E = anticipatedIn[first].end(); I != E; ++I) {
+ anticOut.insert(*I);
+ anticOut.set(VN.lookup(*I));
+ }
for (unsigned i = 1; i < BB->getTerminator()->getNumSuccessors(); ++i) {
BasicBlock* currSucc = BB->getTerminator()->getSuccessor(i);
- SmallPtrSet<Value*, 16>& succAnticIn = anticipatedIn[currSucc];
+ ValueNumberedSet& succAnticIn = anticipatedIn[currSucc];
- std::vector<Value*> temp;
+ SmallVector<Value*, 16> temp;
- for (SmallPtrSet<Value*, 16>::iterator I = anticOut.begin(),
+ for (ValueNumberedSet::iterator I = anticOut.begin(),
E = anticOut.end(); I != E; ++I)
- if (succAnticIn.count(*I) == 0)
+ if (!succAnticIn.test(VN.lookup(*I)))
temp.push_back(*I);
- for (std::vector<Value*>::iterator I = temp.begin(), E = temp.end();
- I != E; ++I)
+ for (SmallVector<Value*, 16>::iterator I = temp.begin(), E = temp.end();
+ I != E; ++I) {
anticOut.erase(*I);
+ anticOut.reset(VN.lookup(*I));
+ }
}
}
/// each block. ANTIC_IN is then a function of ANTIC_OUT and the GEN
/// sets populated in buildsets_availout
unsigned GVNPRE::buildsets_anticin(BasicBlock* BB,
- SmallPtrSet<Value*, 16>& anticOut,
- SmallPtrSet<Value*, 16>& currExps,
+ ValueNumberedSet& anticOut,
+ ValueNumberedSet& currExps,
SmallPtrSet<Value*, 16>& currTemps,
- std::set<BasicBlock*>& visited) {
- SmallPtrSet<Value*, 16>& anticIn = anticipatedIn[BB];
+ SmallPtrSet<BasicBlock*, 8>& visited) {
+ ValueNumberedSet& anticIn = anticipatedIn[BB];
unsigned old = anticIn.size();
bool defer = buildsets_anticout(BB, anticOut, visited);
anticIn.clear();
- BitVector numbers(VN.size());
- for (SmallPtrSet<Value*, 16>::iterator I = anticOut.begin(),
+ for (ValueNumberedSet::iterator I = anticOut.begin(),
E = anticOut.end(); I != E; ++I) {
- unsigned num = VN.lookup_or_add(*I);
- numbers.resize(VN.size());
-
- if (isa<Instruction>(*I)) {
- anticIn.insert(*I);
- numbers.set(num);
- }
+ anticIn.insert(*I);
+ anticIn.set(VN.lookup(*I));
}
- for (SmallPtrSet<Value*, 16>::iterator I = currExps.begin(),
+ for (ValueNumberedSet::iterator I = currExps.begin(),
E = currExps.end(); I != E; ++I) {
- if (!numbers.test(VN.lookup_or_add(*I))) {
+ if (!anticIn.test(VN.lookup(*I))) {
anticIn.insert(*I);
- numbers.set(VN.lookup(*I));
+ anticIn.set(VN.lookup(*I));
}
}
for (SmallPtrSet<Value*, 16>::iterator I = currTemps.begin(),
E = currTemps.end(); I != E; ++I) {
anticIn.erase(*I);
- numbers.flip(VN.lookup(*I));
+ anticIn.reset(VN.lookup(*I));
}
- clean(anticIn, numbers);
+ clean(anticIn);
anticOut.clear();
if (old != anticIn.size())
/// buildsets - Phase 1 of the main algorithm. Construct the AVAIL_OUT
/// and the ANTIC_IN sets.
void GVNPRE::buildsets(Function& F) {
- std::map<BasicBlock*, SmallPtrSet<Value*, 16> > generatedExpressions;
- std::map<BasicBlock*, SmallPtrSet<PHINode*, 16> > generatedPhis;
- std::map<BasicBlock*, SmallPtrSet<Value*, 16> > generatedTemporaries;
+ DenseMap<BasicBlock*, ValueNumberedSet> generatedExpressions;
+ DenseMap<BasicBlock*, SmallPtrSet<Value*, 16> > generatedTemporaries;
DominatorTree &DT = getAnalysis<DominatorTree>();
E = df_end(DT.getRootNode()); DI != E; ++DI) {
// Get the sets to update for this block
- SmallPtrSet<Value*, 16>& currExps = generatedExpressions[DI->getBlock()];
- SmallPtrSet<PHINode*, 16>& currPhis = generatedPhis[DI->getBlock()];
+ ValueNumberedSet& currExps = generatedExpressions[DI->getBlock()];
+ ValueNumberedSet& currPhis = generatedPhis[DI->getBlock()];
SmallPtrSet<Value*, 16>& currTemps = generatedTemporaries[DI->getBlock()];
- SmallPtrSet<Value*, 16>& currAvail = availableOut[DI->getBlock()];
+ ValueNumberedSet& currAvail = availableOut[DI->getBlock()];
BasicBlock* BB = DI->getBlock();
// A block inherits AVAIL_OUT from its dominator
if (DI->getIDom() != 0)
- currAvail.insert(availableOut[DI->getIDom()->getBlock()].begin(),
- availableOut[DI->getIDom()->getBlock()].end());
-
- BitVector availNumbers(VN.size());
- for (SmallPtrSet<Value*, 16>::iterator I = currAvail.begin(),
- E = currAvail.end(); I != E; ++I)
- availNumbers.set(VN.lookup(*I));
-
- BitVector expNumbers(VN.size());
+ currAvail = availableOut[DI->getIDom()->getBlock()];
+
for (BasicBlock::iterator BI = BB->begin(), BE = BB->end();
BI != BE; ++BI)
buildsets_availout(BI, currAvail, currPhis, currExps,
- currTemps, availNumbers, expNumbers);
+ currTemps);
}
// Phase 1, Part 2: calculate ANTIC_IN
- std::set<BasicBlock*> visited;
+ SmallPtrSet<BasicBlock*, 8> visited;
SmallPtrSet<BasicBlock*, 4> block_changed;
for (Function::iterator FI = F.begin(), FE = F.end(); FI != FE; ++FI)
block_changed.insert(FI);
while (changed) {
changed = false;
- SmallPtrSet<Value*, 16> anticOut;
+ ValueNumberedSet anticOut;
// Postorder walk of the CFG
for (po_iterator<BasicBlock*> BBI = po_begin(&F.getEntryBlock()),
iterations++;
}
-
- DOUT << "ITERATIONS: " << iterations << "\n";
}
/// insertion_pre - When a partial redundancy has been identified, eliminate it
/// by inserting appropriate values into the predecessors and a phi node in
/// the main block
void GVNPRE::insertion_pre(Value* e, BasicBlock* BB,
- std::map<BasicBlock*, Value*>& avail,
- SmallPtrSet<Value*, 16>& new_set) {
+ DenseMap<BasicBlock*, Value*>& avail,
+ std::map<BasicBlock*, ValueNumberedSet>& new_sets) {
for (pred_iterator PI = pred_begin(BB), PE = pred_end(BB); PI != PE; ++PI) {
Value* e2 = avail[*PI];
- if (!find_leader(availableOut[*PI], VN.lookup(e2))) {
+ if (!availableOut[*PI].test(VN.lookup(e2))) {
User* U = cast<User>(e2);
Value* s1 = 0;
isa<ShuffleVectorInst>(U) ||
isa<ExtractElementInst>(U) ||
isa<InsertElementInst>(U) ||
- isa<SelectInst>(U))
+ isa<SelectInst>(U)) {
if (isa<BinaryOperator>(U->getOperand(1)) ||
isa<CmpInst>(U->getOperand(1)) ||
isa<ShuffleVectorInst>(U->getOperand(1)) ||
} else {
s2 = U->getOperand(1);
}
+ }
// Ternary Operators
Value* s3 = 0;
if (isa<ShuffleVectorInst>(U) ||
isa<InsertElementInst>(U) ||
- isa<SelectInst>(U))
+ isa<SelectInst>(U)) {
if (isa<BinaryOperator>(U->getOperand(2)) ||
isa<CmpInst>(U->getOperand(2)) ||
isa<ShuffleVectorInst>(U->getOperand(2)) ||
} else {
s3 = U->getOperand(2);
}
+ }
// Vararg operators
- std::vector<Value*> sVarargs;
+ SmallVector<Value*, 4> sVarargs;
if (GetElementPtrInst* G = dyn_cast<GetElementPtrInst>(U)) {
for (GetElementPtrInst::op_iterator OI = G->idx_begin(),
OE = G->idx_end(); OI != OE; ++OI) {
newVal = new ShuffleVectorInst(s1, s2, s3, S->getName()+".gvnpre",
(*PI)->getTerminator());
else if (InsertElementInst* S = dyn_cast<InsertElementInst>(U))
- newVal = new InsertElementInst(s1, s2, s3, S->getName()+".gvnpre",
- (*PI)->getTerminator());
+ newVal = InsertElementInst::Create(s1, s2, s3, S->getName()+".gvnpre",
+ (*PI)->getTerminator());
else if (ExtractElementInst* S = dyn_cast<ExtractElementInst>(U))
newVal = new ExtractElementInst(s1, s2, S->getName()+".gvnpre",
(*PI)->getTerminator());
else if (SelectInst* S = dyn_cast<SelectInst>(U))
- newVal = new SelectInst(S->getCondition(), S->getTrueValue(),
- S->getFalseValue(), S->getName()+".gvnpre",
- (*PI)->getTerminator());
+ newVal = SelectInst::Create(s1, s2, s3, S->getName()+".gvnpre",
+ (*PI)->getTerminator());
else if (CastInst* C = dyn_cast<CastInst>(U))
newVal = CastInst::create(C->getOpcode(), s1, C->getType(),
C->getName()+".gvnpre",
(*PI)->getTerminator());
else if (GetElementPtrInst* G = dyn_cast<GetElementPtrInst>(U))
- newVal = new GetElementPtrInst(s1, &sVarargs[0], sVarargs.size(),
- G->getName()+".gvnpre",
- (*PI)->getTerminator());
-
-
+ newVal = GetElementPtrInst::Create(s1, sVarargs.begin(), sVarargs.end(),
+ G->getName()+".gvnpre",
+ (*PI)->getTerminator());
+
VN.add(newVal, VN.lookup(U));
- SmallPtrSet<Value*, 16>& predAvail = availableOut[*PI];
+ ValueNumberedSet& predAvail = availableOut[*PI];
val_replace(predAvail, newVal);
+ val_replace(new_sets[*PI], newVal);
+ predAvail.set(VN.lookup(newVal));
- std::map<BasicBlock*, Value*>::iterator av = avail.find(*PI);
+ DenseMap<BasicBlock*, Value*>::iterator av = avail.find(*PI);
if (av != avail.end())
avail.erase(av);
avail.insert(std::make_pair(*PI, newVal));
for (pred_iterator PI = pred_begin(BB), PE = pred_end(BB); PI != PE; ++PI) {
if (p == 0)
- p = new PHINode(avail[*PI]->getType(), "gvnpre-join", BB->begin());
-
+ p = PHINode::Create(avail[*PI]->getType(), "gvnpre-join", BB->begin());
+
p->addIncoming(avail[*PI], *PI);
}
VN.add(p, VN.lookup(e));
val_replace(availableOut[BB], p);
- new_set.insert(p);
+ availableOut[BB].set(VN.lookup(e));
+ generatedPhis[BB].insert(p);
+ generatedPhis[BB].set(VN.lookup(e));
+ new_sets[BB].insert(p);
+ new_sets[BB].set(VN.lookup(e));
++NumInsertedPhis;
}
/// insertion_mergepoint - When walking the dom tree, check at each merge
/// block for the possibility of a partial redundancy. If present, eliminate it
-unsigned GVNPRE::insertion_mergepoint(std::vector<Value*>& workList,
+unsigned GVNPRE::insertion_mergepoint(SmallVector<Value*, 8>& workList,
df_iterator<DomTreeNode*>& D,
- SmallPtrSet<Value*, 16>& new_set) {
+ std::map<BasicBlock*, ValueNumberedSet >& new_sets) {
bool changed_function = false;
bool new_stuff = false;
isa<ExtractElementInst>(e) || isa<InsertElementInst>(e) ||
isa<ShuffleVectorInst>(e) || isa<SelectInst>(e) || isa<CastInst>(e) ||
isa<GetElementPtrInst>(e)) {
- if (find_leader(availableOut[D->getIDom()->getBlock()],
- VN.lookup(e)) != 0)
+ if (availableOut[D->getIDom()->getBlock()].test(VN.lookup(e)))
continue;
- std::map<BasicBlock*, Value*> avail;
+ DenseMap<BasicBlock*, Value*> avail;
bool by_some = false;
- int num_avail = 0;
+ bool all_same = true;
+ Value * first_s = 0;
for (pred_iterator PI = pred_begin(BB), PE = pred_end(BB); PI != PE;
++PI) {
Value *e3 = find_leader(availableOut[*PI], VN.lookup(e2));
if (e3 == 0) {
- std::map<BasicBlock*, Value*>::iterator av = avail.find(*PI);
+ DenseMap<BasicBlock*, Value*>::iterator av = avail.find(*PI);
if (av != avail.end())
avail.erase(av);
avail.insert(std::make_pair(*PI, e2));
+ all_same = false;
} else {
- std::map<BasicBlock*, Value*>::iterator av = avail.find(*PI);
+ DenseMap<BasicBlock*, Value*>::iterator av = avail.find(*PI);
if (av != avail.end())
avail.erase(av);
avail.insert(std::make_pair(*PI, e3));
by_some = true;
- num_avail++;
+ if (first_s == 0)
+ first_s = e3;
+ else if (first_s != e3)
+ all_same = false;
}
}
- if (by_some && num_avail < std::distance(pred_begin(BB), pred_end(BB))) {
- insertion_pre(e, BB, avail, new_set);
+ if (by_some && !all_same &&
+ !generatedPhis[BB].test(VN.lookup(e))) {
+ insertion_pre(e, BB, avail, new_sets);
changed_function = true;
new_stuff = true;
DominatorTree &DT = getAnalysis<DominatorTree>();
- std::map<BasicBlock*, SmallPtrSet<Value*, 16> > new_sets;
+ std::map<BasicBlock*, ValueNumberedSet> new_sets;
bool new_stuff = true;
while (new_stuff) {
new_stuff = false;
if (BB == 0)
continue;
- SmallPtrSet<Value*, 16>& new_set = new_sets[BB];
- SmallPtrSet<Value*, 16>& availOut = availableOut[BB];
- SmallPtrSet<Value*, 16>& anticIn = anticipatedIn[BB];
-
- new_set.clear();
+ ValueNumberedSet& availOut = availableOut[BB];
+ ValueNumberedSet& anticIn = anticipatedIn[BB];
// Replace leaders with leaders inherited from dominator
if (DI->getIDom() != 0) {
- SmallPtrSet<Value*, 16>& dom_set = new_sets[DI->getIDom()->getBlock()];
- for (SmallPtrSet<Value*, 16>::iterator I = dom_set.begin(),
+ ValueNumberedSet& dom_set = new_sets[DI->getIDom()->getBlock()];
+ for (ValueNumberedSet::iterator I = dom_set.begin(),
E = dom_set.end(); I != E; ++I) {
- new_set.insert(*I);
+ val_replace(new_sets[BB], *I);
val_replace(availOut, *I);
}
}
// If there is more than one predecessor...
if (pred_begin(BB) != pred_end(BB) && ++pred_begin(BB) != pred_end(BB)) {
- std::vector<Value*> workList;
+ SmallVector<Value*, 8> workList;
workList.reserve(anticIn.size());
topo_sort(anticIn, workList);
- unsigned result = insertion_mergepoint(workList, DI, new_set);
+ unsigned result = insertion_mergepoint(workList, DI, new_sets);
if (result & 1)
changed_function = true;
if (result & 2)
createdExpressions.clear();
availableOut.clear();
anticipatedIn.clear();
-
+ generatedPhis.clear();
+
bool changed_function = false;
// Phase 1: BuildSets
// This phase calculates the AVAIL_OUT and ANTIC_IN sets
buildsets(F);
- for (Function::iterator FI = F.begin(), FE = F.end(); FI != FE; ++FI) {
- DOUT << "AVAIL_OUT: " << FI->getName() << "\n";
- dump(availableOut[FI]);
- DOUT << "\n";
- DOUT << "ANTIC_IN: " << FI->getName() << "\n";
- dump(anticipatedIn[FI]);
- DOUT << "\n\n";
- }
-
// Phase 2: Insert
// This phase inserts values to make partially redundant values
// fully redundant