Lower stpcpy_chk when possible.

[oota-llvm.git] / lib / Transforms / Scalar / CodeGenPrepare.cpp

diff --git a/lib/Transforms/Scalar/CodeGenPrepare.cpp b/lib/Transforms/Scalar/CodeGenPrepare.cpp
index f5ccebfdefa9e66cfd66acf0edc3fd9d2148d3d5..c428d2b0b0c08f4f36b5d1100c2cf7495225883a 100644 (file)
--- a/lib/Transforms/Scalar/CodeGenPrepare.cpp
+++ b/lib/Transforms/Scalar/CodeGenPrepare.cpp
@@ -624,11 +624,6 @@ bool CodeGenPrepare::OptimizeCallInst(CallInst *CI) {
     ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(3));
     if (!SizeCI)
       return 0;
-    // If a) we don't have any length information, or b) we know this will
-    // fit then just lower to a plain strcpy. Otherwise we'll keep our
-    // strcpy_chk call which may fail at runtime if the size is too long.
-    // TODO: It might be nice to get a maximum length out of the possible
-    // string lengths for varying.
     if (SizeCI->isAllOnesValue()) {
       Value *Ret = EmitStrCpy(CI->getOperand(1), CI->getOperand(2), B, TD);
       CI->replaceAllUsesWith(Ret);
@@ -638,8 +633,16 @@ bool CodeGenPrepare::OptimizeCallInst(CallInst *CI) {
     return 0;
   }
 
-  // Should be similar to strcpy.
   if (Name == "__stpcpy_chk") {
+    ConstantInt *SizeCI = dyn_cast<ConstantInt>(CI->getOperand(3));
+    if (!SizeCI)
+      return 0;
+    if (SizeCI->isAllOnesValue()) {
+      Value *Ret = EmitStpCpy(CI->getOperand(1), CI->getOperand(2), B, TD);
+      CI->replaceAllUsesWith(Ret);
+      CI->eraseFromParent();
+      return true;
+    }
     return 0;
   }