While Phabricator is a useful tool for some, the relevant -commits mailing list
is the system of record for all LLVM code review. The mailing list should be
-CC'd on all reviews, and Phabricator users should be prepared to respond to
-free-form comments in mail sent to the commits list.
+added as a subscriber on all reviews, and Phabricator users should be prepared
+to respond to free-form comments in mail sent to the commits list.
Sign up
-------
click the power icon in the top right. You can register with a GitHub account,
a Google account, or you can create your own profile.
-Make *sure* that the email address registered with Phabricator is be subscribed
+Make *sure* that the email address registered with Phabricator is subscribed
to the relevant -commits mailing list. If your are not subscribed to the commit
list, all mail sent by Phabricator on your behalf will be held for moderation.
* Leave the drop down on *Create a new Revision...* and click *Continue*.
* Enter a descriptive title and summary; add reviewers and mailing
lists that you want to be included in the review. If your patch is
- for LLVM, cc llvm-commits; if your patch is for Clang, cc cfe-commits.
+ for LLVM, add llvm-commits as a subscriber; if your patch is for Clang,
+ add cfe-commits.
* Click *Save*.
To submit an updated patch:
Committing a change
-------------------
+Arcanist can manage the commit transparently. It will retrieve the description,
+reviewers, the ``Differential Revision``, etc from the review and commit it to the repository.
+
+::
+
+ arc patch D<Revision>
+ arc commit --revision D<Revision>
+
+
When committing an LLVM change that has been reviewed using
Phabricator, the convention is for the commit message to end with the
line: