1 //===-- Verifier.cpp - Implement the Module Verifier -------------*- C++ -*-==//
3 // This file defines the function verifier interface, that can be used for some
4 // sanity checking of input to the system.
6 // Note that this does not provide full 'java style' security and verifications,
7 // instead it just tries to ensure that code is well formed.
9 // . There are no duplicated names in a symbol table... ie there !exist a val
10 // with the same name as something in the symbol table, but with a different
11 // address as what is in the symbol table...
12 // * Both of a binary operator's parameters are the same type
13 // * Verify that the indices of mem access instructions match other operands
14 // . Verify that arithmetic and other things are only performed on first class
15 // types. No adding structures or arrays.
16 // . All of the constants in a switch statement are of the correct type
17 // . The code is in valid SSA form
18 // . It should be illegal to put a label into any other type (like a structure)
19 // or to return one. [except constant arrays!]
20 // * Only phi nodes can be self referential: 'add int %0, %0 ; <int>:0' is bad
21 // * PHI nodes must have an entry for each predecessor, with no extras.
22 // . All basic blocks should only end with terminator insts, not contain them
23 // * The entry node to a function must not have predecessors
24 // * All Instructions must be embeded into a basic block
25 // . Verify that none of the Value getType()'s are null.
26 // . Function's cannot take a void typed parameter
27 // * Verify that a function's argument list agrees with it's declared type.
28 // . Verify that arrays and structures have fixed elements: No unsized arrays.
29 // * It is illegal to specify a name for a void value.
30 // * It is illegal to have a internal function that is just a declaration
31 // * It is illegal to have a ret instruction that returns a value that does not
32 // agree with the function return value type.
33 // * All other things that are tested by asserts spread about the code...
35 //===----------------------------------------------------------------------===//
37 #include "llvm/Analysis/Verifier.h"
38 #include "llvm/Pass.h"
39 #include "llvm/Function.h"
40 #include "llvm/Module.h"
41 #include "llvm/BasicBlock.h"
42 #include "llvm/DerivedTypes.h"
43 #include "llvm/iPHINode.h"
44 #include "llvm/iTerminators.h"
45 #include "llvm/iOther.h"
46 #include "llvm/iMemory.h"
47 #include "llvm/Argument.h"
48 #include "llvm/SymbolTable.h"
49 #include "llvm/Support/CFG.h"
50 #include "llvm/Support/InstVisitor.h"
51 #include "Support/STLExtras.h"
54 namespace { // Anonymous namespace for class
56 struct Verifier : public FunctionPass, InstVisitor<Verifier> {
59 Verifier() : Broken(false) {}
61 bool doInitialization(Module *M) {
62 verifySymbolTable(M->getSymbolTable());
66 bool runOnFunction(Function *F) {
71 bool doFinalization(Module *M) {
72 // Scan through, checking all of the external function's linkage now...
73 for (Module::iterator I = M->begin(), E = M->end(); I != E; ++I)
74 if ((*I)->isExternal() && (*I)->hasInternalLinkage())
75 CheckFailed("Function Declaration has Internal Linkage!", (*I));
78 cerr << "Broken module found, compilation aborted!\n";
84 virtual void getAnalysisUsage(AnalysisUsage &AU) const {
88 // Verification methods...
89 void verifySymbolTable(SymbolTable *ST);
90 void visitFunction(Function *F);
91 void visitBasicBlock(BasicBlock *BB);
92 void visitPHINode(PHINode *PN);
93 void visitBinaryOperator(BinaryOperator *B);
94 void visitCallInst(CallInst *CI);
95 void visitGetElementPtrInst(GetElementPtrInst *GEP);
96 void visitLoadInst(LoadInst *LI);
97 void visitStoreInst(StoreInst *SI);
98 void visitInstruction(Instruction *I);
100 // CheckFailed - A check failed, so print out the condition and the message
101 // that failed. This provides a nice place to put a breakpoint if you want
102 // to see why something is not correct.
104 inline void CheckFailed(const std::string &Message,
105 const Value *V1 = 0, const Value *V2 = 0) {
106 std::cerr << Message << "\n";
107 if (V1) { std::cerr << V1 << "\n"; }
108 if (V2) { std::cerr << V2 << "\n"; }
114 // Assert - We know that cond should be true, if not print an error message.
115 #define Assert(C, M) \
116 do { if (!(C)) { CheckFailed(M); return; } } while (0)
117 #define Assert1(C, M, V1) \
118 do { if (!(C)) { CheckFailed(M, V1); return; } } while (0)
119 #define Assert2(C, M, V1, V2) \
120 do { if (!(C)) { CheckFailed(M, V1, V2); return; } } while (0)
123 // verifySymbolTable - Verify that a function or module symbol table is ok
125 void Verifier::verifySymbolTable(SymbolTable *ST) {
126 if (ST == 0) return; // No symbol table to process
128 // Loop over all of the types in the symbol table...
129 for (SymbolTable::iterator TI = ST->begin(), TE = ST->end(); TI != TE; ++TI)
130 for (SymbolTable::type_iterator I = TI->second.begin(),
131 E = TI->second.end(); I != E; ++I) {
132 Value *V = I->second;
134 // Check that there are no void typed values in the symbol table. Values
135 // with a void type cannot be put into symbol tables because they cannot
137 Assert1(V->getType() != Type::VoidTy,
138 "Values with void type are not allowed to have names!", V);
143 // visitFunction - Verify that a function is ok.
145 void Verifier::visitFunction(Function *F) {
146 if (F->isExternal()) return;
148 verifySymbolTable(F->getSymbolTable());
150 // Check function arguments...
151 const FunctionType *FT = F->getFunctionType();
152 const Function::ArgumentListType &ArgList = F->getArgumentList();
154 Assert2(!FT->isVarArg(), "Cannot define varargs functions in LLVM!", F, FT);
155 Assert2(FT->getParamTypes().size() == ArgList.size(),
156 "# formal arguments must match # of arguments for function type!",
159 // Check that the argument values match the function type for this function...
160 if (FT->getParamTypes().size() == ArgList.size()) {
161 for (unsigned i = 0, e = ArgList.size(); i != e; ++i)
162 Assert2(ArgList[i]->getType() == FT->getParamType(i),
163 "Argument value does not match function argument type!",
164 ArgList[i], FT->getParamType(i));
167 // Check the entry node
168 BasicBlock *Entry = F->getEntryNode();
169 Assert1(pred_begin(Entry) == pred_end(Entry),
170 "Entry block to function must not have predecessors!", Entry);
174 // verifyBasicBlock - Verify that a basic block is well formed...
176 void Verifier::visitBasicBlock(BasicBlock *BB) {
177 Assert1(BB->getTerminator(), "Basic Block does not have terminator!", BB);
179 // Check that the terminator is ok as well...
180 if (isa<ReturnInst>(BB->getTerminator())) {
181 Instruction *I = BB->getTerminator();
182 Function *F = I->getParent()->getParent();
183 if (I->getNumOperands() == 0)
184 Assert1(F->getReturnType() == Type::VoidTy,
185 "Function returns no value, but ret instruction found that does!",
188 Assert2(F->getReturnType() == I->getOperand(0)->getType(),
189 "Function return type does not match operand "
190 "type of return inst!", I, F->getReturnType());
195 // visitPHINode - Ensure that a PHI node is well formed.
196 void Verifier::visitPHINode(PHINode *PN) {
197 std::vector<BasicBlock*> Preds(pred_begin(PN->getParent()),
198 pred_end(PN->getParent()));
199 // Loop over all of the incoming values, make sure that there are
200 // predecessors for each one...
202 for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) {
203 // Make sure all of the incoming values are the right types...
204 Assert2(PN->getType() == PN->getIncomingValue(i)->getType(),
205 "PHI node argument type does not agree with PHI node type!",
206 PN, PN->getIncomingValue(i));
208 BasicBlock *BB = PN->getIncomingBlock(i);
209 std::vector<BasicBlock*>::iterator PI =
210 find(Preds.begin(), Preds.end(), BB);
211 Assert2(PI != Preds.end(), "PHI node has entry for basic block that"
212 " is not a predecessor!", PN, BB);
216 // There should be no entries left in the predecessor list...
217 for (std::vector<BasicBlock*>::iterator I = Preds.begin(),
218 E = Preds.end(); I != E; ++I)
219 Assert2(0, "PHI node does not have entry for a predecessor basic block!",
222 visitInstruction(PN);
225 void Verifier::visitCallInst(CallInst *CI) {
226 Assert1(isa<PointerType>(CI->getOperand(0)->getType()),
227 "Called function must be a pointer!", CI);
228 PointerType *FPTy = cast<PointerType>(CI->getOperand(0)->getType());
229 Assert1(isa<FunctionType>(FPTy->getElementType()),
230 "Called function is not pointer to function type!", CI);
233 // visitBinaryOperator - Check that both arguments to the binary operator are
236 void Verifier::visitBinaryOperator(BinaryOperator *B) {
237 Assert2(B->getOperand(0)->getType() == B->getOperand(1)->getType(),
238 "Both operands to a binary operator are not of the same type!",
239 B->getOperand(0), B->getOperand(1));
244 void Verifier::visitGetElementPtrInst(GetElementPtrInst *GEP) {
245 const Type *ElTy =MemAccessInst::getIndexedType(GEP->getOperand(0)->getType(),
246 GEP->copyIndices(), true);
247 Assert1(ElTy, "Invalid indices for GEP pointer type!", GEP);
248 Assert2(PointerType::get(ElTy) == GEP->getType(),
249 "GEP is not of right type for indices!", GEP, ElTy);
250 visitInstruction(GEP);
253 void Verifier::visitLoadInst(LoadInst *LI) {
254 const Type *ElTy = LoadInst::getIndexedType(LI->getOperand(0)->getType(),
256 Assert1(ElTy, "Invalid indices for load pointer type!", LI);
257 Assert2(ElTy == LI->getType(),
258 "Load is not of right type for indices!", LI, ElTy);
259 visitInstruction(LI);
262 void Verifier::visitStoreInst(StoreInst *SI) {
263 const Type *ElTy = StoreInst::getIndexedType(SI->getOperand(1)->getType(),
265 Assert1(ElTy, "Invalid indices for store pointer type!", SI);
266 Assert2(ElTy == SI->getOperand(0)->getType(),
267 "Stored value is not of right type for indices!", SI, ElTy);
268 visitInstruction(SI);
272 // verifyInstruction - Verify that a non-terminator instruction is well formed.
274 void Verifier::visitInstruction(Instruction *I) {
275 assert(I->getParent() && "Instruction not embedded in basic block!");
277 // Check that all uses of the instruction, if they are instructions
278 // themselves, actually have parent basic blocks. If the use is not an
279 // instruction, it is an error!
281 for (User::use_iterator UI = I->use_begin(), UE = I->use_end();
283 Assert1(isa<Instruction>(*UI), "Use of instruction is not an instruction!",
285 Instruction *Used = cast<Instruction>(*UI);
286 Assert2(Used->getParent() != 0, "Instruction referencing instruction not"
287 " embeded in a basic block!", I, Used);
290 if (!isa<PHINode>(I)) { // Check that non-phi nodes are not self referential
291 for (Value::use_iterator UI = I->use_begin(), UE = I->use_end();
293 Assert1(*UI != (User*)I,
294 "Only PHI nodes may reference their own value!", I);
297 Assert1(I->getType() != Type::VoidTy || !I->hasName(),
298 "Instruction has a name, but provides a void value!", I);
302 //===----------------------------------------------------------------------===//
303 // Implement the public interfaces to this file...
304 //===----------------------------------------------------------------------===//
306 Pass *createVerifierPass() {
307 return new Verifier();
310 bool verifyFunction(const Function *F) {
312 V.visit((Function*)F);
316 // verifyModule - Check a module for errors, printing messages on stderr.
317 // Return true if the module is corrupt.
319 bool verifyModule(const Module *M) {