1 //===- Reassociate.cpp - Reassociate binary expressions -------------------===//
3 // The LLVM Compiler Infrastructure
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
8 //===----------------------------------------------------------------------===//
10 // This pass reassociates commutative expressions in an order that is designed
11 // to promote better constant propagation, GCSE, LICM, PRE, etc.
13 // For example: 4 + (x + 5) -> x + (4 + 5)
15 // In the implementation of this algorithm, constants are assigned rank = 0,
16 // function arguments are rank = 1, and other values are assigned ranks
17 // corresponding to the reverse post order traversal of current function
18 // (starting at 2), which effectively gives values in deep loops higher rank
19 // than values not in loops.
21 //===----------------------------------------------------------------------===//
23 #include "llvm/Transforms/Scalar.h"
24 #include "llvm/ADT/DenseMap.h"
25 #include "llvm/ADT/PostOrderIterator.h"
26 #include "llvm/ADT/STLExtras.h"
27 #include "llvm/ADT/SetVector.h"
28 #include "llvm/ADT/Statistic.h"
29 #include "llvm/IR/CFG.h"
30 #include "llvm/IR/Constants.h"
31 #include "llvm/IR/DerivedTypes.h"
32 #include "llvm/IR/Function.h"
33 #include "llvm/IR/IRBuilder.h"
34 #include "llvm/IR/Instructions.h"
35 #include "llvm/IR/IntrinsicInst.h"
36 #include "llvm/IR/ValueHandle.h"
37 #include "llvm/Pass.h"
38 #include "llvm/Support/Debug.h"
39 #include "llvm/Support/raw_ostream.h"
40 #include "llvm/Transforms/Utils/Local.h"
44 #define DEBUG_TYPE "reassociate"
46 STATISTIC(NumChanged, "Number of insts reassociated");
47 STATISTIC(NumAnnihil, "Number of expr tree annihilated");
48 STATISTIC(NumFactor , "Number of multiplies factored");
54 ValueEntry(unsigned R, Value *O) : Rank(R), Op(O) {}
56 inline bool operator<(const ValueEntry &LHS, const ValueEntry &RHS) {
57 return LHS.Rank > RHS.Rank; // Sort so that highest rank goes to start.
62 /// PrintOps - Print out the expression identified in the Ops list.
64 static void PrintOps(Instruction *I, const SmallVectorImpl<ValueEntry> &Ops) {
65 Module *M = I->getParent()->getParent()->getParent();
66 dbgs() << Instruction::getOpcodeName(I->getOpcode()) << " "
67 << *Ops[0].Op->getType() << '\t';
68 for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
70 Ops[i].Op->printAsOperand(dbgs(), false, M);
71 dbgs() << ", #" << Ops[i].Rank << "] ";
77 /// \brief Utility class representing a base and exponent pair which form one
78 /// factor of some product.
83 Factor(Value *Base, unsigned Power) : Base(Base), Power(Power) {}
85 /// \brief Sort factors by their Base.
87 bool operator()(const Factor &LHS, const Factor &RHS) {
88 return LHS.Base < RHS.Base;
92 /// \brief Compare factors for equal bases.
94 bool operator()(const Factor &LHS, const Factor &RHS) {
95 return LHS.Base == RHS.Base;
99 /// \brief Sort factors in descending order by their power.
100 struct PowerDescendingSorter {
101 bool operator()(const Factor &LHS, const Factor &RHS) {
102 return LHS.Power > RHS.Power;
106 /// \brief Compare factors for equal powers.
108 bool operator()(const Factor &LHS, const Factor &RHS) {
109 return LHS.Power == RHS.Power;
114 /// Utility class representing a non-constant Xor-operand. We classify
115 /// non-constant Xor-Operands into two categories:
116 /// C1) The operand is in the form "X & C", where C is a constant and C != ~0
118 /// C2.1) The operand is in the form of "X | C", where C is a non-zero
120 /// C2.2) Any operand E which doesn't fall into C1 and C2.1, we view this
121 /// operand as "E | 0"
126 bool isInvalid() const { return SymbolicPart == nullptr; }
127 bool isOrExpr() const { return isOr; }
128 Value *getValue() const { return OrigVal; }
129 Value *getSymbolicPart() const { return SymbolicPart; }
130 unsigned getSymbolicRank() const { return SymbolicRank; }
131 const APInt &getConstPart() const { return ConstPart; }
133 void Invalidate() { SymbolicPart = OrigVal = nullptr; }
134 void setSymbolicRank(unsigned R) { SymbolicRank = R; }
136 // Sort the XorOpnd-Pointer in ascending order of symbolic-value-rank.
137 // The purpose is twofold:
138 // 1) Cluster together the operands sharing the same symbolic-value.
139 // 2) Operand having smaller symbolic-value-rank is permuted earlier, which
140 // could potentially shorten crital path, and expose more loop-invariants.
141 // Note that values' rank are basically defined in RPO order (FIXME).
142 // So, if Rank(X) < Rank(Y) < Rank(Z), it means X is defined earlier
143 // than Y which is defined earlier than Z. Permute "x | 1", "Y & 2",
144 // "z" in the order of X-Y-Z is better than any other orders.
145 struct PtrSortFunctor {
146 bool operator()(XorOpnd * const &LHS, XorOpnd * const &RHS) {
147 return LHS->getSymbolicRank() < RHS->getSymbolicRank();
154 unsigned SymbolicRank;
160 class Reassociate : public FunctionPass {
161 DenseMap<BasicBlock*, unsigned> RankMap;
162 DenseMap<AssertingVH<Value>, unsigned> ValueRankMap;
163 SetVector<AssertingVH<Instruction> > RedoInsts;
166 static char ID; // Pass identification, replacement for typeid
167 Reassociate() : FunctionPass(ID) {
168 initializeReassociatePass(*PassRegistry::getPassRegistry());
171 bool runOnFunction(Function &F) override;
173 void getAnalysisUsage(AnalysisUsage &AU) const override {
174 AU.setPreservesCFG();
177 void BuildRankMap(Function &F);
178 unsigned getRank(Value *V);
179 void canonicalizeOperands(Instruction *I);
180 void ReassociateExpression(BinaryOperator *I);
181 void RewriteExprTree(BinaryOperator *I, SmallVectorImpl<ValueEntry> &Ops);
182 Value *OptimizeExpression(BinaryOperator *I,
183 SmallVectorImpl<ValueEntry> &Ops);
184 Value *OptimizeAdd(Instruction *I, SmallVectorImpl<ValueEntry> &Ops);
185 Value *OptimizeXor(Instruction *I, SmallVectorImpl<ValueEntry> &Ops);
186 bool CombineXorOpnd(Instruction *I, XorOpnd *Opnd1, APInt &ConstOpnd,
188 bool CombineXorOpnd(Instruction *I, XorOpnd *Opnd1, XorOpnd *Opnd2,
189 APInt &ConstOpnd, Value *&Res);
190 bool collectMultiplyFactors(SmallVectorImpl<ValueEntry> &Ops,
191 SmallVectorImpl<Factor> &Factors);
192 Value *buildMinimalMultiplyDAG(IRBuilder<> &Builder,
193 SmallVectorImpl<Factor> &Factors);
194 Value *OptimizeMul(BinaryOperator *I, SmallVectorImpl<ValueEntry> &Ops);
195 Value *RemoveFactorFromExpression(Value *V, Value *Factor);
196 void EraseInst(Instruction *I);
197 void OptimizeInst(Instruction *I);
198 Instruction *canonicalizeNegConstExpr(Instruction *I);
202 XorOpnd::XorOpnd(Value *V) {
203 assert(!isa<ConstantInt>(V) && "No ConstantInt");
205 Instruction *I = dyn_cast<Instruction>(V);
208 if (I && (I->getOpcode() == Instruction::Or ||
209 I->getOpcode() == Instruction::And)) {
210 Value *V0 = I->getOperand(0);
211 Value *V1 = I->getOperand(1);
212 if (isa<ConstantInt>(V0))
215 if (ConstantInt *C = dyn_cast<ConstantInt>(V1)) {
216 ConstPart = C->getValue();
218 isOr = (I->getOpcode() == Instruction::Or);
223 // view the operand as "V | 0"
225 ConstPart = APInt::getNullValue(V->getType()->getIntegerBitWidth());
229 char Reassociate::ID = 0;
230 INITIALIZE_PASS(Reassociate, "reassociate",
231 "Reassociate expressions", false, false)
233 // Public interface to the Reassociate pass
234 FunctionPass *llvm::createReassociatePass() { return new Reassociate(); }
236 /// isReassociableOp - Return true if V is an instruction of the specified
237 /// opcode and if it only has one use.
238 static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode) {
239 if (V->hasOneUse() && isa<Instruction>(V) &&
240 cast<Instruction>(V)->getOpcode() == Opcode &&
241 (!isa<FPMathOperator>(V) ||
242 cast<Instruction>(V)->hasUnsafeAlgebra()))
243 return cast<BinaryOperator>(V);
247 static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode1,
249 if (V->hasOneUse() && isa<Instruction>(V) &&
250 (cast<Instruction>(V)->getOpcode() == Opcode1 ||
251 cast<Instruction>(V)->getOpcode() == Opcode2) &&
252 (!isa<FPMathOperator>(V) ||
253 cast<Instruction>(V)->hasUnsafeAlgebra()))
254 return cast<BinaryOperator>(V);
258 static bool isUnmovableInstruction(Instruction *I) {
259 switch (I->getOpcode()) {
260 case Instruction::PHI:
261 case Instruction::LandingPad:
262 case Instruction::Alloca:
263 case Instruction::Load:
264 case Instruction::Invoke:
265 case Instruction::UDiv:
266 case Instruction::SDiv:
267 case Instruction::FDiv:
268 case Instruction::URem:
269 case Instruction::SRem:
270 case Instruction::FRem:
272 case Instruction::Call:
273 return !isa<DbgInfoIntrinsic>(I);
279 void Reassociate::BuildRankMap(Function &F) {
282 // Assign distinct ranks to function arguments.
283 for (Function::arg_iterator I = F.arg_begin(), E = F.arg_end(); I != E; ++I) {
284 ValueRankMap[&*I] = ++i;
285 DEBUG(dbgs() << "Calculated Rank[" << I->getName() << "] = " << i << "\n");
288 ReversePostOrderTraversal<Function*> RPOT(&F);
289 for (ReversePostOrderTraversal<Function*>::rpo_iterator I = RPOT.begin(),
290 E = RPOT.end(); I != E; ++I) {
292 unsigned BBRank = RankMap[BB] = ++i << 16;
294 // Walk the basic block, adding precomputed ranks for any instructions that
295 // we cannot move. This ensures that the ranks for these instructions are
296 // all different in the block.
297 for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ++I)
298 if (isUnmovableInstruction(I))
299 ValueRankMap[&*I] = ++BBRank;
303 unsigned Reassociate::getRank(Value *V) {
304 Instruction *I = dyn_cast<Instruction>(V);
306 if (isa<Argument>(V)) return ValueRankMap[V]; // Function argument.
307 return 0; // Otherwise it's a global or constant, rank 0.
310 if (unsigned Rank = ValueRankMap[I])
311 return Rank; // Rank already known?
313 // If this is an expression, return the 1+MAX(rank(LHS), rank(RHS)) so that
314 // we can reassociate expressions for code motion! Since we do not recurse
315 // for PHI nodes, we cannot have infinite recursion here, because there
316 // cannot be loops in the value graph that do not go through PHI nodes.
317 unsigned Rank = 0, MaxRank = RankMap[I->getParent()];
318 for (unsigned i = 0, e = I->getNumOperands();
319 i != e && Rank != MaxRank; ++i)
320 Rank = std::max(Rank, getRank(I->getOperand(i)));
322 // If this is a not or neg instruction, do not count it for rank. This
323 // assures us that X and ~X will have the same rank.
324 Type *Ty = V->getType();
325 if ((!Ty->isIntegerTy() && !Ty->isFloatingPointTy()) ||
326 (!BinaryOperator::isNot(I) && !BinaryOperator::isNeg(I) &&
327 !BinaryOperator::isFNeg(I)))
330 DEBUG(dbgs() << "Calculated Rank[" << V->getName() << "] = " << Rank << "\n");
332 return ValueRankMap[I] = Rank;
335 void Reassociate::canonicalizeOperands(Instruction *I) {
336 assert(isa<BinaryOperator>(I) && "Expected binary operator.");
337 assert(I->isCommutative() && "Expected commutative operator.");
339 Value *LHS = I->getOperand(0);
340 Value *RHS = I->getOperand(1);
341 unsigned LHSRank = getRank(LHS);
342 unsigned RHSRank = getRank(RHS);
344 // Canonicalize constants to RHS. Otherwise, sort the operands by rank.
345 if (isa<Constant>(LHS) || RHSRank < LHSRank)
346 cast<BinaryOperator>(I)->swapOperands();
349 static BinaryOperator *CreateAdd(Value *S1, Value *S2, const Twine &Name,
350 Instruction *InsertBefore, Value *FlagsOp) {
351 if (S1->getType()->isIntegerTy())
352 return BinaryOperator::CreateAdd(S1, S2, Name, InsertBefore);
354 BinaryOperator *Res =
355 BinaryOperator::CreateFAdd(S1, S2, Name, InsertBefore);
356 Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
361 static BinaryOperator *CreateMul(Value *S1, Value *S2, const Twine &Name,
362 Instruction *InsertBefore, Value *FlagsOp) {
363 if (S1->getType()->isIntegerTy())
364 return BinaryOperator::CreateMul(S1, S2, Name, InsertBefore);
366 BinaryOperator *Res =
367 BinaryOperator::CreateFMul(S1, S2, Name, InsertBefore);
368 Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
373 static BinaryOperator *CreateNeg(Value *S1, const Twine &Name,
374 Instruction *InsertBefore, Value *FlagsOp) {
375 if (S1->getType()->isIntegerTy())
376 return BinaryOperator::CreateNeg(S1, Name, InsertBefore);
378 BinaryOperator *Res = BinaryOperator::CreateFNeg(S1, Name, InsertBefore);
379 Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
384 /// LowerNegateToMultiply - Replace 0-X with X*-1.
386 static BinaryOperator *LowerNegateToMultiply(Instruction *Neg) {
387 Type *Ty = Neg->getType();
388 Constant *NegOne = Ty->isIntegerTy() ? ConstantInt::getAllOnesValue(Ty)
389 : ConstantFP::get(Ty, -1.0);
391 BinaryOperator *Res = CreateMul(Neg->getOperand(1), NegOne, "", Neg, Neg);
392 Neg->setOperand(1, Constant::getNullValue(Ty)); // Drop use of op.
394 Neg->replaceAllUsesWith(Res);
395 Res->setDebugLoc(Neg->getDebugLoc());
399 /// CarmichaelShift - Returns k such that lambda(2^Bitwidth) = 2^k, where lambda
400 /// is the Carmichael function. This means that x^(2^k) === 1 mod 2^Bitwidth for
401 /// every odd x, i.e. x^(2^k) = 1 for every odd x in Bitwidth-bit arithmetic.
402 /// Note that 0 <= k < Bitwidth, and if Bitwidth > 3 then x^(2^k) = 0 for every
403 /// even x in Bitwidth-bit arithmetic.
404 static unsigned CarmichaelShift(unsigned Bitwidth) {
410 /// IncorporateWeight - Add the extra weight 'RHS' to the existing weight 'LHS',
411 /// reducing the combined weight using any special properties of the operation.
412 /// The existing weight LHS represents the computation X op X op ... op X where
413 /// X occurs LHS times. The combined weight represents X op X op ... op X with
414 /// X occurring LHS + RHS times. If op is "Xor" for example then the combined
415 /// operation is equivalent to X if LHS + RHS is odd, or 0 if LHS + RHS is even;
416 /// the routine returns 1 in LHS in the first case, and 0 in LHS in the second.
417 static void IncorporateWeight(APInt &LHS, const APInt &RHS, unsigned Opcode) {
418 // If we were working with infinite precision arithmetic then the combined
419 // weight would be LHS + RHS. But we are using finite precision arithmetic,
420 // and the APInt sum LHS + RHS may not be correct if it wraps (it is correct
421 // for nilpotent operations and addition, but not for idempotent operations
422 // and multiplication), so it is important to correctly reduce the combined
423 // weight back into range if wrapping would be wrong.
425 // If RHS is zero then the weight didn't change.
426 if (RHS.isMinValue())
428 // If LHS is zero then the combined weight is RHS.
429 if (LHS.isMinValue()) {
433 // From this point on we know that neither LHS nor RHS is zero.
435 if (Instruction::isIdempotent(Opcode)) {
436 // Idempotent means X op X === X, so any non-zero weight is equivalent to a
437 // weight of 1. Keeping weights at zero or one also means that wrapping is
439 assert(LHS == 1 && RHS == 1 && "Weights not reduced!");
440 return; // Return a weight of 1.
442 if (Instruction::isNilpotent(Opcode)) {
443 // Nilpotent means X op X === 0, so reduce weights modulo 2.
444 assert(LHS == 1 && RHS == 1 && "Weights not reduced!");
445 LHS = 0; // 1 + 1 === 0 modulo 2.
448 if (Opcode == Instruction::Add || Opcode == Instruction::FAdd) {
449 // TODO: Reduce the weight by exploiting nsw/nuw?
454 assert((Opcode == Instruction::Mul || Opcode == Instruction::FMul) &&
455 "Unknown associative operation!");
456 unsigned Bitwidth = LHS.getBitWidth();
457 // If CM is the Carmichael number then a weight W satisfying W >= CM+Bitwidth
458 // can be replaced with W-CM. That's because x^W=x^(W-CM) for every Bitwidth
459 // bit number x, since either x is odd in which case x^CM = 1, or x is even in
460 // which case both x^W and x^(W - CM) are zero. By subtracting off multiples
461 // of CM like this weights can always be reduced to the range [0, CM+Bitwidth)
462 // which by a happy accident means that they can always be represented using
464 // TODO: Reduce the weight by exploiting nsw/nuw? (Could do much better than
465 // the Carmichael number).
467 /// CM - The value of Carmichael's lambda function.
468 APInt CM = APInt::getOneBitSet(Bitwidth, CarmichaelShift(Bitwidth));
469 // Any weight W >= Threshold can be replaced with W - CM.
470 APInt Threshold = CM + Bitwidth;
471 assert(LHS.ult(Threshold) && RHS.ult(Threshold) && "Weights not reduced!");
472 // For Bitwidth 4 or more the following sum does not overflow.
474 while (LHS.uge(Threshold))
477 // To avoid problems with overflow do everything the same as above but using
479 unsigned CM = 1U << CarmichaelShift(Bitwidth);
480 unsigned Threshold = CM + Bitwidth;
481 assert(LHS.getZExtValue() < Threshold && RHS.getZExtValue() < Threshold &&
482 "Weights not reduced!");
483 unsigned Total = LHS.getZExtValue() + RHS.getZExtValue();
484 while (Total >= Threshold)
490 typedef std::pair<Value*, APInt> RepeatedValue;
492 /// LinearizeExprTree - Given an associative binary expression, return the leaf
493 /// nodes in Ops along with their weights (how many times the leaf occurs). The
494 /// original expression is the same as
495 /// (Ops[0].first op Ops[0].first op ... Ops[0].first) <- Ops[0].second times
497 /// (Ops[1].first op Ops[1].first op ... Ops[1].first) <- Ops[1].second times
501 /// (Ops[N].first op Ops[N].first op ... Ops[N].first) <- Ops[N].second times
503 /// Note that the values Ops[0].first, ..., Ops[N].first are all distinct.
505 /// This routine may modify the function, in which case it returns 'true'. The
506 /// changes it makes may well be destructive, changing the value computed by 'I'
507 /// to something completely different. Thus if the routine returns 'true' then
508 /// you MUST either replace I with a new expression computed from the Ops array,
509 /// or use RewriteExprTree to put the values back in.
511 /// A leaf node is either not a binary operation of the same kind as the root
512 /// node 'I' (i.e. is not a binary operator at all, or is, but with a different
513 /// opcode), or is the same kind of binary operator but has a use which either
514 /// does not belong to the expression, or does belong to the expression but is
515 /// a leaf node. Every leaf node has at least one use that is a non-leaf node
516 /// of the expression, while for non-leaf nodes (except for the root 'I') every
517 /// use is a non-leaf node of the expression.
520 /// expression graph node names
530 /// The leaf nodes are C, E, F and G. The Ops array will contain (maybe not in
531 /// that order) (C, 1), (E, 1), (F, 2), (G, 2).
533 /// The expression is maximal: if some instruction is a binary operator of the
534 /// same kind as 'I', and all of its uses are non-leaf nodes of the expression,
535 /// then the instruction also belongs to the expression, is not a leaf node of
536 /// it, and its operands also belong to the expression (but may be leaf nodes).
538 /// NOTE: This routine will set operands of non-leaf non-root nodes to undef in
539 /// order to ensure that every non-root node in the expression has *exactly one*
540 /// use by a non-leaf node of the expression. This destruction means that the
541 /// caller MUST either replace 'I' with a new expression or use something like
542 /// RewriteExprTree to put the values back in if the routine indicates that it
543 /// made a change by returning 'true'.
545 /// In the above example either the right operand of A or the left operand of B
546 /// will be replaced by undef. If it is B's operand then this gives:
550 /// + + | A, B - operand of B replaced with undef
556 /// Note that such undef operands can only be reached by passing through 'I'.
557 /// For example, if you visit operands recursively starting from a leaf node
558 /// then you will never see such an undef operand unless you get back to 'I',
559 /// which requires passing through a phi node.
561 /// Note that this routine may also mutate binary operators of the wrong type
562 /// that have all uses inside the expression (i.e. only used by non-leaf nodes
563 /// of the expression) if it can turn them into binary operators of the right
564 /// type and thus make the expression bigger.
566 static bool LinearizeExprTree(BinaryOperator *I,
567 SmallVectorImpl<RepeatedValue> &Ops) {
568 DEBUG(dbgs() << "LINEARIZE: " << *I << '\n');
569 unsigned Bitwidth = I->getType()->getScalarType()->getPrimitiveSizeInBits();
570 unsigned Opcode = I->getOpcode();
571 assert(I->isAssociative() && I->isCommutative() &&
572 "Expected an associative and commutative operation!");
574 // Visit all operands of the expression, keeping track of their weight (the
575 // number of paths from the expression root to the operand, or if you like
576 // the number of times that operand occurs in the linearized expression).
577 // For example, if I = X + A, where X = A + B, then I, X and B have weight 1
578 // while A has weight two.
580 // Worklist of non-leaf nodes (their operands are in the expression too) along
581 // with their weights, representing a certain number of paths to the operator.
582 // If an operator occurs in the worklist multiple times then we found multiple
583 // ways to get to it.
584 SmallVector<std::pair<BinaryOperator*, APInt>, 8> Worklist; // (Op, Weight)
585 Worklist.push_back(std::make_pair(I, APInt(Bitwidth, 1)));
586 bool MadeChange = false;
588 // Leaves of the expression are values that either aren't the right kind of
589 // operation (eg: a constant, or a multiply in an add tree), or are, but have
590 // some uses that are not inside the expression. For example, in I = X + X,
591 // X = A + B, the value X has two uses (by I) that are in the expression. If
592 // X has any other uses, for example in a return instruction, then we consider
593 // X to be a leaf, and won't analyze it further. When we first visit a value,
594 // if it has more than one use then at first we conservatively consider it to
595 // be a leaf. Later, as the expression is explored, we may discover some more
596 // uses of the value from inside the expression. If all uses turn out to be
597 // from within the expression (and the value is a binary operator of the right
598 // kind) then the value is no longer considered to be a leaf, and its operands
601 // Leaves - Keeps track of the set of putative leaves as well as the number of
602 // paths to each leaf seen so far.
603 typedef DenseMap<Value*, APInt> LeafMap;
604 LeafMap Leaves; // Leaf -> Total weight so far.
605 SmallVector<Value*, 8> LeafOrder; // Ensure deterministic leaf output order.
608 SmallPtrSet<Value*, 8> Visited; // For sanity checking the iteration scheme.
610 while (!Worklist.empty()) {
611 std::pair<BinaryOperator*, APInt> P = Worklist.pop_back_val();
612 I = P.first; // We examine the operands of this binary operator.
614 for (unsigned OpIdx = 0; OpIdx < 2; ++OpIdx) { // Visit operands.
615 Value *Op = I->getOperand(OpIdx);
616 APInt Weight = P.second; // Number of paths to this operand.
617 DEBUG(dbgs() << "OPERAND: " << *Op << " (" << Weight << ")\n");
618 assert(!Op->use_empty() && "No uses, so how did we get to it?!");
620 // If this is a binary operation of the right kind with only one use then
621 // add its operands to the expression.
622 if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) {
623 assert(Visited.insert(Op) && "Not first visit!");
624 DEBUG(dbgs() << "DIRECT ADD: " << *Op << " (" << Weight << ")\n");
625 Worklist.push_back(std::make_pair(BO, Weight));
629 // Appears to be a leaf. Is the operand already in the set of leaves?
630 LeafMap::iterator It = Leaves.find(Op);
631 if (It == Leaves.end()) {
632 // Not in the leaf map. Must be the first time we saw this operand.
633 assert(Visited.insert(Op) && "Not first visit!");
634 if (!Op->hasOneUse()) {
635 // This value has uses not accounted for by the expression, so it is
636 // not safe to modify. Mark it as being a leaf.
637 DEBUG(dbgs() << "ADD USES LEAF: " << *Op << " (" << Weight << ")\n");
638 LeafOrder.push_back(Op);
642 // No uses outside the expression, try morphing it.
643 } else if (It != Leaves.end()) {
644 // Already in the leaf map.
645 assert(Visited.count(Op) && "In leaf map but not visited!");
647 // Update the number of paths to the leaf.
648 IncorporateWeight(It->second, Weight, Opcode);
650 #if 0 // TODO: Re-enable once PR13021 is fixed.
651 // The leaf already has one use from inside the expression. As we want
652 // exactly one such use, drop this new use of the leaf.
653 assert(!Op->hasOneUse() && "Only one use, but we got here twice!");
654 I->setOperand(OpIdx, UndefValue::get(I->getType()));
657 // If the leaf is a binary operation of the right kind and we now see
658 // that its multiple original uses were in fact all by nodes belonging
659 // to the expression, then no longer consider it to be a leaf and add
660 // its operands to the expression.
661 if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) {
662 DEBUG(dbgs() << "UNLEAF: " << *Op << " (" << It->second << ")\n");
663 Worklist.push_back(std::make_pair(BO, It->second));
669 // If we still have uses that are not accounted for by the expression
670 // then it is not safe to modify the value.
671 if (!Op->hasOneUse())
674 // No uses outside the expression, try morphing it.
676 Leaves.erase(It); // Since the value may be morphed below.
679 // At this point we have a value which, first of all, is not a binary
680 // expression of the right kind, and secondly, is only used inside the
681 // expression. This means that it can safely be modified. See if we
682 // can usefully morph it into an expression of the right kind.
683 assert((!isa<Instruction>(Op) ||
684 cast<Instruction>(Op)->getOpcode() != Opcode
685 || (isa<FPMathOperator>(Op) &&
686 !cast<Instruction>(Op)->hasUnsafeAlgebra())) &&
687 "Should have been handled above!");
688 assert(Op->hasOneUse() && "Has uses outside the expression tree!");
690 // If this is a multiply expression, turn any internal negations into
691 // multiplies by -1 so they can be reassociated.
692 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(Op))
693 if ((Opcode == Instruction::Mul && BinaryOperator::isNeg(BO)) ||
694 (Opcode == Instruction::FMul && BinaryOperator::isFNeg(BO))) {
695 DEBUG(dbgs() << "MORPH LEAF: " << *Op << " (" << Weight << ") TO ");
696 BO = LowerNegateToMultiply(BO);
697 DEBUG(dbgs() << *BO << '\n');
698 Worklist.push_back(std::make_pair(BO, Weight));
703 // Failed to morph into an expression of the right type. This really is
705 DEBUG(dbgs() << "ADD LEAF: " << *Op << " (" << Weight << ")\n");
706 assert(!isReassociableOp(Op, Opcode) && "Value was morphed?");
707 LeafOrder.push_back(Op);
712 // The leaves, repeated according to their weights, represent the linearized
713 // form of the expression.
714 for (unsigned i = 0, e = LeafOrder.size(); i != e; ++i) {
715 Value *V = LeafOrder[i];
716 LeafMap::iterator It = Leaves.find(V);
717 if (It == Leaves.end())
718 // Node initially thought to be a leaf wasn't.
720 assert(!isReassociableOp(V, Opcode) && "Shouldn't be a leaf!");
721 APInt Weight = It->second;
722 if (Weight.isMinValue())
723 // Leaf already output or weight reduction eliminated it.
725 // Ensure the leaf is only output once.
727 Ops.push_back(std::make_pair(V, Weight));
730 // For nilpotent operations or addition there may be no operands, for example
731 // because the expression was "X xor X" or consisted of 2^Bitwidth additions:
732 // in both cases the weight reduces to 0 causing the value to be skipped.
734 Constant *Identity = ConstantExpr::getBinOpIdentity(Opcode, I->getType());
735 assert(Identity && "Associative operation without identity!");
736 Ops.push_back(std::make_pair(Identity, APInt(Bitwidth, 1)));
742 // RewriteExprTree - Now that the operands for this expression tree are
743 // linearized and optimized, emit them in-order.
744 void Reassociate::RewriteExprTree(BinaryOperator *I,
745 SmallVectorImpl<ValueEntry> &Ops) {
746 assert(Ops.size() > 1 && "Single values should be used directly!");
748 // Since our optimizations should never increase the number of operations, the
749 // new expression can usually be written reusing the existing binary operators
750 // from the original expression tree, without creating any new instructions,
751 // though the rewritten expression may have a completely different topology.
752 // We take care to not change anything if the new expression will be the same
753 // as the original. If more than trivial changes (like commuting operands)
754 // were made then we are obliged to clear out any optional subclass data like
757 /// NodesToRewrite - Nodes from the original expression available for writing
758 /// the new expression into.
759 SmallVector<BinaryOperator*, 8> NodesToRewrite;
760 unsigned Opcode = I->getOpcode();
761 BinaryOperator *Op = I;
763 /// NotRewritable - The operands being written will be the leaves of the new
764 /// expression and must not be used as inner nodes (via NodesToRewrite) by
765 /// mistake. Inner nodes are always reassociable, and usually leaves are not
766 /// (if they were they would have been incorporated into the expression and so
767 /// would not be leaves), so most of the time there is no danger of this. But
768 /// in rare cases a leaf may become reassociable if an optimization kills uses
769 /// of it, or it may momentarily become reassociable during rewriting (below)
770 /// due it being removed as an operand of one of its uses. Ensure that misuse
771 /// of leaf nodes as inner nodes cannot occur by remembering all of the future
772 /// leaves and refusing to reuse any of them as inner nodes.
773 SmallPtrSet<Value*, 8> NotRewritable;
774 for (unsigned i = 0, e = Ops.size(); i != e; ++i)
775 NotRewritable.insert(Ops[i].Op);
777 // ExpressionChanged - Non-null if the rewritten expression differs from the
778 // original in some non-trivial way, requiring the clearing of optional flags.
779 // Flags are cleared from the operator in ExpressionChanged up to I inclusive.
780 BinaryOperator *ExpressionChanged = nullptr;
781 for (unsigned i = 0; ; ++i) {
782 // The last operation (which comes earliest in the IR) is special as both
783 // operands will come from Ops, rather than just one with the other being
785 if (i+2 == Ops.size()) {
786 Value *NewLHS = Ops[i].Op;
787 Value *NewRHS = Ops[i+1].Op;
788 Value *OldLHS = Op->getOperand(0);
789 Value *OldRHS = Op->getOperand(1);
791 if (NewLHS == OldLHS && NewRHS == OldRHS)
792 // Nothing changed, leave it alone.
795 if (NewLHS == OldRHS && NewRHS == OldLHS) {
796 // The order of the operands was reversed. Swap them.
797 DEBUG(dbgs() << "RA: " << *Op << '\n');
799 DEBUG(dbgs() << "TO: " << *Op << '\n');
805 // The new operation differs non-trivially from the original. Overwrite
806 // the old operands with the new ones.
807 DEBUG(dbgs() << "RA: " << *Op << '\n');
808 if (NewLHS != OldLHS) {
809 BinaryOperator *BO = isReassociableOp(OldLHS, Opcode);
810 if (BO && !NotRewritable.count(BO))
811 NodesToRewrite.push_back(BO);
812 Op->setOperand(0, NewLHS);
814 if (NewRHS != OldRHS) {
815 BinaryOperator *BO = isReassociableOp(OldRHS, Opcode);
816 if (BO && !NotRewritable.count(BO))
817 NodesToRewrite.push_back(BO);
818 Op->setOperand(1, NewRHS);
820 DEBUG(dbgs() << "TO: " << *Op << '\n');
822 ExpressionChanged = Op;
829 // Not the last operation. The left-hand side will be a sub-expression
830 // while the right-hand side will be the current element of Ops.
831 Value *NewRHS = Ops[i].Op;
832 if (NewRHS != Op->getOperand(1)) {
833 DEBUG(dbgs() << "RA: " << *Op << '\n');
834 if (NewRHS == Op->getOperand(0)) {
835 // The new right-hand side was already present as the left operand. If
836 // we are lucky then swapping the operands will sort out both of them.
839 // Overwrite with the new right-hand side.
840 BinaryOperator *BO = isReassociableOp(Op->getOperand(1), Opcode);
841 if (BO && !NotRewritable.count(BO))
842 NodesToRewrite.push_back(BO);
843 Op->setOperand(1, NewRHS);
844 ExpressionChanged = Op;
846 DEBUG(dbgs() << "TO: " << *Op << '\n');
851 // Now deal with the left-hand side. If this is already an operation node
852 // from the original expression then just rewrite the rest of the expression
854 BinaryOperator *BO = isReassociableOp(Op->getOperand(0), Opcode);
855 if (BO && !NotRewritable.count(BO)) {
860 // Otherwise, grab a spare node from the original expression and use that as
861 // the left-hand side. If there are no nodes left then the optimizers made
862 // an expression with more nodes than the original! This usually means that
863 // they did something stupid but it might mean that the problem was just too
864 // hard (finding the mimimal number of multiplications needed to realize a
865 // multiplication expression is NP-complete). Whatever the reason, smart or
866 // stupid, create a new node if there are none left.
867 BinaryOperator *NewOp;
868 if (NodesToRewrite.empty()) {
869 Constant *Undef = UndefValue::get(I->getType());
870 NewOp = BinaryOperator::Create(Instruction::BinaryOps(Opcode),
871 Undef, Undef, "", I);
872 if (NewOp->getType()->isFloatingPointTy())
873 NewOp->setFastMathFlags(I->getFastMathFlags());
875 NewOp = NodesToRewrite.pop_back_val();
878 DEBUG(dbgs() << "RA: " << *Op << '\n');
879 Op->setOperand(0, NewOp);
880 DEBUG(dbgs() << "TO: " << *Op << '\n');
881 ExpressionChanged = Op;
887 // If the expression changed non-trivially then clear out all subclass data
888 // starting from the operator specified in ExpressionChanged, and compactify
889 // the operators to just before the expression root to guarantee that the
890 // expression tree is dominated by all of Ops.
891 if (ExpressionChanged)
893 // Preserve FastMathFlags.
894 if (isa<FPMathOperator>(I)) {
895 FastMathFlags Flags = I->getFastMathFlags();
896 ExpressionChanged->clearSubclassOptionalData();
897 ExpressionChanged->setFastMathFlags(Flags);
899 ExpressionChanged->clearSubclassOptionalData();
901 if (ExpressionChanged == I)
903 ExpressionChanged->moveBefore(I);
904 ExpressionChanged = cast<BinaryOperator>(*ExpressionChanged->user_begin());
907 // Throw away any left over nodes from the original expression.
908 for (unsigned i = 0, e = NodesToRewrite.size(); i != e; ++i)
909 RedoInsts.insert(NodesToRewrite[i]);
912 /// NegateValue - Insert instructions before the instruction pointed to by BI,
913 /// that computes the negative version of the value specified. The negative
914 /// version of the value is returned, and BI is left pointing at the instruction
915 /// that should be processed next by the reassociation pass.
916 static Value *NegateValue(Value *V, Instruction *BI) {
917 if (ConstantFP *C = dyn_cast<ConstantFP>(V))
918 return ConstantExpr::getFNeg(C);
919 if (Constant *C = dyn_cast<Constant>(V))
920 return ConstantExpr::getNeg(C);
922 // We are trying to expose opportunity for reassociation. One of the things
923 // that we want to do to achieve this is to push a negation as deep into an
924 // expression chain as possible, to expose the add instructions. In practice,
925 // this means that we turn this:
926 // X = -(A+12+C+D) into X = -A + -12 + -C + -D = -12 + -A + -C + -D
927 // so that later, a: Y = 12+X could get reassociated with the -12 to eliminate
928 // the constants. We assume that instcombine will clean up the mess later if
929 // we introduce tons of unnecessary negation instructions.
931 if (BinaryOperator *I =
932 isReassociableOp(V, Instruction::Add, Instruction::FAdd)) {
933 // Push the negates through the add.
934 I->setOperand(0, NegateValue(I->getOperand(0), BI));
935 I->setOperand(1, NegateValue(I->getOperand(1), BI));
937 // We must move the add instruction here, because the neg instructions do
938 // not dominate the old add instruction in general. By moving it, we are
939 // assured that the neg instructions we just inserted dominate the
940 // instruction we are about to insert after them.
943 I->setName(I->getName()+".neg");
947 // Okay, we need to materialize a negated version of V with an instruction.
948 // Scan the use lists of V to see if we have one already.
949 for (User *U : V->users()) {
950 if (!BinaryOperator::isNeg(U) && !BinaryOperator::isFNeg(U))
953 // We found one! Now we have to make sure that the definition dominates
954 // this use. We do this by moving it to the entry block (if it is a
955 // non-instruction value) or right after the definition. These negates will
956 // be zapped by reassociate later, so we don't need much finesse here.
957 BinaryOperator *TheNeg = cast<BinaryOperator>(U);
959 // Verify that the negate is in this function, V might be a constant expr.
960 if (TheNeg->getParent()->getParent() != BI->getParent()->getParent())
963 BasicBlock::iterator InsertPt;
964 if (Instruction *InstInput = dyn_cast<Instruction>(V)) {
965 if (InvokeInst *II = dyn_cast<InvokeInst>(InstInput)) {
966 InsertPt = II->getNormalDest()->begin();
968 InsertPt = InstInput;
971 while (isa<PHINode>(InsertPt)) ++InsertPt;
973 InsertPt = TheNeg->getParent()->getParent()->getEntryBlock().begin();
975 TheNeg->moveBefore(InsertPt);
979 // Insert a 'neg' instruction that subtracts the value from zero to get the
981 return CreateNeg(V, V->getName() + ".neg", BI, BI);
984 /// ShouldBreakUpSubtract - Return true if we should break up this subtract of
985 /// X-Y into (X + -Y).
986 static bool ShouldBreakUpSubtract(Instruction *Sub) {
987 // If this is a negation, we can't split it up!
988 if (BinaryOperator::isNeg(Sub) || BinaryOperator::isFNeg(Sub))
991 // Don't breakup X - undef.
992 if (isa<UndefValue>(Sub->getOperand(1)))
995 // Don't bother to break this up unless either the LHS is an associable add or
996 // subtract or if this is only used by one.
997 Value *V0 = Sub->getOperand(0);
998 if (isReassociableOp(V0, Instruction::Add, Instruction::FAdd) ||
999 isReassociableOp(V0, Instruction::Sub, Instruction::FSub))
1001 Value *V1 = Sub->getOperand(1);
1002 if (isReassociableOp(V1, Instruction::Add, Instruction::FAdd) ||
1003 isReassociableOp(V1, Instruction::Sub, Instruction::FSub))
1005 Value *VB = Sub->user_back();
1006 if (Sub->hasOneUse() &&
1007 (isReassociableOp(VB, Instruction::Add, Instruction::FAdd) ||
1008 isReassociableOp(VB, Instruction::Sub, Instruction::FSub)))
1014 /// BreakUpSubtract - If we have (X-Y), and if either X is an add, or if this is
1015 /// only used by an add, transform this into (X+(0-Y)) to promote better
1017 static BinaryOperator *BreakUpSubtract(Instruction *Sub) {
1018 // Convert a subtract into an add and a neg instruction. This allows sub
1019 // instructions to be commuted with other add instructions.
1021 // Calculate the negative value of Operand 1 of the sub instruction,
1022 // and set it as the RHS of the add instruction we just made.
1024 Value *NegVal = NegateValue(Sub->getOperand(1), Sub);
1025 BinaryOperator *New = CreateAdd(Sub->getOperand(0), NegVal, "", Sub, Sub);
1026 Sub->setOperand(0, Constant::getNullValue(Sub->getType())); // Drop use of op.
1027 Sub->setOperand(1, Constant::getNullValue(Sub->getType())); // Drop use of op.
1030 // Everyone now refers to the add instruction.
1031 Sub->replaceAllUsesWith(New);
1032 New->setDebugLoc(Sub->getDebugLoc());
1034 DEBUG(dbgs() << "Negated: " << *New << '\n');
1038 /// ConvertShiftToMul - If this is a shift of a reassociable multiply or is used
1039 /// by one, change this into a multiply by a constant to assist with further
1041 static BinaryOperator *ConvertShiftToMul(Instruction *Shl) {
1042 Constant *MulCst = ConstantInt::get(Shl->getType(), 1);
1043 MulCst = ConstantExpr::getShl(MulCst, cast<Constant>(Shl->getOperand(1)));
1045 BinaryOperator *Mul =
1046 BinaryOperator::CreateMul(Shl->getOperand(0), MulCst, "", Shl);
1047 Shl->setOperand(0, UndefValue::get(Shl->getType())); // Drop use of op.
1050 // Everyone now refers to the mul instruction.
1051 Shl->replaceAllUsesWith(Mul);
1052 Mul->setDebugLoc(Shl->getDebugLoc());
1054 // We can safely preserve the nuw flag in all cases. It's also safe to turn a
1055 // nuw nsw shl into a nuw nsw mul. However, nsw in isolation requires special
1057 bool NSW = cast<BinaryOperator>(Shl)->hasNoSignedWrap();
1058 bool NUW = cast<BinaryOperator>(Shl)->hasNoUnsignedWrap();
1060 Mul->setHasNoSignedWrap(true);
1061 Mul->setHasNoUnsignedWrap(NUW);
1065 /// FindInOperandList - Scan backwards and forwards among values with the same
1066 /// rank as element i to see if X exists. If X does not exist, return i. This
1067 /// is useful when scanning for 'x' when we see '-x' because they both get the
1069 static unsigned FindInOperandList(SmallVectorImpl<ValueEntry> &Ops, unsigned i,
1071 unsigned XRank = Ops[i].Rank;
1072 unsigned e = Ops.size();
1073 for (unsigned j = i+1; j != e && Ops[j].Rank == XRank; ++j) {
1076 if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op))
1077 if (Instruction *I2 = dyn_cast<Instruction>(X))
1078 if (I1->isIdenticalTo(I2))
1082 for (unsigned j = i-1; j != ~0U && Ops[j].Rank == XRank; --j) {
1085 if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op))
1086 if (Instruction *I2 = dyn_cast<Instruction>(X))
1087 if (I1->isIdenticalTo(I2))
1093 /// EmitAddTreeOfValues - Emit a tree of add instructions, summing Ops together
1094 /// and returning the result. Insert the tree before I.
1095 static Value *EmitAddTreeOfValues(Instruction *I,
1096 SmallVectorImpl<WeakVH> &Ops){
1097 if (Ops.size() == 1) return Ops.back();
1099 Value *V1 = Ops.back();
1101 Value *V2 = EmitAddTreeOfValues(I, Ops);
1102 return CreateAdd(V2, V1, "tmp", I, I);
1105 /// RemoveFactorFromExpression - If V is an expression tree that is a
1106 /// multiplication sequence, and if this sequence contains a multiply by Factor,
1107 /// remove Factor from the tree and return the new tree.
1108 Value *Reassociate::RemoveFactorFromExpression(Value *V, Value *Factor) {
1109 BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul);
1113 SmallVector<RepeatedValue, 8> Tree;
1114 MadeChange |= LinearizeExprTree(BO, Tree);
1115 SmallVector<ValueEntry, 8> Factors;
1116 Factors.reserve(Tree.size());
1117 for (unsigned i = 0, e = Tree.size(); i != e; ++i) {
1118 RepeatedValue E = Tree[i];
1119 Factors.append(E.second.getZExtValue(),
1120 ValueEntry(getRank(E.first), E.first));
1123 bool FoundFactor = false;
1124 bool NeedsNegate = false;
1125 for (unsigned i = 0, e = Factors.size(); i != e; ++i) {
1126 if (Factors[i].Op == Factor) {
1128 Factors.erase(Factors.begin()+i);
1132 // If this is a negative version of this factor, remove it.
1133 if (ConstantInt *FC1 = dyn_cast<ConstantInt>(Factor)) {
1134 if (ConstantInt *FC2 = dyn_cast<ConstantInt>(Factors[i].Op))
1135 if (FC1->getValue() == -FC2->getValue()) {
1136 FoundFactor = NeedsNegate = true;
1137 Factors.erase(Factors.begin()+i);
1140 } else if (ConstantFP *FC1 = dyn_cast<ConstantFP>(Factor)) {
1141 if (ConstantFP *FC2 = dyn_cast<ConstantFP>(Factors[i].Op)) {
1142 APFloat F1(FC1->getValueAPF());
1143 APFloat F2(FC2->getValueAPF());
1145 if (F1.compare(F2) == APFloat::cmpEqual) {
1146 FoundFactor = NeedsNegate = true;
1147 Factors.erase(Factors.begin() + i);
1155 // Make sure to restore the operands to the expression tree.
1156 RewriteExprTree(BO, Factors);
1160 BasicBlock::iterator InsertPt = BO; ++InsertPt;
1162 // If this was just a single multiply, remove the multiply and return the only
1163 // remaining operand.
1164 if (Factors.size() == 1) {
1165 RedoInsts.insert(BO);
1168 RewriteExprTree(BO, Factors);
1173 V = CreateNeg(V, "neg", InsertPt, BO);
1178 /// FindSingleUseMultiplyFactors - If V is a single-use multiply, recursively
1179 /// add its operands as factors, otherwise add V to the list of factors.
1181 /// Ops is the top-level list of add operands we're trying to factor.
1182 static void FindSingleUseMultiplyFactors(Value *V,
1183 SmallVectorImpl<Value*> &Factors,
1184 const SmallVectorImpl<ValueEntry> &Ops) {
1185 BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul);
1187 Factors.push_back(V);
1191 // Otherwise, add the LHS and RHS to the list of factors.
1192 FindSingleUseMultiplyFactors(BO->getOperand(1), Factors, Ops);
1193 FindSingleUseMultiplyFactors(BO->getOperand(0), Factors, Ops);
1196 /// OptimizeAndOrXor - Optimize a series of operands to an 'and', 'or', or 'xor'
1197 /// instruction. This optimizes based on identities. If it can be reduced to
1198 /// a single Value, it is returned, otherwise the Ops list is mutated as
1200 static Value *OptimizeAndOrXor(unsigned Opcode,
1201 SmallVectorImpl<ValueEntry> &Ops) {
1202 // Scan the operand lists looking for X and ~X pairs, along with X,X pairs.
1203 // If we find any, we can simplify the expression. X&~X == 0, X|~X == -1.
1204 for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
1205 // First, check for X and ~X in the operand list.
1206 assert(i < Ops.size());
1207 if (BinaryOperator::isNot(Ops[i].Op)) { // Cannot occur for ^.
1208 Value *X = BinaryOperator::getNotArgument(Ops[i].Op);
1209 unsigned FoundX = FindInOperandList(Ops, i, X);
1211 if (Opcode == Instruction::And) // ...&X&~X = 0
1212 return Constant::getNullValue(X->getType());
1214 if (Opcode == Instruction::Or) // ...|X|~X = -1
1215 return Constant::getAllOnesValue(X->getType());
1219 // Next, check for duplicate pairs of values, which we assume are next to
1220 // each other, due to our sorting criteria.
1221 assert(i < Ops.size());
1222 if (i+1 != Ops.size() && Ops[i+1].Op == Ops[i].Op) {
1223 if (Opcode == Instruction::And || Opcode == Instruction::Or) {
1224 // Drop duplicate values for And and Or.
1225 Ops.erase(Ops.begin()+i);
1231 // Drop pairs of values for Xor.
1232 assert(Opcode == Instruction::Xor);
1234 return Constant::getNullValue(Ops[0].Op->getType());
1237 Ops.erase(Ops.begin()+i, Ops.begin()+i+2);
1245 /// Helper funciton of CombineXorOpnd(). It creates a bitwise-and
1246 /// instruction with the given two operands, and return the resulting
1247 /// instruction. There are two special cases: 1) if the constant operand is 0,
1248 /// it will return NULL. 2) if the constant is ~0, the symbolic operand will
1250 static Value *createAndInstr(Instruction *InsertBefore, Value *Opnd,
1251 const APInt &ConstOpnd) {
1252 if (ConstOpnd != 0) {
1253 if (!ConstOpnd.isAllOnesValue()) {
1254 LLVMContext &Ctx = Opnd->getType()->getContext();
1256 I = BinaryOperator::CreateAnd(Opnd, ConstantInt::get(Ctx, ConstOpnd),
1257 "and.ra", InsertBefore);
1258 I->setDebugLoc(InsertBefore->getDebugLoc());
1266 // Helper function of OptimizeXor(). It tries to simplify "Opnd1 ^ ConstOpnd"
1267 // into "R ^ C", where C would be 0, and R is a symbolic value.
1269 // If it was successful, true is returned, and the "R" and "C" is returned
1270 // via "Res" and "ConstOpnd", respectively; otherwise, false is returned,
1271 // and both "Res" and "ConstOpnd" remain unchanged.
1273 bool Reassociate::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1,
1274 APInt &ConstOpnd, Value *&Res) {
1275 // Xor-Rule 1: (x | c1) ^ c2 = (x | c1) ^ (c1 ^ c1) ^ c2
1276 // = ((x | c1) ^ c1) ^ (c1 ^ c2)
1277 // = (x & ~c1) ^ (c1 ^ c2)
1278 // It is useful only when c1 == c2.
1279 if (Opnd1->isOrExpr() && Opnd1->getConstPart() != 0) {
1280 if (!Opnd1->getValue()->hasOneUse())
1283 const APInt &C1 = Opnd1->getConstPart();
1284 if (C1 != ConstOpnd)
1287 Value *X = Opnd1->getSymbolicPart();
1288 Res = createAndInstr(I, X, ~C1);
1289 // ConstOpnd was C2, now C1 ^ C2.
1292 if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue()))
1293 RedoInsts.insert(T);
1300 // Helper function of OptimizeXor(). It tries to simplify
1301 // "Opnd1 ^ Opnd2 ^ ConstOpnd" into "R ^ C", where C would be 0, and R is a
1304 // If it was successful, true is returned, and the "R" and "C" is returned
1305 // via "Res" and "ConstOpnd", respectively (If the entire expression is
1306 // evaluated to a constant, the Res is set to NULL); otherwise, false is
1307 // returned, and both "Res" and "ConstOpnd" remain unchanged.
1308 bool Reassociate::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1, XorOpnd *Opnd2,
1309 APInt &ConstOpnd, Value *&Res) {
1310 Value *X = Opnd1->getSymbolicPart();
1311 if (X != Opnd2->getSymbolicPart())
1314 // This many instruction become dead.(At least "Opnd1 ^ Opnd2" will die.)
1315 int DeadInstNum = 1;
1316 if (Opnd1->getValue()->hasOneUse())
1318 if (Opnd2->getValue()->hasOneUse())
1322 // (x | c1) ^ (x & c2)
1323 // = (x|c1) ^ (x&c2) ^ (c1 ^ c1) = ((x|c1) ^ c1) ^ (x & c2) ^ c1
1324 // = (x & ~c1) ^ (x & c2) ^ c1 // Xor-Rule 1
1325 // = (x & c3) ^ c1, where c3 = ~c1 ^ c2 // Xor-rule 3
1327 if (Opnd1->isOrExpr() != Opnd2->isOrExpr()) {
1328 if (Opnd2->isOrExpr())
1329 std::swap(Opnd1, Opnd2);
1331 const APInt &C1 = Opnd1->getConstPart();
1332 const APInt &C2 = Opnd2->getConstPart();
1333 APInt C3((~C1) ^ C2);
1335 // Do not increase code size!
1336 if (C3 != 0 && !C3.isAllOnesValue()) {
1337 int NewInstNum = ConstOpnd != 0 ? 1 : 2;
1338 if (NewInstNum > DeadInstNum)
1342 Res = createAndInstr(I, X, C3);
1345 } else if (Opnd1->isOrExpr()) {
1346 // Xor-Rule 3: (x | c1) ^ (x | c2) = (x & c3) ^ c3 where c3 = c1 ^ c2
1348 const APInt &C1 = Opnd1->getConstPart();
1349 const APInt &C2 = Opnd2->getConstPart();
1352 // Do not increase code size
1353 if (C3 != 0 && !C3.isAllOnesValue()) {
1354 int NewInstNum = ConstOpnd != 0 ? 1 : 2;
1355 if (NewInstNum > DeadInstNum)
1359 Res = createAndInstr(I, X, C3);
1362 // Xor-Rule 4: (x & c1) ^ (x & c2) = (x & (c1^c2))
1364 const APInt &C1 = Opnd1->getConstPart();
1365 const APInt &C2 = Opnd2->getConstPart();
1367 Res = createAndInstr(I, X, C3);
1370 // Put the original operands in the Redo list; hope they will be deleted
1372 if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue()))
1373 RedoInsts.insert(T);
1374 if (Instruction *T = dyn_cast<Instruction>(Opnd2->getValue()))
1375 RedoInsts.insert(T);
1380 /// Optimize a series of operands to an 'xor' instruction. If it can be reduced
1381 /// to a single Value, it is returned, otherwise the Ops list is mutated as
1383 Value *Reassociate::OptimizeXor(Instruction *I,
1384 SmallVectorImpl<ValueEntry> &Ops) {
1385 if (Value *V = OptimizeAndOrXor(Instruction::Xor, Ops))
1388 if (Ops.size() == 1)
1391 SmallVector<XorOpnd, 8> Opnds;
1392 SmallVector<XorOpnd*, 8> OpndPtrs;
1393 Type *Ty = Ops[0].Op->getType();
1394 APInt ConstOpnd(Ty->getIntegerBitWidth(), 0);
1396 // Step 1: Convert ValueEntry to XorOpnd
1397 for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
1398 Value *V = Ops[i].Op;
1399 if (!isa<ConstantInt>(V)) {
1401 O.setSymbolicRank(getRank(O.getSymbolicPart()));
1404 ConstOpnd ^= cast<ConstantInt>(V)->getValue();
1407 // NOTE: From this point on, do *NOT* add/delete element to/from "Opnds".
1408 // It would otherwise invalidate the "Opnds"'s iterator, and hence invalidate
1409 // the "OpndPtrs" as well. For the similar reason, do not fuse this loop
1410 // with the previous loop --- the iterator of the "Opnds" may be invalidated
1411 // when new elements are added to the vector.
1412 for (unsigned i = 0, e = Opnds.size(); i != e; ++i)
1413 OpndPtrs.push_back(&Opnds[i]);
1415 // Step 2: Sort the Xor-Operands in a way such that the operands containing
1416 // the same symbolic value cluster together. For instance, the input operand
1417 // sequence ("x | 123", "y & 456", "x & 789") will be sorted into:
1418 // ("x | 123", "x & 789", "y & 456").
1419 std::stable_sort(OpndPtrs.begin(), OpndPtrs.end(), XorOpnd::PtrSortFunctor());
1421 // Step 3: Combine adjacent operands
1422 XorOpnd *PrevOpnd = nullptr;
1423 bool Changed = false;
1424 for (unsigned i = 0, e = Opnds.size(); i < e; i++) {
1425 XorOpnd *CurrOpnd = OpndPtrs[i];
1426 // The combined value
1429 // Step 3.1: Try simplifying "CurrOpnd ^ ConstOpnd"
1430 if (ConstOpnd != 0 && CombineXorOpnd(I, CurrOpnd, ConstOpnd, CV)) {
1433 *CurrOpnd = XorOpnd(CV);
1435 CurrOpnd->Invalidate();
1440 if (!PrevOpnd || CurrOpnd->getSymbolicPart() != PrevOpnd->getSymbolicPart()) {
1441 PrevOpnd = CurrOpnd;
1445 // step 3.2: When previous and current operands share the same symbolic
1446 // value, try to simplify "PrevOpnd ^ CurrOpnd ^ ConstOpnd"
1448 if (CombineXorOpnd(I, CurrOpnd, PrevOpnd, ConstOpnd, CV)) {
1449 // Remove previous operand
1450 PrevOpnd->Invalidate();
1452 *CurrOpnd = XorOpnd(CV);
1453 PrevOpnd = CurrOpnd;
1455 CurrOpnd->Invalidate();
1462 // Step 4: Reassemble the Ops
1465 for (unsigned int i = 0, e = Opnds.size(); i < e; i++) {
1466 XorOpnd &O = Opnds[i];
1469 ValueEntry VE(getRank(O.getValue()), O.getValue());
1472 if (ConstOpnd != 0) {
1473 Value *C = ConstantInt::get(Ty->getContext(), ConstOpnd);
1474 ValueEntry VE(getRank(C), C);
1477 int Sz = Ops.size();
1479 return Ops.back().Op;
1481 assert(ConstOpnd == 0);
1482 return ConstantInt::get(Ty->getContext(), ConstOpnd);
1489 /// OptimizeAdd - Optimize a series of operands to an 'add' instruction. This
1490 /// optimizes based on identities. If it can be reduced to a single Value, it
1491 /// is returned, otherwise the Ops list is mutated as necessary.
1492 Value *Reassociate::OptimizeAdd(Instruction *I,
1493 SmallVectorImpl<ValueEntry> &Ops) {
1494 // Scan the operand lists looking for X and -X pairs. If we find any, we
1495 // can simplify expressions like X+-X == 0 and X+~X ==-1. While we're at it,
1497 // duplicates. We want to canonicalize Y+Y+Y+Z -> 3*Y+Z.
1499 for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
1500 Value *TheOp = Ops[i].Op;
1501 // Check to see if we've seen this operand before. If so, we factor all
1502 // instances of the operand together. Due to our sorting criteria, we know
1503 // that these need to be next to each other in the vector.
1504 if (i+1 != Ops.size() && Ops[i+1].Op == TheOp) {
1505 // Rescan the list, remove all instances of this operand from the expr.
1506 unsigned NumFound = 0;
1508 Ops.erase(Ops.begin()+i);
1510 } while (i != Ops.size() && Ops[i].Op == TheOp);
1512 DEBUG(errs() << "\nFACTORING [" << NumFound << "]: " << *TheOp << '\n');
1515 // Insert a new multiply.
1516 Type *Ty = TheOp->getType();
1517 Constant *C = Ty->isIntegerTy() ? ConstantInt::get(Ty, NumFound)
1518 : ConstantFP::get(Ty, NumFound);
1519 Instruction *Mul = CreateMul(TheOp, C, "factor", I, I);
1521 // Now that we have inserted a multiply, optimize it. This allows us to
1522 // handle cases that require multiple factoring steps, such as this:
1523 // (X*2) + (X*2) + (X*2) -> (X*2)*3 -> X*6
1524 RedoInsts.insert(Mul);
1526 // If every add operand was a duplicate, return the multiply.
1530 // Otherwise, we had some input that didn't have the dupe, such as
1531 // "A + A + B" -> "A*2 + B". Add the new multiply to the list of
1532 // things being added by this operation.
1533 Ops.insert(Ops.begin(), ValueEntry(getRank(Mul), Mul));
1540 // Check for X and -X or X and ~X in the operand list.
1541 if (!BinaryOperator::isNeg(TheOp) && !BinaryOperator::isFNeg(TheOp) &&
1542 !BinaryOperator::isNot(TheOp))
1546 if (BinaryOperator::isNeg(TheOp) || BinaryOperator::isFNeg(TheOp))
1547 X = BinaryOperator::getNegArgument(TheOp);
1548 else if (BinaryOperator::isNot(TheOp))
1549 X = BinaryOperator::getNotArgument(TheOp);
1551 unsigned FoundX = FindInOperandList(Ops, i, X);
1555 // Remove X and -X from the operand list.
1556 if (Ops.size() == 2 &&
1557 (BinaryOperator::isNeg(TheOp) || BinaryOperator::isFNeg(TheOp)))
1558 return Constant::getNullValue(X->getType());
1560 // Remove X and ~X from the operand list.
1561 if (Ops.size() == 2 && BinaryOperator::isNot(TheOp))
1562 return Constant::getAllOnesValue(X->getType());
1564 Ops.erase(Ops.begin()+i);
1568 --i; // Need to back up an extra one.
1569 Ops.erase(Ops.begin()+FoundX);
1571 --i; // Revisit element.
1572 e -= 2; // Removed two elements.
1574 // if X and ~X we append -1 to the operand list.
1575 if (BinaryOperator::isNot(TheOp)) {
1576 Value *V = Constant::getAllOnesValue(X->getType());
1577 Ops.insert(Ops.end(), ValueEntry(getRank(V), V));
1582 // Scan the operand list, checking to see if there are any common factors
1583 // between operands. Consider something like A*A+A*B*C+D. We would like to
1584 // reassociate this to A*(A+B*C)+D, which reduces the number of multiplies.
1585 // To efficiently find this, we count the number of times a factor occurs
1586 // for any ADD operands that are MULs.
1587 DenseMap<Value*, unsigned> FactorOccurrences;
1589 // Keep track of each multiply we see, to avoid triggering on (X*4)+(X*4)
1590 // where they are actually the same multiply.
1591 unsigned MaxOcc = 0;
1592 Value *MaxOccVal = nullptr;
1593 for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
1594 BinaryOperator *BOp =
1595 isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul);
1599 // Compute all of the factors of this added value.
1600 SmallVector<Value*, 8> Factors;
1601 FindSingleUseMultiplyFactors(BOp, Factors, Ops);
1602 assert(Factors.size() > 1 && "Bad linearize!");
1604 // Add one to FactorOccurrences for each unique factor in this op.
1605 SmallPtrSet<Value*, 8> Duplicates;
1606 for (unsigned i = 0, e = Factors.size(); i != e; ++i) {
1607 Value *Factor = Factors[i];
1608 if (!Duplicates.insert(Factor))
1611 unsigned Occ = ++FactorOccurrences[Factor];
1617 // If Factor is a negative constant, add the negated value as a factor
1618 // because we can percolate the negate out. Watch for minint, which
1619 // cannot be positivified.
1620 if (ConstantInt *CI = dyn_cast<ConstantInt>(Factor)) {
1621 if (CI->isNegative() && !CI->isMinValue(true)) {
1622 Factor = ConstantInt::get(CI->getContext(), -CI->getValue());
1623 assert(!Duplicates.count(Factor) &&
1624 "Shouldn't have two constant factors, missed a canonicalize");
1625 unsigned Occ = ++FactorOccurrences[Factor];
1631 } else if (ConstantFP *CF = dyn_cast<ConstantFP>(Factor)) {
1632 if (CF->isNegative()) {
1633 APFloat F(CF->getValueAPF());
1635 Factor = ConstantFP::get(CF->getContext(), F);
1636 assert(!Duplicates.count(Factor) &&
1637 "Shouldn't have two constant factors, missed a canonicalize");
1638 unsigned Occ = ++FactorOccurrences[Factor];
1648 // If any factor occurred more than one time, we can pull it out.
1650 DEBUG(errs() << "\nFACTORING [" << MaxOcc << "]: " << *MaxOccVal << '\n');
1653 // Create a new instruction that uses the MaxOccVal twice. If we don't do
1654 // this, we could otherwise run into situations where removing a factor
1655 // from an expression will drop a use of maxocc, and this can cause
1656 // RemoveFactorFromExpression on successive values to behave differently.
1657 Instruction *DummyInst =
1658 I->getType()->isIntegerTy()
1659 ? BinaryOperator::CreateAdd(MaxOccVal, MaxOccVal)
1660 : BinaryOperator::CreateFAdd(MaxOccVal, MaxOccVal);
1662 SmallVector<WeakVH, 4> NewMulOps;
1663 for (unsigned i = 0; i != Ops.size(); ++i) {
1664 // Only try to remove factors from expressions we're allowed to.
1665 BinaryOperator *BOp =
1666 isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul);
1670 if (Value *V = RemoveFactorFromExpression(Ops[i].Op, MaxOccVal)) {
1671 // The factorized operand may occur several times. Convert them all in
1673 for (unsigned j = Ops.size(); j != i;) {
1675 if (Ops[j].Op == Ops[i].Op) {
1676 NewMulOps.push_back(V);
1677 Ops.erase(Ops.begin()+j);
1684 // No need for extra uses anymore.
1687 unsigned NumAddedValues = NewMulOps.size();
1688 Value *V = EmitAddTreeOfValues(I, NewMulOps);
1690 // Now that we have inserted the add tree, optimize it. This allows us to
1691 // handle cases that require multiple factoring steps, such as this:
1692 // A*A*B + A*A*C --> A*(A*B+A*C) --> A*(A*(B+C))
1693 assert(NumAddedValues > 1 && "Each occurrence should contribute a value");
1694 (void)NumAddedValues;
1695 if (Instruction *VI = dyn_cast<Instruction>(V))
1696 RedoInsts.insert(VI);
1698 // Create the multiply.
1699 Instruction *V2 = CreateMul(V, MaxOccVal, "tmp", I, I);
1701 // Rerun associate on the multiply in case the inner expression turned into
1702 // a multiply. We want to make sure that we keep things in canonical form.
1703 RedoInsts.insert(V2);
1705 // If every add operand included the factor (e.g. "A*B + A*C"), then the
1706 // entire result expression is just the multiply "A*(B+C)".
1710 // Otherwise, we had some input that didn't have the factor, such as
1711 // "A*B + A*C + D" -> "A*(B+C) + D". Add the new multiply to the list of
1712 // things being added by this operation.
1713 Ops.insert(Ops.begin(), ValueEntry(getRank(V2), V2));
1719 /// \brief Build up a vector of value/power pairs factoring a product.
1721 /// Given a series of multiplication operands, build a vector of factors and
1722 /// the powers each is raised to when forming the final product. Sort them in
1723 /// the order of descending power.
1725 /// (x*x) -> [(x, 2)]
1726 /// ((x*x)*x) -> [(x, 3)]
1727 /// ((((x*y)*x)*y)*x) -> [(x, 3), (y, 2)]
1729 /// \returns Whether any factors have a power greater than one.
1730 bool Reassociate::collectMultiplyFactors(SmallVectorImpl<ValueEntry> &Ops,
1731 SmallVectorImpl<Factor> &Factors) {
1732 // FIXME: Have Ops be (ValueEntry, Multiplicity) pairs, simplifying this.
1733 // Compute the sum of powers of simplifiable factors.
1734 unsigned FactorPowerSum = 0;
1735 for (unsigned Idx = 1, Size = Ops.size(); Idx < Size; ++Idx) {
1736 Value *Op = Ops[Idx-1].Op;
1738 // Count the number of occurrences of this value.
1740 for (; Idx < Size && Ops[Idx].Op == Op; ++Idx)
1742 // Track for simplification all factors which occur 2 or more times.
1744 FactorPowerSum += Count;
1747 // We can only simplify factors if the sum of the powers of our simplifiable
1748 // factors is 4 or higher. When that is the case, we will *always* have
1749 // a simplification. This is an important invariant to prevent cyclicly
1750 // trying to simplify already minimal formations.
1751 if (FactorPowerSum < 4)
1754 // Now gather the simplifiable factors, removing them from Ops.
1756 for (unsigned Idx = 1; Idx < Ops.size(); ++Idx) {
1757 Value *Op = Ops[Idx-1].Op;
1759 // Count the number of occurrences of this value.
1761 for (; Idx < Ops.size() && Ops[Idx].Op == Op; ++Idx)
1765 // Move an even number of occurrences to Factors.
1768 FactorPowerSum += Count;
1769 Factors.push_back(Factor(Op, Count));
1770 Ops.erase(Ops.begin()+Idx, Ops.begin()+Idx+Count);
1773 // None of the adjustments above should have reduced the sum of factor powers
1774 // below our mininum of '4'.
1775 assert(FactorPowerSum >= 4);
1777 std::stable_sort(Factors.begin(), Factors.end(), Factor::PowerDescendingSorter());
1781 /// \brief Build a tree of multiplies, computing the product of Ops.
1782 static Value *buildMultiplyTree(IRBuilder<> &Builder,
1783 SmallVectorImpl<Value*> &Ops) {
1784 if (Ops.size() == 1)
1787 Value *LHS = Ops.pop_back_val();
1789 if (LHS->getType()->isIntegerTy())
1790 LHS = Builder.CreateMul(LHS, Ops.pop_back_val());
1792 LHS = Builder.CreateFMul(LHS, Ops.pop_back_val());
1793 } while (!Ops.empty());
1798 /// \brief Build a minimal multiplication DAG for (a^x)*(b^y)*(c^z)*...
1800 /// Given a vector of values raised to various powers, where no two values are
1801 /// equal and the powers are sorted in decreasing order, compute the minimal
1802 /// DAG of multiplies to compute the final product, and return that product
1804 Value *Reassociate::buildMinimalMultiplyDAG(IRBuilder<> &Builder,
1805 SmallVectorImpl<Factor> &Factors) {
1806 assert(Factors[0].Power);
1807 SmallVector<Value *, 4> OuterProduct;
1808 for (unsigned LastIdx = 0, Idx = 1, Size = Factors.size();
1809 Idx < Size && Factors[Idx].Power > 0; ++Idx) {
1810 if (Factors[Idx].Power != Factors[LastIdx].Power) {
1815 // We want to multiply across all the factors with the same power so that
1816 // we can raise them to that power as a single entity. Build a mini tree
1818 SmallVector<Value *, 4> InnerProduct;
1819 InnerProduct.push_back(Factors[LastIdx].Base);
1821 InnerProduct.push_back(Factors[Idx].Base);
1823 } while (Idx < Size && Factors[Idx].Power == Factors[LastIdx].Power);
1825 // Reset the base value of the first factor to the new expression tree.
1826 // We'll remove all the factors with the same power in a second pass.
1827 Value *M = Factors[LastIdx].Base = buildMultiplyTree(Builder, InnerProduct);
1828 if (Instruction *MI = dyn_cast<Instruction>(M))
1829 RedoInsts.insert(MI);
1833 // Unique factors with equal powers -- we've folded them into the first one's
1835 Factors.erase(std::unique(Factors.begin(), Factors.end(),
1836 Factor::PowerEqual()),
1839 // Iteratively collect the base of each factor with an add power into the
1840 // outer product, and halve each power in preparation for squaring the
1842 for (unsigned Idx = 0, Size = Factors.size(); Idx != Size; ++Idx) {
1843 if (Factors[Idx].Power & 1)
1844 OuterProduct.push_back(Factors[Idx].Base);
1845 Factors[Idx].Power >>= 1;
1847 if (Factors[0].Power) {
1848 Value *SquareRoot = buildMinimalMultiplyDAG(Builder, Factors);
1849 OuterProduct.push_back(SquareRoot);
1850 OuterProduct.push_back(SquareRoot);
1852 if (OuterProduct.size() == 1)
1853 return OuterProduct.front();
1855 Value *V = buildMultiplyTree(Builder, OuterProduct);
1859 Value *Reassociate::OptimizeMul(BinaryOperator *I,
1860 SmallVectorImpl<ValueEntry> &Ops) {
1861 // We can only optimize the multiplies when there is a chain of more than
1862 // three, such that a balanced tree might require fewer total multiplies.
1866 // Try to turn linear trees of multiplies without other uses of the
1867 // intermediate stages into minimal multiply DAGs with perfect sub-expression
1869 SmallVector<Factor, 4> Factors;
1870 if (!collectMultiplyFactors(Ops, Factors))
1871 return nullptr; // All distinct factors, so nothing left for us to do.
1873 IRBuilder<> Builder(I);
1874 Value *V = buildMinimalMultiplyDAG(Builder, Factors);
1878 ValueEntry NewEntry = ValueEntry(getRank(V), V);
1879 Ops.insert(std::lower_bound(Ops.begin(), Ops.end(), NewEntry), NewEntry);
1883 Value *Reassociate::OptimizeExpression(BinaryOperator *I,
1884 SmallVectorImpl<ValueEntry> &Ops) {
1885 // Now that we have the linearized expression tree, try to optimize it.
1886 // Start by folding any constants that we found.
1887 Constant *Cst = nullptr;
1888 unsigned Opcode = I->getOpcode();
1889 while (!Ops.empty() && isa<Constant>(Ops.back().Op)) {
1890 Constant *C = cast<Constant>(Ops.pop_back_val().Op);
1891 Cst = Cst ? ConstantExpr::get(Opcode, C, Cst) : C;
1893 // If there was nothing but constants then we are done.
1897 // Put the combined constant back at the end of the operand list, except if
1898 // there is no point. For example, an add of 0 gets dropped here, while a
1899 // multiplication by zero turns the whole expression into zero.
1900 if (Cst && Cst != ConstantExpr::getBinOpIdentity(Opcode, I->getType())) {
1901 if (Cst == ConstantExpr::getBinOpAbsorber(Opcode, I->getType()))
1903 Ops.push_back(ValueEntry(0, Cst));
1906 if (Ops.size() == 1) return Ops[0].Op;
1908 // Handle destructive annihilation due to identities between elements in the
1909 // argument list here.
1910 unsigned NumOps = Ops.size();
1913 case Instruction::And:
1914 case Instruction::Or:
1915 if (Value *Result = OptimizeAndOrXor(Opcode, Ops))
1919 case Instruction::Xor:
1920 if (Value *Result = OptimizeXor(I, Ops))
1924 case Instruction::Add:
1925 case Instruction::FAdd:
1926 if (Value *Result = OptimizeAdd(I, Ops))
1930 case Instruction::Mul:
1931 case Instruction::FMul:
1932 if (Value *Result = OptimizeMul(I, Ops))
1937 if (Ops.size() != NumOps)
1938 return OptimizeExpression(I, Ops);
1942 /// EraseInst - Zap the given instruction, adding interesting operands to the
1944 void Reassociate::EraseInst(Instruction *I) {
1945 assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!");
1946 SmallVector<Value*, 8> Ops(I->op_begin(), I->op_end());
1947 // Erase the dead instruction.
1948 ValueRankMap.erase(I);
1949 RedoInsts.remove(I);
1950 I->eraseFromParent();
1951 // Optimize its operands.
1952 SmallPtrSet<Instruction *, 8> Visited; // Detect self-referential nodes.
1953 for (unsigned i = 0, e = Ops.size(); i != e; ++i)
1954 if (Instruction *Op = dyn_cast<Instruction>(Ops[i])) {
1955 // If this is a node in an expression tree, climb to the expression root
1956 // and add that since that's where optimization actually happens.
1957 unsigned Opcode = Op->getOpcode();
1958 while (Op->hasOneUse() && Op->user_back()->getOpcode() == Opcode &&
1960 Op = Op->user_back();
1961 RedoInsts.insert(Op);
1965 // Canonicalize expressions of the following form:
1966 // x + (-Constant * y) -> x - (Constant * y)
1967 // x - (-Constant * y) -> x + (Constant * y)
1968 Instruction *Reassociate::canonicalizeNegConstExpr(Instruction *I) {
1969 if (!I->hasOneUse() || I->getType()->isVectorTy())
1972 // Must be a mul, fmul, or fdiv instruction.
1973 unsigned Opcode = I->getOpcode();
1974 if (Opcode != Instruction::Mul && Opcode != Instruction::FMul &&
1975 Opcode != Instruction::FDiv)
1978 // Must have at least one constant operand.
1979 Constant *C0 = dyn_cast<Constant>(I->getOperand(0));
1980 Constant *C1 = dyn_cast<Constant>(I->getOperand(1));
1984 // Must be a negative ConstantInt or ConstantFP.
1985 Constant *C = C0 ? C0 : C1;
1986 unsigned ConstIdx = C0 ? 0 : 1;
1987 if (auto *CI = dyn_cast<ConstantInt>(C)) {
1988 if (!CI->isNegative())
1990 } else if (auto *CF = dyn_cast<ConstantFP>(C)) {
1991 if (!CF->isNegative())
1996 // User must be a binary operator with one or more uses.
1997 Instruction *User = I->user_back();
1998 if (!isa<BinaryOperator>(User) || !User->getNumUses())
2001 unsigned UserOpcode = User->getOpcode();
2002 if (UserOpcode != Instruction::Add && UserOpcode != Instruction::FAdd &&
2003 UserOpcode != Instruction::Sub && UserOpcode != Instruction::FSub)
2006 // Subtraction is not commutative. Explicitly, the following transform is
2007 // not valid: (-Constant * y) - x -> x + (Constant * y)
2008 if (!User->isCommutative() && User->getOperand(1) != I)
2011 // Change the sign of the constant.
2012 if (ConstantInt *CI = dyn_cast<ConstantInt>(C))
2013 I->setOperand(ConstIdx, ConstantInt::get(CI->getContext(), -CI->getValue()));
2015 ConstantFP *CF = cast<ConstantFP>(C);
2016 APFloat Val = CF->getValueAPF();
2018 I->setOperand(ConstIdx, ConstantFP::get(CF->getContext(), Val));
2021 // Canonicalize I to RHS to simplify the next bit of logic. E.g.,
2022 // ((-Const*y) + x) -> (x + (-Const*y)).
2023 if (User->getOperand(0) == I && User->isCommutative())
2024 cast<BinaryOperator>(User)->swapOperands();
2026 Value *Op0 = User->getOperand(0);
2027 Value *Op1 = User->getOperand(1);
2029 switch(UserOpcode) {
2031 llvm_unreachable("Unexpected Opcode!");
2032 case Instruction::Add:
2033 NI = BinaryOperator::CreateSub(Op0, Op1);
2035 case Instruction::Sub:
2036 NI = BinaryOperator::CreateAdd(Op0, Op1);
2038 case Instruction::FAdd:
2039 NI = BinaryOperator::CreateFSub(Op0, Op1);
2040 NI->setFastMathFlags(cast<FPMathOperator>(User)->getFastMathFlags());
2042 case Instruction::FSub:
2043 NI = BinaryOperator::CreateFAdd(Op0, Op1);
2044 NI->setFastMathFlags(cast<FPMathOperator>(User)->getFastMathFlags());
2048 NI->insertBefore(User);
2049 NI->setName(User->getName());
2050 User->replaceAllUsesWith(NI);
2051 NI->setDebugLoc(I->getDebugLoc());
2052 RedoInsts.insert(I);
2057 /// OptimizeInst - Inspect and optimize the given instruction. Note that erasing
2058 /// instructions is not allowed.
2059 void Reassociate::OptimizeInst(Instruction *I) {
2060 // Only consider operations that we understand.
2061 if (!isa<BinaryOperator>(I))
2064 if (I->getOpcode() == Instruction::Shl && isa<ConstantInt>(I->getOperand(1)))
2065 // If an operand of this shift is a reassociable multiply, or if the shift
2066 // is used by a reassociable multiply or add, turn into a multiply.
2067 if (isReassociableOp(I->getOperand(0), Instruction::Mul) ||
2069 (isReassociableOp(I->user_back(), Instruction::Mul) ||
2070 isReassociableOp(I->user_back(), Instruction::Add)))) {
2071 Instruction *NI = ConvertShiftToMul(I);
2072 RedoInsts.insert(I);
2077 // Canonicalize negative constants out of expressions.
2078 if (Instruction *Res = canonicalizeNegConstExpr(I))
2081 // Commute binary operators, to canonicalize the order of their operands.
2082 // This can potentially expose more CSE opportunities, and makes writing other
2083 // transformations simpler.
2084 if (I->isCommutative())
2085 canonicalizeOperands(I);
2087 // Don't optimize vector instructions.
2088 if (I->getType()->isVectorTy())
2091 // Don't optimize floating point instructions that don't have unsafe algebra.
2092 if (I->getType()->isFloatingPointTy() && !I->hasUnsafeAlgebra())
2095 // Do not reassociate boolean (i1) expressions. We want to preserve the
2096 // original order of evaluation for short-circuited comparisons that
2097 // SimplifyCFG has folded to AND/OR expressions. If the expression
2098 // is not further optimized, it is likely to be transformed back to a
2099 // short-circuited form for code gen, and the source order may have been
2100 // optimized for the most likely conditions.
2101 if (I->getType()->isIntegerTy(1))
2104 // If this is a subtract instruction which is not already in negate form,
2105 // see if we can convert it to X+-Y.
2106 if (I->getOpcode() == Instruction::Sub) {
2107 if (ShouldBreakUpSubtract(I)) {
2108 Instruction *NI = BreakUpSubtract(I);
2109 RedoInsts.insert(I);
2112 } else if (BinaryOperator::isNeg(I)) {
2113 // Otherwise, this is a negation. See if the operand is a multiply tree
2114 // and if this is not an inner node of a multiply tree.
2115 if (isReassociableOp(I->getOperand(1), Instruction::Mul) &&
2117 !isReassociableOp(I->user_back(), Instruction::Mul))) {
2118 Instruction *NI = LowerNegateToMultiply(I);
2119 RedoInsts.insert(I);
2124 } else if (I->getOpcode() == Instruction::FSub) {
2125 if (ShouldBreakUpSubtract(I)) {
2126 Instruction *NI = BreakUpSubtract(I);
2127 RedoInsts.insert(I);
2130 } else if (BinaryOperator::isFNeg(I)) {
2131 // Otherwise, this is a negation. See if the operand is a multiply tree
2132 // and if this is not an inner node of a multiply tree.
2133 if (isReassociableOp(I->getOperand(1), Instruction::FMul) &&
2135 !isReassociableOp(I->user_back(), Instruction::FMul))) {
2136 Instruction *NI = LowerNegateToMultiply(I);
2137 RedoInsts.insert(I);
2144 // If this instruction is an associative binary operator, process it.
2145 if (!I->isAssociative()) return;
2146 BinaryOperator *BO = cast<BinaryOperator>(I);
2148 // If this is an interior node of a reassociable tree, ignore it until we
2149 // get to the root of the tree, to avoid N^2 analysis.
2150 unsigned Opcode = BO->getOpcode();
2151 if (BO->hasOneUse() && BO->user_back()->getOpcode() == Opcode)
2154 // If this is an add tree that is used by a sub instruction, ignore it
2155 // until we process the subtract.
2156 if (BO->hasOneUse() && BO->getOpcode() == Instruction::Add &&
2157 cast<Instruction>(BO->user_back())->getOpcode() == Instruction::Sub)
2159 if (BO->hasOneUse() && BO->getOpcode() == Instruction::FAdd &&
2160 cast<Instruction>(BO->user_back())->getOpcode() == Instruction::FSub)
2163 ReassociateExpression(BO);
2166 void Reassociate::ReassociateExpression(BinaryOperator *I) {
2167 assert(!I->getType()->isVectorTy() &&
2168 "Reassociation of vector instructions is not supported.");
2170 // First, walk the expression tree, linearizing the tree, collecting the
2171 // operand information.
2172 SmallVector<RepeatedValue, 8> Tree;
2173 MadeChange |= LinearizeExprTree(I, Tree);
2174 SmallVector<ValueEntry, 8> Ops;
2175 Ops.reserve(Tree.size());
2176 for (unsigned i = 0, e = Tree.size(); i != e; ++i) {
2177 RepeatedValue E = Tree[i];
2178 Ops.append(E.second.getZExtValue(),
2179 ValueEntry(getRank(E.first), E.first));
2182 DEBUG(dbgs() << "RAIn:\t"; PrintOps(I, Ops); dbgs() << '\n');
2184 // Now that we have linearized the tree to a list and have gathered all of
2185 // the operands and their ranks, sort the operands by their rank. Use a
2186 // stable_sort so that values with equal ranks will have their relative
2187 // positions maintained (and so the compiler is deterministic). Note that
2188 // this sorts so that the highest ranking values end up at the beginning of
2190 std::stable_sort(Ops.begin(), Ops.end());
2192 // OptimizeExpression - Now that we have the expression tree in a convenient
2193 // sorted form, optimize it globally if possible.
2194 if (Value *V = OptimizeExpression(I, Ops)) {
2196 // Self-referential expression in unreachable code.
2198 // This expression tree simplified to something that isn't a tree,
2200 DEBUG(dbgs() << "Reassoc to scalar: " << *V << '\n');
2201 I->replaceAllUsesWith(V);
2202 if (Instruction *VI = dyn_cast<Instruction>(V))
2203 VI->setDebugLoc(I->getDebugLoc());
2204 RedoInsts.insert(I);
2209 // We want to sink immediates as deeply as possible except in the case where
2210 // this is a multiply tree used only by an add, and the immediate is a -1.
2211 // In this case we reassociate to put the negation on the outside so that we
2212 // can fold the negation into the add: (-X)*Y + Z -> Z-X*Y
2213 if (I->hasOneUse()) {
2214 if (I->getOpcode() == Instruction::Mul &&
2215 cast<Instruction>(I->user_back())->getOpcode() == Instruction::Add &&
2216 isa<ConstantInt>(Ops.back().Op) &&
2217 cast<ConstantInt>(Ops.back().Op)->isAllOnesValue()) {
2218 ValueEntry Tmp = Ops.pop_back_val();
2219 Ops.insert(Ops.begin(), Tmp);
2220 } else if (I->getOpcode() == Instruction::FMul &&
2221 cast<Instruction>(I->user_back())->getOpcode() ==
2222 Instruction::FAdd &&
2223 isa<ConstantFP>(Ops.back().Op) &&
2224 cast<ConstantFP>(Ops.back().Op)->isExactlyValue(-1.0)) {
2225 ValueEntry Tmp = Ops.pop_back_val();
2226 Ops.insert(Ops.begin(), Tmp);
2230 DEBUG(dbgs() << "RAOut:\t"; PrintOps(I, Ops); dbgs() << '\n');
2232 if (Ops.size() == 1) {
2234 // Self-referential expression in unreachable code.
2237 // This expression tree simplified to something that isn't a tree,
2239 I->replaceAllUsesWith(Ops[0].Op);
2240 if (Instruction *OI = dyn_cast<Instruction>(Ops[0].Op))
2241 OI->setDebugLoc(I->getDebugLoc());
2242 RedoInsts.insert(I);
2246 // Now that we ordered and optimized the expressions, splat them back into
2247 // the expression tree, removing any unneeded nodes.
2248 RewriteExprTree(I, Ops);
2251 bool Reassociate::runOnFunction(Function &F) {
2252 if (skipOptnoneFunction(F))
2255 // Calculate the rank map for F
2259 for (Function::iterator BI = F.begin(), BE = F.end(); BI != BE; ++BI) {
2260 // Optimize every instruction in the basic block.
2261 for (BasicBlock::iterator II = BI->begin(), IE = BI->end(); II != IE; )
2262 if (isInstructionTriviallyDead(II)) {
2266 assert(II->getParent() == BI && "Moved to a different block!");
2270 // If this produced extra instructions to optimize, handle them now.
2271 while (!RedoInsts.empty()) {
2272 Instruction *I = RedoInsts.pop_back_val();
2273 if (isInstructionTriviallyDead(I))
2280 // We are done with the rank map.
2282 ValueRankMap.clear();