From 6d292c921178f1446efa72c7412a0efe3609fcf6 Mon Sep 17 00:00:00 2001 From: rtrimana Date: Tue, 22 Oct 2019 11:10:26 -0700 Subject: [PATCH 1/1] Integrating List of constant names into the if-statement to avoid creating read/write field access. --- Event/Event.groovy | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Event/Event.groovy b/Event/Event.groovy index 15e3458..d7abdf4 100644 --- a/Event/Event.groovy +++ b/Event/Event.groovy @@ -16,8 +16,6 @@ public class Event { private jsonData private int integerValue private double doubleValue - private List integerValues = ["battery", "hue", "saturation", "energy", "level", "temperature", - "heatingSetpoint", "coolingSetpoint", "thermostatSetpoint", "illuminance"] private boolean physical private def date @@ -33,10 +31,10 @@ public class Event { this.data = data this.jsonData = new groovy.json.JsonSlurper().parseText(data) this.displayed = displayed - if (integerValues.contains(name)) { + if (["battery", "hue", "saturation", "energy", "level", "temperature", "heatingSetpoint", "coolingSetpoint", "thermostatSetpoint", "illuminance"].contains(name)) { int dot = value.indexOf('.') if (dot != -1) - value = value.substring(0, dot) + value = value.substring(0, dot) this.integerValue = value.toInteger() this.doubleValue = Double.parseDouble(value); } -- 2.34.1