From f7d58f12fa2377090dd844e52662e5a942606d0f Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Wed, 2 Dec 2015 02:00:29 +0000 Subject: [PATCH] Modify FunctionImport to take a callback to load modules When linking static archive, there is no individual module files to load. Instead they can be mmap'ed and could be initialized from a buffer directly. The callback provide flexibility to override the scheme for loading module from the summary. Differential Revision: http://reviews.llvm.org/D15101 From: Mehdi Amini git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@254479 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Transforms/IPO/FunctionImport.h | 31 ++++++++++++++------ lib/Transforms/IPO/FunctionImport.cpp | 11 ++++--- 2 files changed, 29 insertions(+), 13 deletions(-) diff --git a/include/llvm/Transforms/IPO/FunctionImport.h b/include/llvm/Transforms/IPO/FunctionImport.h index f06a1902175..0315c72811c 100644 --- a/include/llvm/Transforms/IPO/FunctionImport.h +++ b/include/llvm/Transforms/IPO/FunctionImport.h @@ -18,15 +18,26 @@ class LLVMContext; class Module; class FunctionInfoIndex; -/// The function importer is automatically importing function from other modules -/// based on the provided summary informations. -class FunctionImporter { +/// Helper to load on demand a Module from file and cache it for subsequent +/// queries. It can be used with the FunctionImporter. +class ModuleLazyLoaderCache { + /// The context that will be used for importing. + LLVMContext &Context; /// Cache of lazily loaded module for import. StringMap> ModuleMap; - /// The context that will be used for importing. - LLVMContext &Context; +public: + /// Create the loader, Module will be initialized in \p Context. + ModuleLazyLoaderCache(LLVMContext &Context) : Context(Context) {} + + /// Retrieve a Module from the cache or lazily load it on demand. + Module &operator()(StringRef FileName); +}; + +/// The function importer is automatically importing function from other modules +/// based on the provided summary informations. +class FunctionImporter { /// The summaries index used to trigger importing. const FunctionInfoIndex &Index; @@ -35,13 +46,15 @@ class FunctionImporter { DiagnosticHandlerFunction DiagnosticHandler; /// Retrieve a Module from the cache or lazily load it on demand. - Module &getOrLoadModule(StringRef FileName); + std::function getLazyModule; public: /// Create a Function Importer. - FunctionImporter(LLVMContext &Context, const FunctionInfoIndex &Index, - DiagnosticHandlerFunction DiagnosticHandler) - : Context(Context), Index(Index), DiagnosticHandler(DiagnosticHandler) {} + FunctionImporter(const FunctionInfoIndex &Index, + DiagnosticHandlerFunction DiagnosticHandler, + std::function ModuleLoader) + : Index(Index), DiagnosticHandler(DiagnosticHandler), + getLazyModule(ModuleLoader) {} /// Import functions in Module \p M based on the summary informations. bool importFunctions(Module &M); diff --git a/lib/Transforms/IPO/FunctionImport.cpp b/lib/Transforms/IPO/FunctionImport.cpp index 444da3c55d2..92764c9e8c3 100644 --- a/lib/Transforms/IPO/FunctionImport.cpp +++ b/lib/Transforms/IPO/FunctionImport.cpp @@ -51,7 +51,7 @@ static std::unique_ptr loadFile(const std::string &FileName, } // Get a Module for \p FileName from the cache, or load it lazily. -Module &FunctionImporter::getOrLoadModule(StringRef FileName) { +Module &ModuleLazyLoaderCache::operator()(StringRef FileName) { auto &Module = ModuleMap[FileName]; if (!Module) Module = loadFile(FileName, Context); @@ -86,7 +86,6 @@ static void findExternalCalls(const Function &F, StringSet<> &CalledFunctions, // The current implementation imports every called functions that exists in the // summaries index. bool FunctionImporter::importFunctions(Module &M) { - assert(&Context == &M.getContext()); bool Changed = false; @@ -142,7 +141,8 @@ bool FunctionImporter::importFunctions(Module &M) { << "\n"); // Get the module for the import (potentially from the cache). - auto &Module = getOrLoadModule(FileName); + auto &Module = getLazyModule(FileName); + assert(&Module.getContext() == &M.getContext()); // The function that we will import! GlobalValue *SGV = Module.getNamedValue(CalledFunctionName); @@ -255,7 +255,10 @@ public: } // Perform the import now. - FunctionImporter Importer(M.getContext(), *Index, diagnosticHandler); + ModuleLazyLoaderCache Loader(M.getContext()); + FunctionImporter Importer(*Index, diagnosticHandler, + [&](StringRef Name) + -> Module &{ return Loader(Name); }); return Importer.importFunctions(M); return false; -- 2.34.1