From e8ff062325fc071d5773d26d7cba5d69582e49db Mon Sep 17 00:00:00 2001
From: Rafael Espindola <rafael.espindola@gmail.com>
Date: Tue, 30 Jun 2015 14:59:20 +0000
Subject: [PATCH] Report an error on invalid sh_entsize.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241070 91177308-0d34-0410-b5e6-96231b3b80d8
---
 include/llvm/Object/ELF.h                 |  19 +++++++------
 test/Object/Inputs/invalid-sh_entsize.elf | Bin 0 -> 1736 bytes
 test/Object/invalid.test                  |  32 ++++++++++++++++++++++
 3 files changed, 43 insertions(+), 8 deletions(-)
 create mode 100755 test/Object/Inputs/invalid-sh_entsize.elf

diff --git a/include/llvm/Object/ELF.h b/include/llvm/Object/ELF.h
index 0cb5c7a81ca..4c9cacd7e51 100644
--- a/include/llvm/Object/ELF.h
+++ b/include/llvm/Object/ELF.h
@@ -285,17 +285,18 @@ public:
   }
 
   const Elf_Sym *begin_dynamic_symbols() const {
-    if (DynSymRegion.Addr)
-      return reinterpret_cast<const Elf_Sym *>(DynSymRegion.Addr);
-    return nullptr;
+    if (!DynSymRegion.Addr)
+      return nullptr;
+    if (DynSymRegion.EntSize != sizeof(Elf_Sym))
+      report_fatal_error("Invalid symbol size");
+    return reinterpret_cast<const Elf_Sym *>(DynSymRegion.Addr);
   }
 
   const Elf_Sym *end_dynamic_symbols() const {
-    if (DynSymRegion.Addr)
-      return reinterpret_cast<const Elf_Sym *>(
-          ((const char *)DynSymRegion.Addr + DynSymRegion.Size));
-
-    return nullptr;
+    if (!DynSymRegion.Addr)
+      return nullptr;
+    return reinterpret_cast<const Elf_Sym *>(
+        ((const char *)DynSymRegion.Addr + DynSymRegion.Size));
   }
 
   Elf_Sym_Range dynamic_symbols() const {
@@ -766,6 +767,8 @@ template <class ELFT>
 const typename ELFFile<ELFT>::Elf_Sym *ELFFile<ELFT>::begin_symbols() const {
   if (!dot_symtab_sec)
     return nullptr;
+  if (dot_symtab_sec->sh_entsize != sizeof(Elf_Sym))
+    report_fatal_error("Invalid symbol size");
   return reinterpret_cast<const Elf_Sym *>(base() + dot_symtab_sec->sh_offset);
 }
 
diff --git a/test/Object/Inputs/invalid-sh_entsize.elf b/test/Object/Inputs/invalid-sh_entsize.elf
new file mode 100755
index 0000000000000000000000000000000000000000..9ea80731491c18aa7769b97262538a6483c75a39
GIT binary patch
literal 1736
zcmcIk!AcuZ6un8*s>vd1k%9%Y=%P^iAh^*@Nn6_@L|3{H3SrU-Nx)1XGnQoKFJ#%z
z$g-c%&&V(M1$xiCdq^0QmMUJDIq#kO&b#-$duMLG)W7C)IiVHggUn_kHFNwaa0R$S
zS<!b%in6Bkias@SXK`vgaoy&Kv1;Q*FtsFzQueDrBPRLjmgk8RKNTW%`Tx{0PuuPR
zAdj-1oOy5ouBj}ycjIj`9ygcpyGwWpq|pk4M4{1)<3^kWgG8w)^!p(W?hog}{m+$0
zXWn>Mm{sgPi{^V}$Qt}IKk|g_c}Vxh@VEJmem1~aHuM30JG+o}|0=9hUA6j;h)6G&
zUzKbh_<Mg?r;@H;RHvOK{QeSN8poGsA5Tv{|E*vyX$=!`T1Ro=D2kJTxTv4BTsyjU
zIN|%BtwG%FN8UZ^iR%P$C!Gbo?hkQsM@31{)DdyiOXq2iXmU@qcdAEkpr2su7vj*<
zsULUE@1tTo?h`#oJ^P8sezN6~ZKnfuu%EGp{YHFiLh2YFeF97CuZVvGY-$UMo}Im^
zBXgt!X!#wnkErMWgy&;?`z^_L)gmPI{Qk!jsBhk~@n5JDdp=hGQnlD4YmEOo<H*K8
vSO20^Cq|A<kM9W-&tEaVuE^YtN}*=tn|V^ltRv}9I#{F+jcjtEVOD<++fi>U

literal 0
HcmV?d00001

diff --git a/test/Object/invalid.test b/test/Object/invalid.test
index 73a6ad8021a..88685fab20c 100644
--- a/test/Object/invalid.test
+++ b/test/Object/invalid.test
@@ -5,3 +5,35 @@ CHECK: Invalid data was encountered while parsing the file
 
 RUN: not llvm-objdump -s %p/Inputs/invalid-strtab-non-null.elf 2>&1 | FileCheck --check-prefix=NON-NULL %s
 NON-NULL: String table must end with a null terminator
+
+Test the sh_entsize are invalid
+RUN: llvm-readobj -s %p/Inputs/invalid-sh_entsize.elf | FileCheck --check-prefix=SECTION %s
+
+SECTION:         Name: .dynsym
+SECTION-NEXT:    Type: SHT_DYNSYM
+SECTION-NEXT:    Flags [
+SECTION-NEXT:      SHF_ALLOC
+SECTION-NEXT:    ]
+SECTION-NEXT:    Address:
+SECTION-NEXT:    Offset:
+SECTION-NEXT:    Size:
+SECTION-NEXT:    Link:
+SECTION-NEXT:    Info:
+SECTION-NEXT:    AddressAlignment:
+SECTION-NEXT:    EntrySize: 32
+
+SECTION:         Name: .symtab
+SECTION-NEXT:    Type: SHT_SYMTAB
+SECTION-NEXT:    Flags [
+SECTION-NEXT:    ]
+SECTION-NEXT:    Address:
+SECTION-NEXT:    Offset:
+SECTION-NEXT:    Size:
+SECTION-NEXT:    Link:
+SECTION-NEXT:    Info:
+SECTION-NEXT:    AddressAlignment:
+SECTION-NEXT:    EntrySize: 32
+
+RUN: not llvm-readobj -t %p/Inputs/invalid-sh_entsize.elf 2>&1 | FileCheck --check-prefix=INVALID-SYM-SIZE %s
+RUN: not llvm-readobj --dyn-symbols %p/Inputs/invalid-sh_entsize.elf 2>&1 | FileCheck --check-prefix=INVALID-SYM-SIZE %s
+INVALID-SYM-SIZE: Invalid symbol size
-- 
2.34.1