From e1ef1867304e6858a290939d38193ce6e4cfe1ad Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Tue, 1 Dec 2015 02:35:04 +0000 Subject: [PATCH] [Windows] Simplify assertion code. NFC. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@254363 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/Windows/DynamicLibrary.inc | 6 ++---- lib/Support/Windows/Signals.inc | 5 +---- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/Support/Windows/DynamicLibrary.inc b/lib/Support/Windows/DynamicLibrary.inc index 17418b015c7..77146d47cf2 100644 --- a/lib/Support/Windows/DynamicLibrary.inc +++ b/lib/Support/Windows/DynamicLibrary.inc @@ -61,10 +61,8 @@ DynamicLibrary DynamicLibrary::getPermanentLibrary(const char *filename, OpenedHandles = new DenseSet(); if (!fEnumerateLoadedModules) { - if (!loadDebugHelp()) { - assert(false && "These APIs should always be available"); - return DynamicLibrary(); - } + assert(loadDebugHelp() && "These APIs should always be available"); + return DynamicLibrary(); } fEnumerateLoadedModules(GetCurrentProcess(), ELM_Callback, 0); diff --git a/lib/Support/Windows/Signals.inc b/lib/Support/Windows/Signals.inc index f40ca72996a..d109a66d703 100644 --- a/lib/Support/Windows/Signals.inc +++ b/lib/Support/Windows/Signals.inc @@ -405,10 +405,7 @@ static void RegisterHandler() { // If we cannot load up the APIs (which would be unexpected as they should // exist on every version of Windows we support), we will bail out since // there would be nothing to report. - if (!load64BitDebugHelp()) { - assert(false && "These APIs should always be available"); - return; - } + assert(load64BitDebugHelp() && "These APIs should always be available"); if (RegisteredUnhandledExceptionFilter) { EnterCriticalSection(&CriticalSection); -- 2.34.1