From df43fcd565b58c06b2e20f6fccb71a61debb42d1 Mon Sep 17 00:00:00 2001 From: Michael Zolotukhin Date: Sat, 24 Oct 2015 20:16:42 +0000 Subject: [PATCH] Refactor: Simplify boolean conditional return statements in lib/Transforms/Vectorize (NFC). Summary: Use clang-tidy to simplify boolean conditional return statements Differential Revision: http://reviews.llvm.org/D10003 Patch by Richard git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251206 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Vectorize/LoopVectorize.cpp | 5 ++--- lib/Transforms/Vectorize/SLPVectorizer.cpp | 11 +++-------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/lib/Transforms/Vectorize/LoopVectorize.cpp b/lib/Transforms/Vectorize/LoopVectorize.cpp index 2381b63b767..c61a496b747 100644 --- a/lib/Transforms/Vectorize/LoopVectorize.cpp +++ b/lib/Transforms/Vectorize/LoopVectorize.cpp @@ -5215,9 +5215,8 @@ static bool isLikelyComplexAddressComputation(Value *Ptr, } static bool isStrideMul(Instruction *I, LoopVectorizationLegality *Legal) { - if (Legal->hasStride(I->getOperand(0)) || Legal->hasStride(I->getOperand(1))) - return true; - return false; + return Legal->hasStride(I->getOperand(0)) || + Legal->hasStride(I->getOperand(1)); } unsigned diff --git a/lib/Transforms/Vectorize/SLPVectorizer.cpp b/lib/Transforms/Vectorize/SLPVectorizer.cpp index 57b09caa5a4..5cd187877dd 100644 --- a/lib/Transforms/Vectorize/SLPVectorizer.cpp +++ b/lib/Transforms/Vectorize/SLPVectorizer.cpp @@ -168,10 +168,8 @@ static unsigned getAltOpcode(unsigned Op) { /// of an alternate sequence which can later be merged as /// a ShuffleVector instruction. static bool canCombineAsAltInst(unsigned Op) { - if (Op == Instruction::FAdd || Op == Instruction::FSub || - Op == Instruction::Sub || Op == Instruction::Add) - return true; - return false; + return Op == Instruction::FAdd || Op == Instruction::FSub || + Op == Instruction::Sub || Op == Instruction::Add; } /// \returns ShuffleVector instruction if instructions in \p VL have @@ -1990,10 +1988,7 @@ static bool shouldReorderOperands(int i, Instruction &I, return false; } // One opcode, put the instruction on the right. - if (ILeft) { - return true; - } - return false; + return ILeft != nullptr; } void BoUpSLP::reorderInputsAccordingToOpcode(ArrayRef VL, -- 2.34.1