From d35fbff07e990d3ba7eb4bae23bac303439f86c9 Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Sat, 31 Oct 2015 20:59:32 +0000 Subject: [PATCH] [SimplifyLibCalls] Add test to ensure transform is not executed if fast-math attribute is not present. During my refactor in r251595 I changed the behavior of optimizeSqrt(), skipping the transformation if the function wasn't marked with unsafe-fp-math attribute. This fixed a bug, as confirmed by Sanjay (before the optimization was silently executed anyway), although it wasn't my primary aim. This commit adds a test to ensure the code doesn't break again. Reported by: Marcello Maggioni Discussed with: Sanjay Patel git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251747 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/Transforms/InstCombine/sqrt-nofast.ll | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 test/Transforms/InstCombine/sqrt-nofast.ll diff --git a/test/Transforms/InstCombine/sqrt-nofast.ll b/test/Transforms/InstCombine/sqrt-nofast.ll new file mode 100644 index 00000000000..0d1dfc1542a --- /dev/null +++ b/test/Transforms/InstCombine/sqrt-nofast.ll @@ -0,0 +1,25 @@ +; Check that we skip transformations if the attribute unsafe-fp-math +; is not set. +; RUN: opt < %s -instcombine -S | FileCheck %s + +define float @mysqrt(float %x, float %y) #0 { +entry: + %x.addr = alloca float, align 4 + %y.addr = alloca float, align 4 + store float %x, float* %x.addr, align 4 + store float %y, float* %y.addr, align 4 + %0 = load float, float* %x.addr, align 4 + %1 = load float, float* %x.addr, align 4 + %mul = fmul fast float %0, %1 + %2 = call float @llvm.sqrt.f32(float %mul) + ret float %2 +} + +declare float @llvm.sqrt.f32(float) #1 + +; CHECK: define float @mysqrt(float %x, float %y) { +; CHECK: entry: +; CHECK: %mul = fmul fast float %x, %x +; CHECK: %0 = call float @llvm.sqrt.f32(float %mul) +; CHECK: ret float %0 +; CHECK: } -- 2.34.1