From caf471e8202bb32ca16b5d176de533b3aa53323e Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Sat, 2 Aug 2014 11:34:23 +0000 Subject: [PATCH] [x86] Remove the FIXME that was implemented in r214628. Managed to forget to update the comment here... =/ git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214630 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/X86/X86ISelLowering.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index eb722daef7f..5ae752c1da5 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -18945,10 +18945,6 @@ static bool combineX86ShuffleChain(SDValue Op, SDValue Root, ArrayRef Mask, /// This should never be an issue in practice as the shuffle lowering doesn't /// produce sequences of more than 8 instructions. /// -/// FIXME: Currently, we don't collapse instructions *into* PSHUFB. We should, -/// and we should do so more aggressively than we form PSHUFB because once we -/// have a PSHUFB, we might as well do as much shuffling as we can. -/// /// FIXME: We will currently miss some cases where the redundant shuffling /// would simplify under the threshold for PSHUFB formation because of /// combine-ordering. To fix this, we should do the redundant instruction -- 2.34.1