From c7897e26a45b06fc8c739443fb75c9c6bb908ec5 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Mon, 18 May 2009 18:18:57 +0000 Subject: [PATCH] Add assertions to CastInst::getCastOpcode to catch attempted conversions between integers and pointers when the source type is marked signed, since inttoptr and ptrtoint always use zero-extension when the destination is larger than the source. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@72025 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/Instructions.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/VMCore/Instructions.cpp b/lib/VMCore/Instructions.cpp index fe30271f844..0dd69a18bc9 100644 --- a/lib/VMCore/Instructions.cpp +++ b/lib/VMCore/Instructions.cpp @@ -2220,6 +2220,8 @@ CastInst::getCastOpcode( } else { assert(isa(SrcTy) && "Casting from a value that is not first-class type"); + assert(!SrcIsSigned && + "Pointer types cannot be considered signed for conversions!"); return PtrToInt; // ptr -> int } } else if (DestTy->isFloatingPoint()) { // Casting to floating pt @@ -2259,6 +2261,7 @@ CastInst::getCastOpcode( if (isa(SrcTy)) { return BitCast; // ptr -> ptr } else if (SrcTy->isInteger()) { + assert(!SrcIsSigned && "Cannot cast signed integer to pointer!"); return IntToPtr; // int -> ptr } else { assert(!"Casting pointer to other than pointer or int"); -- 2.34.1