From bdf296fb06c18d81fe2272397d260686c9e82a82 Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Thu, 22 Jan 2015 22:04:47 +0000 Subject: [PATCH] [Object] Fix a bug in a condition introduced in r226217 - visibility can't be both hidden and default. Bug found by inspection by Rafael Espindola. No test: As discussed in the commit message for r226217 we don't have a good way to test this yet. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@226869 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Object/ELFObjectFile.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/llvm/Object/ELFObjectFile.h b/include/llvm/Object/ELFObjectFile.h index 07f9542263b..125fdd17743 100644 --- a/include/llvm/Object/ELFObjectFile.h +++ b/include/llvm/Object/ELFObjectFile.h @@ -185,7 +185,7 @@ protected: // visibility is either DEFAULT or PROTECTED. All other symbols are not // exported. if ((Binding == ELF::STB_GLOBAL || Binding == ELF::STB_WEAK) && - (Visibility == ELF::STV_DEFAULT && Visibility == ELF::STV_PROTECTED)) + (Visibility == ELF::STV_DEFAULT || Visibility == ELF::STV_PROTECTED)) return true; return false; -- 2.34.1