From bbf57b36bbfbfe6c4167751919f5bfd8a141036b Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Thu, 14 May 2015 05:53:53 +0000 Subject: [PATCH] [TableGen] Replace some calls to ListInit::getSize() with ListInit::empty() if it was just comparing to 0. NFC. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@237340 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/TableGen/Record.cpp | 6 +++--- lib/TableGen/TGParser.cpp | 2 +- utils/TableGen/CodeGenDAGPatterns.cpp | 4 ++-- utils/TableGen/CodeGenMapTable.cpp | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/TableGen/Record.cpp b/lib/TableGen/Record.cpp index ad9aea20449..9c8a06f2b5f 100644 --- a/lib/TableGen/Record.cpp +++ b/lib/TableGen/Record.cpp @@ -778,14 +778,14 @@ Init *UnOpInit::Fold(Record *CurRec, MultiClass *CurMultiClass) const { } case HEAD: { if (ListInit *LHSl = dyn_cast(LHS)) { - assert(LHSl->getSize() != 0 && "Empty list in car"); + assert(!LHSl->empty() && "Empty list in car"); return LHSl->getElement(0); } break; } case TAIL: { if (ListInit *LHSl = dyn_cast(LHS)) { - assert(LHSl->getSize() != 0 && "Empty list in cdr"); + assert(!LHSl->empty() && "Empty list in cdr"); // Note the +1. We can't just pass the result of getValues() // directly. return ListInit::get(LHSl->getValues().slice(1), LHSl->getType()); @@ -794,7 +794,7 @@ Init *UnOpInit::Fold(Record *CurRec, MultiClass *CurMultiClass) const { } case EMPTY: { if (ListInit *LHSl = dyn_cast(LHS)) { - if (LHSl->getSize() == 0) + if (LHSl->empty()) return IntInit::get(1); return IntInit::get(0); } diff --git a/lib/TableGen/TGParser.cpp b/lib/TableGen/TGParser.cpp index 56f156dceab..23ef5354fca 100644 --- a/lib/TableGen/TGParser.cpp +++ b/lib/TableGen/TGParser.cpp @@ -841,7 +841,7 @@ Init *TGParser::ParseOperation(Record *CurRec, RecTy *ItemType) { return nullptr; } - if (LHSl && LHSl->getSize() == 0) { + if (LHSl && LHSl->empty()) { TokError("empty list argument in unary operator"); return nullptr; } diff --git a/utils/TableGen/CodeGenDAGPatterns.cpp b/utils/TableGen/CodeGenDAGPatterns.cpp index f03ef61b457..fd02bbdc6b4 100644 --- a/utils/TableGen/CodeGenDAGPatterns.cpp +++ b/utils/TableGen/CodeGenDAGPatterns.cpp @@ -3076,7 +3076,7 @@ void CodeGenDAGPatterns::ParseInstructions() { // null_frag operator is as-if no pattern were specified. Normally this // is from a multiclass expansion w/ a SDPatternOperator passed in as // null_frag. - if (!LI || LI->getSize() == 0 || hasNullFragReference(LI)) { + if (!LI || LI->empty() || hasNullFragReference(LI)) { std::vector Results; std::vector Operands; @@ -3399,7 +3399,7 @@ void CodeGenDAGPatterns::ParsePatterns() { Pattern->InlinePatternFragments(); ListInit *LI = CurPattern->getValueAsListInit("ResultInstrs"); - if (LI->getSize() == 0) continue; // no pattern. + if (LI->empty()) continue; // no pattern. // Parse the instruction. TreePattern Result(CurPattern, LI, false, *this); diff --git a/utils/TableGen/CodeGenMapTable.cpp b/utils/TableGen/CodeGenMapTable.cpp index 8abea4808ba..b52a91d0177 100644 --- a/utils/TableGen/CodeGenMapTable.cpp +++ b/utils/TableGen/CodeGenMapTable.cpp @@ -128,7 +128,7 @@ public: ListInit *ColValList = MapRec->getValueAsListInit("ValueCols"); // Each instruction map must specify at least one column for it to be valid. - if (ColValList->getSize() == 0) + if (ColValList->empty()) PrintFatalError(MapRec->getLoc(), "InstrMapping record `" + MapRec->getName() + "' has empty " + "`ValueCols' field!"); -- 2.34.1