From b2026a6a18f751474d19094b8d5cd3356c311973 Mon Sep 17 00:00:00 2001 From: Balaram Makam Date: Thu, 20 Aug 2015 15:35:00 +0000 Subject: [PATCH] Optimize bitwise even/odd test (-x&1 -> x&1) to not use negation. Summary: We know that -x & 1 is equivalent to x & 1, avoid using negation for testing if a negative integer is even or odd. Reviewers: majnemer Subscribers: junbuml, mssimpso, gberry, mcrosier, llvm-commits Differential Revision: http://reviews.llvm.org/D12156 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@245569 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../InstCombine/InstCombineAndOrXor.cpp | 4 +++ test/Transforms/InstCombine/and2.ll | 25 +++++++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp index 15e0889b51b..e210c99d126 100644 --- a/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp +++ b/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp @@ -1273,6 +1273,10 @@ Instruction *InstCombiner::visitAnd(BinaryOperator &I) { if (Value *V = FoldLogicalPlusAnd(Op0LHS, Op0RHS, AndRHS, true, I)) return BinaryOperator::CreateAnd(V, AndRHS); + // -x & 1 -> x & 1 + if (AndRHSMask == 1 && match(Op0LHS, m_Zero())) + return BinaryOperator::CreateAnd(Op0RHS, AndRHS); + // (A - N) & AndRHS -> -N & AndRHS iff A&AndRHS==0 and AndRHS // has 1's for all bits that the subtraction with A might affect. if (Op0I->hasOneUse() && !match(Op0LHS, m_Zero())) { diff --git a/test/Transforms/InstCombine/and2.ll b/test/Transforms/InstCombine/and2.ll index 96b535dda99..9be6b58979d 100644 --- a/test/Transforms/InstCombine/and2.ll +++ b/test/Transforms/InstCombine/and2.ll @@ -77,3 +77,28 @@ define i1 @test8(i32 %i) { %cond = and i1 %cmp1, %cmp2 ret i1 %cond } + +; combine -x & 1 into x & 1 +define i64 @test9(i64 %x) { +; CHECK-LABEL: @test9( +; CHECK-NOT: %sub = sub nsw i64 0, %x +; CHECK-NOT: %and = and i64 %sub, 1 +; CHECK-NEXT: %and = and i64 %x, 1 +; CHECK-NEXT: ret i64 %and + %sub = sub nsw i64 0, %x + %and = and i64 %sub, 1 + ret i64 %and +} + +define i64 @test10(i64 %x) { +; CHECK-LABEL: @test10( +; CHECK-NOT: %sub = sub nsw i64 0, %x +; CHECK-NEXT: %and = and i64 %x, 1 +; CHECK-NOT: %add = add i64 %sub, %and +; CHECK-NEXT: %add = sub i64 %and, %x +; CHECK-NEXT: ret i64 %add + %sub = sub nsw i64 0, %x + %and = and i64 %sub, 1 + %add = add i64 %sub, %and + ret i64 %add +} -- 2.34.1