From 919b448c2e44c6f3923350eb7b02c41786b21704 Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Thu, 17 Sep 2015 22:29:58 +0000 Subject: [PATCH] [llvm-readobj] Fix another "time of check to time of use bug". It seems there's more copy-paste between tools than needed. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247954 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/tools/llvm-readobj/basic.test | 2 ++ tools/llvm-readobj/llvm-readobj.cpp | 5 ----- 2 files changed, 2 insertions(+), 5 deletions(-) create mode 100644 test/tools/llvm-readobj/basic.test diff --git a/test/tools/llvm-readobj/basic.test b/test/tools/llvm-readobj/basic.test new file mode 100644 index 00000000000..fc6349bcfbf --- /dev/null +++ b/test/tools/llvm-readobj/basic.test @@ -0,0 +1,2 @@ +RUN: not llvm-readobj %t.blah 2>&1 | FileCheck --check-prefix=ENOENT %s +ENOENT: {{.*}}.blah: {{[Nn]}}o such file or directory diff --git a/tools/llvm-readobj/llvm-readobj.cpp b/tools/llvm-readobj/llvm-readobj.cpp index a8e4ca4893f..7e7c4eeaff7 100644 --- a/tools/llvm-readobj/llvm-readobj.cpp +++ b/tools/llvm-readobj/llvm-readobj.cpp @@ -394,11 +394,6 @@ static void dumpMachOUniversalBinary(const MachOUniversalBinary *UBinary) { /// @brief Opens \a File and dumps it. static void dumpInput(StringRef File) { - // If file isn't stdin, check that it exists. - if (File != "-" && !sys::fs::exists(File)) { - reportError(File, readobj_error::file_not_found); - return; - } // Attempt to open the binary. ErrorOr> BinaryOrErr = createBinary(File); -- 2.34.1