From 912c49d169479ea713dfdee6fd7a2909c1147dab Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Tue, 2 Dec 2008 04:09:22 +0000 Subject: [PATCH] Fix an issue that Chris noticed, where local PRE was not properly instantiating a new value numbering set after splitting a critical edge. This increases the number of instances of PRE on 403.gcc from ~60 to ~570. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@60393 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/GVN.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/Transforms/Scalar/GVN.cpp b/lib/Transforms/Scalar/GVN.cpp index d1f413eea29..039d52029aa 100644 --- a/lib/Transforms/Scalar/GVN.cpp +++ b/lib/Transforms/Scalar/GVN.cpp @@ -1299,6 +1299,7 @@ bool GVN::performPRE(Function& F) { if (isCriticalEdge(PREPred->getTerminator(), succNum)) { toSplit.push_back(std::make_pair(PREPred->getTerminator(), succNum)); + Changed = true; continue; } @@ -1361,10 +1362,14 @@ bool GVN::performPRE(Function& F) { } for (SmallVector, 4>::iterator - I = toSplit.begin(), E = toSplit.end(); I != E; ++I) + I = toSplit.begin(), E = toSplit.end(); I != E; ++I) { SplitCriticalEdge(I->first, I->second, this); + BasicBlock* NewBlock = I->first->getSuccessor(I->second); + localAvail[NewBlock] = + new ValueNumberScope(localAvail[I->first->getParent()]); + } - return Changed || toSplit.size(); + return Changed; } // iterateOnFunction - Executes one iteration of GVN -- 2.34.1