From 7ca9d81bce9b3ea6ed2f5e7476a6c4d15c882b2a Mon Sep 17 00:00:00 2001 From: Duncan Sands Date: Tue, 9 Sep 2008 19:56:34 +0000 Subject: [PATCH] Simplify this some more. No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@56003 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/IPA/CallGraph.cpp | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/lib/Analysis/IPA/CallGraph.cpp b/lib/Analysis/IPA/CallGraph.cpp index 1a65179c5aa..fba1d00d48c 100644 --- a/lib/Analysis/IPA/CallGraph.cpp +++ b/lib/Analysis/IPA/CallGraph.cpp @@ -124,26 +124,19 @@ private: } } + // Loop over all of the users of the function, looking for non-call uses. + for (Value::use_iterator I = F->use_begin(), E = F->use_end(); I != E; ++I) + if ((!isa(*I) && !isa(*I)) || I.getOperandNo()) { + // Not a call, or being used as a parameter rather than as the callee. + ExternalCallingNode->addCalledFunction(CallSite(), Node); + break; + } + // If this function is not defined in this translation unit, it could call // anything. if (F->isDeclaration() && !F->isIntrinsic()) Node->addCalledFunction(CallSite(), CallsExternalNode); - // Loop over all of the users of the function, looking for non-call uses. - bool isUsedExternally = false; - for (Value::use_iterator I = F->use_begin(), E = F->use_end(); - I != E && !isUsedExternally; ++I) { - if (Instruction *Inst = dyn_cast(*I)) { - CallSite CS = CallSite::get(Inst); - // Not a call? Or F being passed as a parameter not as the callee? - isUsedExternally = !CS.getInstruction() || I.getOperandNo(); - } else { // User is not a direct call! - isUsedExternally = true; - } - } - if (isUsedExternally) - ExternalCallingNode->addCalledFunction(CallSite(), Node); - // Look for calls by this function. for (Function::iterator BB = F->begin(), BBE = F->end(); BB != BBE; ++BB) for (BasicBlock::iterator II = BB->begin(), IE = BB->end(); -- 2.34.1