From 7b1e2a50a51793428a792a15d2777a4c48e0db49 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Thu, 7 Jan 2010 17:27:56 +0000 Subject: [PATCH] Use pop_back_val instead of back()+pop_back. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@92918 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp index 352b0efe06c..10dcc09c8ec 100644 --- a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp +++ b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp @@ -456,8 +456,7 @@ void SelectionDAGISel::ShrinkDemandedOps() { TargetLowering::TargetLoweringOpt TLO(*CurDAG, true); while (!Worklist.empty()) { - SDNode *N = Worklist.back(); - Worklist.pop_back(); + SDNode *N = Worklist.pop_back_val(); if (N->use_empty() && N != CurDAG->getRoot().getNode()) { CurDAG->DeleteNode(N); @@ -467,7 +466,6 @@ void SelectionDAGISel::ShrinkDemandedOps() { // Run ShrinkDemandedOp on scalar binary operations. if (N->getNumValues() == 1 && N->getValueType(0).isSimple() && N->getValueType(0).isInteger()) { - DebugLoc dl = N->getDebugLoc(); unsigned BitWidth = N->getValueType(0).getScalarType().getSizeInBits(); APInt Demanded = APInt::getAllOnesValue(BitWidth); APInt KnownZero, KnownOne; @@ -520,9 +518,8 @@ void SelectionDAGISel::ComputeLiveOutVRegInfo() { APInt KnownZero; APInt KnownOne; - while (!Worklist.empty()) { - SDNode *N = Worklist.back(); - Worklist.pop_back(); + do { + SDNode *N = Worklist.pop_back_val(); // If we've already seen this node, ignore it. if (!VisitedNodes.insert(N)) @@ -562,7 +559,7 @@ void SelectionDAGISel::ComputeLiveOutVRegInfo() { LOI.KnownOne = KnownOne; LOI.KnownZero = KnownZero; } - } + } while (!Worklist.empty()); } void SelectionDAGISel::CodeGenAndEmitDAG() { -- 2.34.1