From 621c80f4d714ff31ef9f9627b5fee499e466a9fd Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Thu, 13 Feb 2014 11:25:17 +0000 Subject: [PATCH] [CMake] Let llvm_add_library(MODULE) check capability of loadable module. On unsupported platforms, llvm_add_library(MODULE) doesn't create any targets. Caller may be responsible to check and add extra target properties. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@201320 91177308-0d34-0410-b5e6-96231b3b80d8 --- cmake/modules/AddLLVM.cmake | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/cmake/modules/AddLLVM.cmake b/cmake/modules/AddLLVM.cmake index 776808d6bb1..39badf41d77 100644 --- a/cmake/modules/AddLLVM.cmake +++ b/cmake/modules/AddLLVM.cmake @@ -163,9 +163,12 @@ function(set_output_directory target bindir libdir) endfunction() # llvm_add_library(name sources... -# MODULE;SHARED;STATIC +# SHARED;STATIC # STATIC by default w/o BUILD_SHARED_LIBS. # SHARED by default w/ BUILD_SHARED_LIBS. +# MODULE +# Target ${name} might not be created on unsupported platforms. +# Check with "if(TARGET ${name})". # OUTPUT_NAME name # Corresponds to OUTPUT_NAME in target properties. # DEPENDS targets... @@ -194,6 +197,10 @@ function(llvm_add_library name) if(ARG_SHARED OR ARG_STATIC) message(WARNING "MODULE with SHARED|STATIC doesn't make sense.") endif() + if(NOT LLVM_ON_UNIX OR CYGWIN) + message(STATUS "${name} ignored -- Loadable modules not supported on this platform.") + return() + endif() else() if(BUILD_SHARED_LIBS AND NOT ARG_STATIC) set(ARG_SHARED TRUE) @@ -281,14 +288,11 @@ macro(add_llvm_library name) endmacro(add_llvm_library name) macro(add_llvm_loadable_module name) - if( NOT LLVM_ON_UNIX OR CYGWIN ) - message(STATUS "Loadable modules not supported on this platform. -${name} ignored.") + llvm_add_library(${name} MODULE ${ARGN}) + if(NOT TARGET ${name}) # Add empty "phony" target add_custom_target(${name}) else() - llvm_add_library(${name} MODULE ${ARGN}) - if( EXCLUDE_FROM_ALL ) set_target_properties( ${name} PROPERTIES EXCLUDE_FROM_ALL ON) else() -- 2.34.1