From 3b294b5753dc55fd6b12bc803b0054663305c5b1 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Thu, 21 May 2015 19:54:44 +0000 Subject: [PATCH] writeSymbolTable now only needs a MCContext. It used to use an MCAssembler just to record the alignment of the sections. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@237944 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/MC/ELFObjectWriter.cpp | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/lib/MC/ELFObjectWriter.cpp b/lib/MC/ELFObjectWriter.cpp index ad3debf090b..7437aff3120 100644 --- a/lib/MC/ELFObjectWriter.cpp +++ b/lib/MC/ELFObjectWriter.cpp @@ -193,7 +193,7 @@ class ELFObjectWriter : public MCObjectWriter { typedef std::map> SectionOffsetsTy; - void WriteSymbolTable(MCAssembler &Asm, const MCAsmLayout &Layout, + void writeSymbolTable(MCContext &Ctx, const MCAsmLayout &Layout, SectionOffsetsTy &SectionOffsets); bool shouldRelocateWithSymbol(const MCAssembler &Asm, @@ -538,19 +538,15 @@ void ELFObjectWriter::WriteSymbol(SymbolTableWriter &Writer, ELFSymbolData &MSD, MSD.SectionIndex, IsReserved); } -void ELFObjectWriter::WriteSymbolTable(MCAssembler &Asm, +void ELFObjectWriter::writeSymbolTable(MCContext &Ctx, const MCAsmLayout &Layout, SectionOffsetsTy &SectionOffsets) { - - MCContext &Ctx = Asm.getContext(); - unsigned EntrySize = is64Bit() ? ELF::SYMENTRY_SIZE64 : ELF::SYMENTRY_SIZE32; // Symbol table MCSectionELF *SymtabSection = Ctx.getELFSection(".symtab", ELF::SHT_SYMTAB, 0, EntrySize, ""); - MCSectionData &SymtabSD = Asm.getOrCreateSectionData(*SymtabSection); - SymtabSD.setAlignment(is64Bit() ? 8 : 4); + SymtabSection->setAlignment(is64Bit() ? 8 : 4); SymbolTableIndex = addToSectionTable(SymtabSection); // The string table must be emitted first because we need the index @@ -558,7 +554,8 @@ void ELFObjectWriter::WriteSymbolTable(MCAssembler &Asm, SymbolTableWriter Writer(*this, is64Bit()); - uint64_t Padding = OffsetToAlignment(OS.tell(), SymtabSD.getAlignment()); + uint64_t Padding = + OffsetToAlignment(OS.tell(), SymtabSection->getAlignment()); WriteZeros(Padding); uint64_t SecStart = OS.tell(); @@ -609,9 +606,7 @@ void ELFObjectWriter::WriteSymbolTable(MCAssembler &Asm, MCSectionELF *SymtabShndxSection = Ctx.getELFSection(".symtab_shndxr", ELF::SHT_SYMTAB_SHNDX, 0, 4, ""); addToSectionTable(SymtabShndxSection); - MCSectionData *SymtabShndxSD = - &Asm.getOrCreateSectionData(*SymtabShndxSection); - SymtabShndxSD->setAlignment(4); + SymtabShndxSection->setAlignment(4); for (uint32_t Index : ShndxIndexes) write(Index); SecEnd = OS.tell(); @@ -1412,7 +1407,7 @@ void ELFObjectWriter::WriteObject(MCAssembler &Asm, ComputedSymtab = true; } - WriteSymbolTable(Asm, Layout, SectionOffsets); + writeSymbolTable(Ctx, Layout, SectionOffsets); { uint64_t SecStart = OS.tell(); -- 2.34.1